Eric Wong wrote:
> Roland McGrath wrote:
> > Oh, I didn't notice they weren't identical. You're right that it shouldn't
> > use plain "Likewise." then. But you could write:
> >
> > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> > Likewise for __internal_statvfs64.
> >
> > >
Roland McGrath wrote:
> Oh, I didn't notice they weren't identical. You're right that it shouldn't
> use plain "Likewise." then. But you could write:
>
> * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> Likewise for __internal_statvfs64.
>
> > I'm not fan of signing into we
> Roland McGrath wrote:
> > That looks fine.
> >
> > > * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs):
> > > Pass fd to __internal_statvfs instead of calling fstat64.
> > > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> > > Pass fd to __internal_statvfs64 instead of calling f
Roland McGrath wrote:
> That looks fine.
>
> > * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs):
> > Pass fd to __internal_statvfs instead of calling fstat64.
> > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> > Pass fd to __internal_statvfs64 instead of calling fstat64
That looks fine.
> * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs):
> Pass fd to __internal_statvfs instead of calling fstat64.
> * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> Pass fd to __internal_statvfs64 instead of calling fstat64.
In a case like this, it'
- 8< ---
>From 92f694865d0014bffd0069c549c4a6274e2f1430 Mon Sep 17 00:00:00 2001
From: Eric Wong
Date: Fri, 1 Feb 2013 01:55:27 +
Subject: [PATCH] avoid stat/fstat in statvfs/fstatvfs
Delay the use of stat/fstat until stat data is required.
When the kernel returns ST_VALID, stat d
The patch itself now looks fine to me. The log entry is inadequate.
It needs to mention each file and function touched and say what was
done there. "Update caller." is sufficient text for a function to
which the only change was trivial argument reordering or whatnot. But
in most of these cases,
2910d897d72ddea Mon Sep 17 00:00:00 2001
From: Eric Wong
Date: Fri, 1 Feb 2013 01:55:27 +
Subject: [PATCH] avoid stat/fstat in statvfs/fstatvfs
Delay the use of stat/fstat until stat data is required.
When the kernel returns ST_VALID, stat data is not used
by __internal_statvfs.
2013-02-07 E
The substance of the change seems fine. It needs a proper ChangeLog entry.
See the glibc wiki for full instructions on posting patches.
> + struct stat64 st;
> + int r = fd >= 0 ? fstat64(fd, &st) : stat64(name, &st);
Put space before paren in those calls.
It's shorter and more common to inver
for looking at this, hopefully somebody from Debian can help.
>From 2374682f5dc38d7cc752cdbdecd55bd870b38a90 Mon Sep 17 00:00:00 2001
From: Eric Wong
Date: Fri, 1 Feb 2013 01:55:27 +
Subject: [PATCH] avoid stat/fstat in statvfs/fstatvfs
Delay the use of stat/fstat until stat data is requ
10 matches
Mail list logo
