Re: [PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function

2018-06-25 Thread Pádraig Brady
On 25/06/18 18:20, Bruno Haible wrote: > Hi Jim, > >> diff --git a/lib/acl-internal.h b/lib/acl-internal.h >> index 6c65e65e5..0669d83c4 100644 >> --- a/lib/acl-internal.h >> +++ b/lib/acl-internal.h >> @@ -293,10 +293,6 @@ struct permission_context { >> >> int get_permissions (const char *, int,

Re: [PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function

2018-06-25 Thread Paul Eggert
On 06/25/2018 06:20 PM, Bruno Haible wrote: One version of GCC wants the 'const' attribute, another one complains about it... Isn't it time to disable either -Werror or -Wattribute? I've found -Wattribute and -Werror to be useful with recent GCC. However, the cost of pacifying older GCC's war

Re: [PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function

2018-06-25 Thread Bruno Haible
Hi Jim, > diff --git a/lib/acl-internal.h b/lib/acl-internal.h > index 6c65e65e5..0669d83c4 100644 > --- a/lib/acl-internal.h > +++ b/lib/acl-internal.h > @@ -293,10 +293,6 @@ struct permission_context { > > int get_permissions (const char *, int, mode_t, struct permission_context *); > int set

[PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function

2018-06-25 Thread Jim Meyering
FYI, I saw another coreutils build failure when configured with --enable-gcc-warnings and this addresses it: >From ed78f0e059003680af6476989c39c9ba18ae3fd0 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 25 Jun 2018 08:28:12 -0700 Subject: [PATCH] acl-internal.h: rem