> 2023-01-13 Bruno Haible
>
> qcopy-acl: Adjust link dependencies.
> * modules/qcopy-acl (Depends-on): Add condition.
> (configure.ac): Set QCOPY_ACL_LIB.
> (Link): Add $(QCOPY_ACL_LIB). Remove $(LIB_ACL).
> * modules/qacl (Link): Add $(LIB_ACL) and $(QCOPY_ACL_LIB
Haible
Sent: Saturday, January 14, 2023 8:55:25 AM
To: Ondrej Valousek
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
> Why this conversation (+the whole one from yesterday) is missing from the
> bug-gnulib mail archives?
https://jpn01.safelinks.protection
> Why this conversation (+the whole one from yesterday) is missing from the
> bug-gnulib mail archives?
https://lists.gnu.org/archive/html/bug-gnulib/2023-01/threads.html
looks good to me. Did you press "Refresh" in the browser?
Bruno
k
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
On 2023-01-13 00:46, Bruno Haible wrote:
> Then the one in coreutils will have to be deleted, because it conflicts
> with the one from Gnulib.
Thanks for mentioning that. I deleted coreutils/m4/xattr.m4 and sync
On 2023-01-13 00:46, Bruno Haible wrote:
Then the one in coreutils will have to be deleted, because it conflicts
with the one from Gnulib.
Thanks for mentioning that. I deleted coreutils/m4/xattr.m4 and synced
coreutils from Gnulib.
I wrote:
> * modules/qcopy-acl (Depends-on): Add condition.
> (configure.ac): Set QCOPY_ACL_LIB.
> (Link): Add $(QCOPY_ACL_LIB). Remove $(LIB_ACL).
Oops, this has a mistake. The variable LIB_ACL needs to be initialized
before the code uses its value; otherwise $LIB_ACL will come
Hi Ondrej,
> To be honest, I did not test the automake stuff, I only tested the
> functionality via coreutils.
Testing via a Gnulib testdir is also necessary:
* For testing the module descriptions. When you test via coreutils, you
are testing only a specific use. You will rarely detect a m
,
Ondrej
-Original Message-
From: Bruno Haible
Sent: pátek 13. ledna 2023 9:10
To: bug-gnulib@gnu.org; Ondrej Valousek
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
This part
> Also, protect against unsafe use of a configure option value.
is needed when the user does
./config
Paul Eggert wrote:
> Sure, as long as the linker dependencies are fixed soon we'll be OK.
The linker dependencies are fixed through this patch. It was only a
matter of
1) going through all reverse module dependencies,
2) building a testdir of these modules with --enable-xattr and looking
out fo
This part
> Also, protect against unsafe use of a configure option value.
is needed when the user does
./configure --enable-xattr="no no"
In this case we don't want to see an error during configuration:
checking for opendir... yes
../configure: line 29819: test: too many arguments
checki
Hi Ondrej,
How did you test your patch? When I run
$ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure \
acl-permissions copy-file qcopy-acl qset-acl supersede acl
(with autoconf 2.71), I get two warnings:
autoheader: warning: missing template: USE_XATTR
On 1/12/23 12:58, Bruno Haible wrote:
1. remove the ALLOWing part of the old ACL,
2. add the DENYing part of the new ACL,
3. copy the data,
4. remove the DENYing part of the old ACL (as far as not also contained
in the new ACL),
5. add the ALLOWing part of the new ACL.
Somet
[Re-adding bug-gnulib in CC]
Paul Eggert wrote:
> > - similar vulnerability does exist in the old code, too
> ...
> But really, isn't it *odd* that there's no way to copy a file securely
> with ACLs (either with xattr or without)? What's up with that? Didn't
> ACL/xattr designers think about cop
Ondrej Valousek wrote:
> Hi Bruno/Paul,
>
> Are we going to commit the proposed changes there or is there still anything
> missing?
> I am asking because I'd like to file a RFE for redhat coreutils improvement
> and this change depends on it.
Paul gave his OK in off-list email. So I pushed your
ledna 2023 20:07
To: Bruno Haible ; bug-gnulib@gnu.org; Ondrej Valousek
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
On 2023-01-05 02:32, Bruno Haible wrote:
> Yes, this is OK. I can work on the linker dependencies shortly after
> your patch is in. Basically it consists in compilin
On 2023-01-05 02:32, Bruno Haible wrote:
Yes, this is OK. I can work on the linker dependencies shortly after your
patch is in. Basically it consists in compiling a testdir
Sure, as long as the linker dependencies are fixed soon we'll be OK.
Ondrej Valousek wrote:
> Can we accept the patch as it is for now and work in the linker dependency
> with a different commit perhaps?
Yes, this is OK. I can work on the linker dependencies shortly after your
patch is in. Basically it consists in compiling a testdir
./gnulib-tool --create-testd
@gnu.org; Ondrej Valousek
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
Ondrej Valousek wrote:
> Why don't we solve the linker problem with the "--as-needed" option? This
> will make linker clever enough not to link libraries that are not needed.
'--as-needed&#x
Ondrej Valousek wrote:
> Why don't we solve the linker problem with the "--as-needed" option? This
> will make linker clever enough not to link libraries that are not needed.
'--as-needed' is a can of worms in itself. In GNU gettext (IIRC) Debian
used '--as-needed' in the link command line, and t
Paul Eggert wrote:
> I see a problem in linking. With this change, programs using the
> qcopy-acl module will link to both $(LIB_ACL) and $(LIB_XATTR), even
> though they do not need to link with $(LIB_ACL). Perhaps you can fix
> this by fixing the Link sections of the relevant modules to use
>
On 2023-01-04 12:54, Ondrej Valousek wrote:
LIB_HAS_ACL has value only if glibc does not know getxattr() system call. It
has nothing to do with libattr (yes, it's bit confusing).
No kidding. This stuff is wyy too complicated.
Why don't we solve the linker problem with the "--as-needed" o
> Perhaps you can fix
this by fixing the Link sections of the relevant modules to use
$(LIB_HAS_ACL) instead of $(LIB_ACL). That is, for each module where you
added $(LIB_XATTR), replace its $(LIB_ACL) with $(LIB_HAS_ACL) if the
only reason it needed $(LIB_ACL) was to copy attributes.
Nope. LIB_H
On 2023-01-04 06:46, Bruno Haible wrote:
To me, it looks good. Paul's opinion?
I see a problem in linking. With this change, programs using the
qcopy-acl module will link to both $(LIB_ACL) and $(LIB_XATTR), even
though they do not need to link with $(LIB_ACL). Perhaps you can fix
this by fixi
Hi Ondrej,
> Please review now.
To me, it looks good. Paul's opinion?
Bruno
Hi Bruno,
Please review now.
Ondrej
---
lib/qcopy-acl.c | 36 ++-
m4/xattr.m4 | 42 +
modules/acl | 1 +
modules/acl-tests | 6 +++---
modules/copy-file | 1 +
modules/copy-file-
25 matches
Mail list logo
