Re: [PATCH] Simplify and regularize regex use of ‘assert’

2019-10-13 Thread Paul Eggert
On 10/13/19 5:20 AM, Bruno Haible wrote: Karl's autoupdate from glibc reverted this change. Thanks for mentioning that. I installed the attached to fix it. I do plan to migrate this back to glibc, but one step at a time. >From 6cfb4302b3e1da14d706198b693558290e9b00f4 Mon Sep 17 00:00:00 2001 F

Re: [PATCH] Simplify and regularize regex use of ‘assert’

2019-10-13 Thread Bruno Haible
Hi Paul, > * lib/regex_internal.c (build_wcs_buffer) > (build_wcs_upper_buffer, re_string_reconstruct) > (re_string_context_at): Note: Karl's autoupdate from glibc reverted this change. Bruno

[PATCH] Simplify and regularize regex use of ‘assert’

2019-10-11 Thread Paul Eggert
Also, tell GCC about the asserts even when compiling without debugging, to give it further optimization opportunities. * lib/regex_internal.h (DEBUG_ASSERT): New macro. * lib/regcomp.c (link_nfa_nodes, calc_eclosure) (parse_expression, parse_bracket_exp): * lib/regex_internal.c (build_wcs_buffer) (