Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-29 Thread Pádraig Brady
On 29/10/17 00:28, Assaf Gordon wrote: > Hello, > > On 2017-10-24 04:09 AM, Bruno Haible wrote: Indeed, we don't have many crypto experts on the gnulib mailing lists. Therefore, I too would like the crypto experts on the libgcrypt or openssl mailing lists to evaluate the SM3 algorit

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-29 Thread Assaf Gordon
Hello, On 2017-10-24 04:09 AM, Bruno Haible wrote: Indeed, we don't have many crypto experts on the gnulib mailing lists. Therefore, I too would like the crypto experts on the libgcrypt or openssl mailing lists to evaluate the SM3 algorithm and your code first, before we can accept it in gnulib.

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Jia Zhang
于 2017/10/28 下午9:09, Bruno Haible 写道: > Jia Zhang wrote: >>> gcc: error: @LIB_CRYPTO@: No such file or directory >> >> Thanks for your comments. I fixed it and the test passes. I just >> feel strange that test-sm3 was built out without error if I >> compiled gnulib with coreutils together. > >

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Bruno Haible
Jia Zhang wrote: > > gcc: error: @LIB_CRYPTO@: No such file or directory > > Thanks for your comments. I fixed it and the test passes. I just feel > strange that test-sm3 was built out without error if I compiled gnulib > with coreutils together. It passed with coreutils because coreutils request

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Jia Zhang
于 2017/10/28 下午8:44, Bruno Haible 写道: > [Dropping coreutils, since I'm replying only the gnulib part.] > > Hi Jia, > >> Plz refer to the following PRs for code review. >> >> - For the new gnulib module crypto/sm3 >> https://github.com/coreutils/gnulib/pull/3/commits > > Usually, on this mail

Re: [V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Bruno Haible
[Dropping coreutils, since I'm replying only the gnulib part.] Hi Jia, > Plz refer to the following PRs for code review. > > - For the new gnulib module crypto/sm3 > https://github.com/coreutils/gnulib/pull/3/commits Usually, on this mailing list, we share patches through 'git format-patch -1

[V2 PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-28 Thread Jia Zhang
Hi Pádraig & Bruno, This is the V2 review request for SM3 hash algorithm. As promised, I have made SM3 hash algorithm available in the latest libgcrypt. See https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=4423bf3cc4432b9bfe801ff74cb05e6f0dd3eccd The V2 patch adds the support

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-24 Thread Bruno Haible
Hi Jia, > > Indeed, we don't have many crypto experts on the gnulib mailing > > lists. Therefore, I too would like the crypto experts on the > > libgcrypt or openssl mailing lists to evaluate the SM3 algorithm > > and your code first, before we can accept it in gnulib. > > libgcrypt has merged

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-24 Thread Jia Zhang
于 2017/10/11 下午5:13, Bruno Haible 写道: > 张佳(乾越) wrote: >>> Currently, I only implement SM3 in gnulib. I will implement it >>> in libgcrypt and openssl later. > > Yes, for a crypto algorjthm to be widely usable in GNU, it needs > to be available both in GNUTLS (via libgcrypt) and openssl. > > Pád

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-11 Thread 张佳(乾越)
于 2017/10/11 下午5:13, Bruno Haible 写道: 张佳(乾越) wrote: Currently, I only implement SM3 in gnulib. I will implement it in libgcrypt and openssl later. Yes, for a crypto algorjthm to be widely usable in GNU, it needs to be available both in GNUTLS (via libgcrypt) and openssl. Pádraig Brady wrote

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-11 Thread 张佳(乾越)
于 2017/10/11 下午3:15, Pádraig Brady 写道: On 10/10/17 23:58, 张佳(乾越) wrote: Hi, This is the review request for SM3 hash algorithm. SM3 hash algorithm is already accepted and supported by TPM 2.0 spec. See page 284 in TPM 2.0 spec part 1 (https://trustedcomputinggroup.org/wp-content/uploads/TPM-Re

[PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-11 Thread 张佳(乾越)
Hi, This is the review request for SM3 hash algorithm. SM3 hash algorithm is already accepted and supported by TPM 2.0 spec. See page 284 in TPM 2.0 spec part 1 (https://trustedcomputinggroup.org/wp-content/uploads/TPM-Rev-2.0-Part-1-Ar chitecture-01.38.pdf) Currently, I only implement SM3 in gnu

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-11 Thread Bruno Haible
张佳(乾越) wrote: > > Currently, I only implement SM3 in gnulib. I will implement it in > > libgcrypt and > > openssl later. Yes, for a crypto algorjthm to be widely usable in GNU, it needs to be available both in GNUTLS (via libgcrypt) and openssl. Pádraig Brady wrote: > Being available in gnulib is

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-11 Thread Pádraig Brady
On 10/10/17 23:58, 张佳(乾越) wrote: > Hi, > > This is the review request for SM3 hash algorithm. SM3 hash algorithm is > already > accepted and supported by TPM 2.0 spec. See page 284 in TPM 2.0 spec part 1 > (https://trustedcomputinggroup.org/wp-content/uploads/TPM-Rev-2.0-Part-1-Ar > chitecture-01.