Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Jim Meyering
Ralf Wildenhues wrote: > Hi Jim, > > * Jim Meyering wrote on Fri, Jun 11, 2010 at 01:49:35PM CEST: >> +warn_() { echo "$@" 1>&$stderr_fileno_; } >> +fail_() { warn_ "$ME_: failed test: $@"; Exit 1; } >> +skip_() { warn_ "$ME_: skipped test: $@"; Exit 77; } >> +framework_failure_() { warn_ "$ME_: s

Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Fri, Jun 11, 2010 at 01:49:35PM CEST: > +warn_() { echo "$@" 1>&$stderr_fileno_; } > +fail_() { warn_ "$ME_: failed test: $@"; Exit 1; } > +skip_() { warn_ "$ME_: skipped test: $@"; Exit 77; } > +framework_failure_() { warn_ "$ME_: set-up failure: $@"; Exit 1; } Yo

Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Jim Meyering
Paolo Bonzini wrote: > On 06/11/2010 01:49 PM, Jim Meyering wrote: >> Here's a patch that does that at the expense of using >> shell functions*before* guaranteeing we have a decent shell. >> I think that is ok, these days. > > Yes, it is. There may be bugs in the implementation of shell > functio

Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Paolo Bonzini
On 06/11/2010 01:49 PM, Jim Meyering wrote: Here's a patch that does that at the expense of using shell functions*before* guaranteeing we have a decent shell. I think that is ok, these days. Yes, it is. There may be bugs in the implementation of shell functions, but IMO assuming the shell fu

Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Jim Meyering
Stefano Lattarini wrote: > At Friday 11 June 2010, Jim Meyering wrote: >> > diff --git a/tests/init.sh b/tests/init.sh >> > index ef0957c..4eb4a95 100644 >> > --- a/tests/init.sh >> > +++ b/tests/init.sh >> > @@ -97,12 +97,15 @@ else >> > for re_shell_ in "${CONFIG_SHELL:-no_shell}" /bin/sh ba

Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Stefano Lattarini
At Friday 11 June 2010, Jim Meyering wrote: > > diff --git a/tests/init.sh b/tests/init.sh > > index ef0957c..4eb4a95 100644 > > --- a/tests/init.sh > > +++ b/tests/init.sh > > @@ -97,12 +97,15 @@ else > > for re_shell_ in "${CONFIG_SHELL:-no_shell}" /bin/sh bash > > dash zsh pdksh fail do > >

Re: [PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Jim Meyering
Stefano Lattarini wrote: > The attached patch fixes a minor wart in the `tests/init.sh' shell > library. IMO it is simple enough not to require a copyright > assigement for gnulib (which I don't have). > > * tests/init.sh: Do not use `$ME_' and `skip_' before they are > defined. ... Hi Stefano,

[PATCH] Fix buglet in code searching for a good shell (tests/init.sh).

2010-06-11 Thread Stefano Lattarini
e they are defined. ChangeLog |6 ++ tests/init.sh |7 +-- 2 files changed, 11 insertions(+), 2 deletions(-) From 68faf1600420b0daad7191222bf47d3fbde01255 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Fri, 11 Jun 2010 12:19:19 +0200 Subject: [PATCH] Fix buglet in code