Re: [PATCH] Add support for ISO 8601 basic format

Thanks for taking this on. Here is a brief review. The most important thing is that the patch also needs to update doc/parse-datetime.texi. Also, some comments about the code changes: On 03/30/13 12:18, Mihai Capotă wrote: > + /* not ISO 8601 time, forcing mktime error */ > + pc->hour

Re: bug#14097: [PATCH] Add support for ISO 8601 basic format

On Mon, Apr 1, 2013 at 2:51 PM, Eric Blake wrote: > This patch is non-trivial in size. I stopped reviewing here; we would > need to have copyright assignment on file to take this patch from you. > Is this still something you are interested in pursuing? I completed the assignment process. Please

Re: bug#14097: [PATCH] Add support for ISO 8601 basic format

On Mon, Apr 1, 2013 at 2:51 PM, Eric Blake wrote: > This patch is non-trivial in size. I stopped reviewing here; we would > need to have copyright assignment on file to take this patch from you. > Is this still something you are interested in pursuing? Yes, it is. I will take care of the copyrig

Re: bug#14097: [PATCH] Add support for ISO 8601 basic format

On 03/30/2013 01:18 PM, Mihai Capotă wrote: > The parser now accepts the basic format for combined date and time > representations, which ommits the date and time separators, "-" and ":". s/ommits/omits/ > > See bug 23767 for GNU coreutils, . > > * lib/pars

Re: [PATCH] Add support for ISO 8601 basic format

The time-difference module, too? On 03/30/13 12:18, Mihai Capotă wrote: > + /* ISO 8601 basic date and time of day representation, > + 'T' separator, local time zone */ > + p = "20110501T115518"; > + /* ISO 8601 basic date and time of day representation, > + 'T' separator, UTC */ > + p

[PATCH] Add support for ISO 8601 basic format

The parser now accepts the basic format for combined date and time representations, which ommits the date and time separators, "-" and ":". See bug 23767 for GNU coreutils, . * lib/parse-datetime.y: Parse combined date and time representations in ISO 8601 bas