Re: canonicalize-lgpl: support paths of length > 2 GB

2016-10-20 Thread Padraig Brady
> Unfortunately this broke the build on CentOS 3 and 4. Thanks for testing. The attached should address that. >From b5393eae6e267c2c833895dc840b6a85cc94561d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Thu, 20 Oct 2016 11:28:07 -0700 Subject: [PATCH] canonicalize-lgpl: f

Re: quotearg test failures

2016-10-18 Thread Padraig Brady
On 10/18/2016 05:15 AM, Bruno Haible wrote: > > How about this? You are doing multiple passes through the argument string > anyway now. (Originally quotearg was meant as a single-pass implementation, > but it isn't any more.) So > - remove the code block of lines 711..720, > - instead, before t

Re: quotearg test failures

2016-10-18 Thread Padraig Brady
Bruno Haible wrote: > I disagree with the removal of the '%' checks in tests/test-sh-quote.c Agreed. There is a disparity now because there is a switch from a longer (shell) to a more concise (c) quoting style in certain cases (when just a single quote is encountered). This is fine for most interf