Re: xreadlink.c initial buffer size guesstimate

2007-01-16 Thread Liyang HU
On Sat, Jan 13, 2007 at 05:57:24PM -0700, Eric Blake wrote: > According to Liyang HU on 1/13/2007 4:48 PM: > > If xreadlink() assumed POSIX, it would allocate a fixed buffer of 256 bytes. > Wrong. POSIX guarantees that you will have AT LEAST 256, [...] You are absolutely right. >

Re: xreadlink.c initial buffer size guesstimate

2007-01-14 Thread Liyang HU
On Fri, Jan 12, 2007 at 08:30:24AM -0700, Eric Blake wrote: > why should you expect sane behavior from tools that assume POSIX? If xreadlink() assumed POSIX, it would allocate a fixed buffer of 256 bytes. > By violating that rule of POSIX, the bug is squarely on your FS's shoulders, I'm not even

xreadlink.c initial buffer size guesstimate

2007-01-12 Thread Liyang HU
Hallo, I've been getting ``ls: memory exhausted'' messages, which I eventually tracked down to xreadlink() attempting to allocate several hundred MB of memory, since that's what lstat() returns[0] for the symlink's st_size. In actuality, the length of the symlink were mostly under 128 bytes. It s