Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-02-02 Thread Giulio Benetti
Hi Bruno, On 1/27/20 8:29 PM, Bruno Haible wrote: Giulio Benetti wrote: There should not be a in public include file directories! Indeed there is not, there is and it is part of uclibc: https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/libintl.h Ah! Most of the contents of

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-27 Thread Giulio Benetti
Hi Bruno, sorry I'm following too many things in parallel and I've made a mess on explaining! On 1/27/20 6:38 PM, Bruno Haible wrote: Giulio Benetti wrote: Since you reported a redefinition warning regarding 'gettext_noop', gettext_noop must have been defined as a mac

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-27 Thread Giulio Benetti
Hi Bruno, On 1/27/20 2:41 AM, Bruno Haible wrote: Giulio Benetti wrote: In my specific case I'm adding package libbytesize [1], where they add src/gettext.h But libbytesize uses gettext.h as they should: They use the file internally, without installing it in public locations upon

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Giulio Benetti
On 1/26/20 11:47 PM, Giulio Benetti wrote: Hi Bruno, On 1/26/20 11:12 PM, Bruno Haible wrote: Hi Giulio, Building on an environment where gettext is already present leads to emitting a warning about gettext_noop() alread defined. Where is the first definition of gettext_noop located? In

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Giulio Benetti
think? Here I've opened a pull request: https://github.com/storaged-project/libbytesize/pull/64 The goal is to add libbytesize to Buildroot. [1]: https://github.com/storaged-project/libbytesize [2]: https://github.com/storaged-project/libbytesize/blob/master/configure.ac#L21 -- Giulio Benet

[PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Giulio Benetti
Building on an environment where gettext is already present leads to emitting a warning about gettext_noop() alread defined. And if -Werror is passed this warning will be treated like an error, so let's #undef gettext_noop() before #define it. Signed-off-by: Giulio Benetti --- lib/gettext.