Re: Small typo result in build error with MSVC

2025-06-05 Thread Eric Blake
On Thu, Jun 05, 2025 at 08:40:21AM -0700, Paul Eggert wrote: > On 2025-06-05 06:21, Eric Blake wrote: > > Adding gnulib > > Bruno fixed that MSVC-related bug in Gnulib three weeks ago: > > https://cgit.git.savannah.gnu.org/cgit/gnulib.git/commit/?id=f7810929b1d35f1edcc

Re: Small typo result in build error with MSVC

2025-06-05 Thread Eric Blake
et of config.log that shows why configure was unable to use your installed library? Is it something you can work around by priming appropriate cache variables during the configure run? > > Please let me know if you are interested in result of `make check`. Did it pass, or did you see particular failures? -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: \{n\} are not recognized as repetition counter in regular expressions.

2025-05-22 Thread Eric Blake
On Thu, May 22, 2025 at 12:30:37PM -0700, Paul Eggert wrote: > On 2025-05-22 10:42, Eric Blake wrote: > > BSD has tried hard to make their m4 be a drop-in replacement > > enough that autoconf will use it instead of mandating GNU m4 > > Is this a real problem, though? I j

Re: \{n\} are not recognized as repetition counter in regular expressions.

2025-05-22 Thread Eric Blake
On Mon, Apr 07, 2025 at 01:37:10PM -0500, Eric Blake wrote: > On Mon, Apr 07, 2025 at 12:46:11PM -0500, Eric Blake wrote: > > And relying on a configure-time test of what m4 supports on the > > packager's machine is not necessarily going to work when autoconf is > > ru

Re: Stack overflow check does not work with qemu linux-user emulation

2025-05-15 Thread Eric Blake
the qemu-x86_64 emulator, instead of attaching gdb to the emulated execution of src/m4? It could very well be a bug in qemu's user-mode emulation not handling stack overflow in the same way a native program would do. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH] regex: Add \A and \z synonyms to \` and \'

2025-05-01 Thread Eric Blake
On Sat, Apr 26, 2025 at 10:54:19AM -0700, Paul Eggert wrote: > On 2025-04-24 09:13, Eric Blake wrote: > > > case '\'': > > +case 'z': > > Python uses \Z for this and Python's \A ... \Z is cleaner and easier to > remember than

[PATCH] regex: Add \A and \z synonyms to \` and \'

2025-04-24 Thread Eric Blake
glibc already has support for \` and \' as absolute input boundaries, while ^ and $ are a bit more flexible (depending on RE_CONTEXT_INDEP_ANCHORS). Worse, ^ and $ are not portable across all regex flavors - there are languages where they match at any newline within the larger input, and where bli

Re: new snapshot available: m4-1.4.19.65-bdd9.tar.xz

2025-04-19 Thread Eric Blake
rom all the above for me is the build > failure (because of the tests) for i386 on a system with a > recent glibc. I'd love to see a snapshot fixing that before > the final release. > > Thanks a lot. Thank you for the speedy testing and feedback. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: fedora 42 doesn't have awk: how to deal with autoconf subst?

2025-04-18 Thread Eric Blake
t is no longer reasonable to assume that awk is available on every bare-bones distro, and so we either need to tweak autoconf to avoid awk (hard) or to at least alert the user that their environment is too bare-bones, and they need to adjust their CI setup to install just a bit more. -- Eric Blake, Prin

Re: fedora 42 doesn't have awk: how to deal with autoconf subst?

2025-04-17 Thread Eric Blake
es that the configure script will rely on, rather than assuming that the distro has provided them out-of-the-box. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH] Update RE_SYNTAX_EMACS to include features used by GNU Emacs

2025-04-16 Thread Eric Blake
On Wed, Apr 16, 2025 at 05:45:46PM +0200, Bruno Haible wrote: > Eric Blake wrote: > > If you want a quicker table, I can attempt to provide one (note that > > POSIX BRE do not actually have to support \+ \? or \|; but glibc and > > gnulib's implementation does): > &g

Re: [PATCH] Update RE_SYNTAX_EMACS to include features used by GNU Emacs

2025-04-16 Thread Eric Blake
ve to support \+ \? or \|; but glibc and gnulib's implementation does): feature 0-or-more 1-or-more 1-or-0 grouping/alternation intervals charclasses syntax 0 (old emacs) * +? \( \| \)n/a n/a emacs * +? \( \| \) \{ \}[[:...:]] posix-basic * \+ \? \( \| \) \{ \}[[:...:]] posix-extended* +?( | ){ }[[:...:]] -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH] Update RE_SYNTAX_EMACS to include features used by GNU Emacs

2025-04-15 Thread Eric Blake
ALS), corresponding to > + Emacs 21 (2001) and later, because Gnulib's lib/regex.h > + is always used and has this value. */ Or are we really guaranteed that even when we use gnulib's regex module, we are using gnulib's regex.h but can still use the unreplaced glibc implementations? -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: m4-1.4.19.60-6ebfc: some core dumps

2025-04-14 Thread Eric Blake
not a core dump remains as a side effect. But it does seem a bit odd that only some systems are penalized by the higher disk usage due to the core files after a stack overflow. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: new snapshot available: m4-1.4.19.60-6ebfc.tar.xz

2025-04-14 Thread Eric Blake
the date the manual is built. Also, I see two uses of @value{UPDATED} in m4.texi, but your patch only removed one; is the other one not an issue? $ git grep UPDATED ChangeLog-2014: * doc/m4.texinfo: UPDATED refers to the day the manual was built, doc/m4.texi:This manual (@value{UPDATED}) is for GNU M4 (version doc/m4.texi:@subtitle Edition @value{EDITION}, @value{UPDATED} -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: m4-1.4.19.60-6ebfc: some core dumps

2025-04-14 Thread Eric Blake
the bright side, the fact that you got to the tests/ directory means that the tests in checks/ succeeded, so the just-built M4 passes even if we have uncovered some corner cases in the underlying gnulib functions. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH] Update RE_SYNTAX_EMACS to include features used by GNU Emacs

2025-04-11 Thread Eric Blake
ical order, and the definitions shifted by one from the previous bit; thus, when we add or remove a bit, only one other definition need change. */ -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: \{n\} are not recognized as repetition counter in regular expressions.

2025-04-07 Thread Eric Blake
On Mon, Apr 07, 2025 at 10:51:26AM -0400, Zack Weinberg wrote: > On Fri, Apr 4, 2025, at 3:56 PM, Eric Blake wrote: > … > > tl;dr: if I do add intervals to m4 regex, would you rather it be \{\} > > (BRE and emacs style) or {} (ERE style)? And how to avoid breaking >

Re: \{n\} are not recognized as repetition counter in regular expressions.

2025-04-07 Thread Eric Blake
On Mon, Apr 07, 2025 at 12:46:11PM -0500, Eric Blake wrote: > And relying on a configure-time test of what m4 supports on the > packager's machine is not necessarily going to work when autoconf is > run on a developer's machine with a different version of m4. Which in > t

localename question

2025-04-06 Thread Eric Blake
Why does modules/localename have a Link: line of @INTL_MACOSX_LIBS@ instead of $(INTL_MACOSX_LIBS)? This fails 'make syntax-check' for any project using maintainer-makefile and Automake, since that check prefers to let automake auto-populate any $(FOO) from its underlying @FOO@. --

[PATCH] gnulib-tool.py: Fix missing space.

2025-04-05 Thread Eric Blake
this. ChangeLog| 5 + pygnulib/main.py | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6d7435f491..076065290f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2025-04-05 Eric Blake + + gnulib-tool.py: Fix missing

Re: \{n\} are not recognized as repetition counter in regular expressions.

2025-04-04 Thread Eric Blake
avoid breaking existing m4 scripts? On Fri, Apr 04, 2025 at 08:47:20AM -0500, Eric Blake wrote: > On Fri, Nov 04, 2022 at 04:25:45AM +0300, Van de Bugger wrote: > > M4 documentation for regular expressions is extremely short: > > https://www.gnu.org/software/m4/manual/html_node/Reg

rpl_gettimeofday link error under clang on Fedora

2025-04-04 Thread Eric Blake
ETTIMEOFDAY@ REPLACE_GETTIMEOFDAY = @REPLACE_GETTIMEOFDAY@ Makefile: GL_M4_GNULIB_GETTIMEOFDAY = IN_M4_GNULIB_TESTS HAVE_GETTIMEOFDAY = 1 REPLACE_GETTIMEOFDAY = 0 Is this a case of a missing LDFLAGS in m4's tests/Makefile.am (which right now only includes gnulib.mk) or top-level Makefile.am?

Re: [PATCH] maint: typo fixes

2025-04-04 Thread Eric Blake
which a > 'trap' command can guarantee). I hadn't even thought of that angle, but it makes sense. > > So, feel free to put in any other neutral word in place of "phoey". Done with "template". -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: [PATCH] maint: typo fixes

2025-04-04 Thread Eric Blake
On Fri, Apr 04, 2025 at 09:24:35AM -0500, Eric Blake via M4-patches wrote: > * ChangeLog-2014: Address findings from codespell. I made this patch in response to an offline email from a contributor who asked to remain anonymous (I find that odd in the world of open source, but whatever), who a

Re: rpl_gettimeofday link error under clang on Fedora

2025-04-04 Thread Eric Blake
On Fri, Apr 04, 2025 at 03:33:34PM +0200, Bruno Haible wrote: > Hi Eric, > > Eric Blake wrote: > > While trying to build m4.git with clang on a Fedora 40 machine, and > > with gnulib updated to the latest git commit, I'm hitting the > > following during '

Re: bug#76876: logname output is often wrong when linked with glibc

2025-03-19 Thread Eric Blake
oth glibc and the new code in gnulib. > > Let me document this limitation. > > -This function returns the value of the @env{LOGNAME} environment variable: > +This function returns the value of the @env{LOGNAME} environment variable > +and this therefore arbitrarily fakeable: s/

Re: doc: Mention a gmtime_r problem

2024-09-03 Thread Eric Blake
implementation-defined string set to "UTC" or "GMT", which shall | have static storage duration. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: should asprintf and friends guarantee sane pointer on failure?

2024-07-29 Thread Eric Blake
f potentially uninitialized variables (and which treats asprintf() as if it leaves ptr unchanged on failure) is probably sufficient to avoid bugs even if we do not follow any glibc decision on whether to start enforcing behavior (b). On the other hand, if glibc DOES decide to do (b) to match BSD, then why would gnulib NOT want to guarantee the same portably across all platforms? -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

should asprintf and friends guarantee sane pointer on failure?

2024-07-29 Thread Eric Blake
ed (what glibc used to do, but POSIX doesn't guarantee it and it requires more boilerplate to check correctly so more programs are likely to get it wrong, including the oss-security post about getting it wrong turning into a security bug). -- Eric Blake, Principal Software Engineer Red

Re: continuous integrations pipeline frameworks

2024-07-24 Thread Eric Blake
e than 2 years old) - it seems like gnulib has (so far) tried to maintain a much longer window of portability and targets machines older than what libvirt-ci is willing to cater to. But even if you can't use it directly, it may give you some inspiration on writing your own tool. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: Integer overflows in memchr

2024-07-11 Thread Eric Blake
e string but within the size limit is not forbidden, and thereby risks a crash if size is large enough to cross memory boundaries when coupled with an implementation that does not behave as-if it reads linearly) -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: Integer overflows in memchr

2024-07-09 Thread Eric Blake
On Wed, Jul 10, 2024 at 01:55:51AM GMT, Paul Eggert wrote: > On 7/9/24 22:03, Eric Blake wrote: > > https://www.austingroupbugs.net/view.php?id=1834#c6830 > > > > The current draft of proposed wording would have the C standard state: > > > > 2 The strnle

Re: Integer overflows in memchr

2024-07-09 Thread Eric Blake
rst NUL byte, they are not required to do so, at which point you CAN trigger a crash for accessing beyond the bounds of your actual string. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: questions following upcoming POSIX issue 8 release - iconv

2024-06-13 Thread Eric Blake
On Wed, Jun 12, 2024 at 02:36:00AM GMT, Bruno Haible wrote: > Eric Blake wrote: > > - https://austingroupbugs.net/view.php?id=1635 > > I added a couple of comments there, to explain the problem. > It is irritating to see that the Austin Group in defect 1007 apparently >

Re: test-framework-sh: Fix 'returns_' to not turn off tracing permanently

2024-06-12 Thread Eric Blake
mp;1` 'local' is a bashism, but I can already see that tests/init.sh has gone to lengths to require that local exists and has "sane" semantics (by excluding dash semantics). But as long as we're relying on Bash semantics, why not use the simpler: local -; set -x which wi

Re: questions following upcoming POSIX issue 8 release

2024-06-11 Thread Eric Blake
On Mon, Jun 10, 2024 at 11:35:11AM GMT, Collin Funk wrote: > Eric Blake writes: > > > wants to change requirements for isatty() and friends to be required > > to set errno on failure (right now, there is no obvious way to tell, > > using only the standard, if a failure

questions following upcoming POSIX issue 8 release

2024-06-10 Thread Eric Blake
s and/or relax the wording of command line tools like cp to better describe how they fare in the face of the divergent behavior in underlying syscalls? -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: tzname, daylight, timezone: Update documentation

2024-06-06 Thread Eric Blake
based TZ settings (standardized in the soon-to-be-released POSIX Issue 8): https://austingroupbugs.net/view.php?id=1816 -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: nan: Relicense under LGPLv2+

2024-04-18 Thread Eric Blake
ke to use it under LGPLv2+, for the modules 'setpayload*' > and 'getpayloadl' (functions defined by ISO C 23 and implemented in glibc). > > Can I have your agreement to relicensing your contributions to this > module under LGPLv2+, please? > > * Eric Blak

Re: gnulib-tool.py: Fix some unbound variables.

2024-04-09 Thread Eric Blake
n > pointers... It does, since callable objects exist as first class citizens. For example: >>> def foo(): ... print("in foo") ... >>> def bar(): ... print("in bar") ... >>> dispatch = { "foo":foo, "bar":bar } >>> d

Re: autoreconf --force seemingly does not forcibly update everything

2024-04-01 Thread Eric Blake
is that the use of serial numbers in .m4 snippets was intentional in gnulib (more or less where the practice originated), but only because gnulib prefers a linear history (everything is monotonically increasing, no forks for the serial number to diverge on). In light of this weekend's mess, Br

Re: Copyright year update

2024-01-05 Thread Eric Blake
INE_LENGTH=72 > export UPDATE_COPYRIGHT_MAX_LINE_LENGTH > > +# This assignment to 'ight' is is so that data can contain strings duplicate 'is' > +# like "Copy$ight 2024 Free Software Foundation, Inc." without being > +# mistakenly updated by &quo

Re: ./lib/error.h:410:8: warning: ISO C forbids braced-groups within expressions [-Wpedantic]

2023-09-04 Thread Eric Blake
e compiler that even when it is in pedantic mode, we are intentionally using extensions to the language. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: M4 assembler error on compile

2023-08-17 Thread Eric Blake
ib wanted the file in the first place, without adversely affecting the behavior of the compiled m4 binary. > > Any assistance is appreciated. > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org

Re: remaining tasks before Autoconf release

2023-04-19 Thread Eric Blake
widening the type @code{time_t} as needed to represent file > -wand other timestamps after January 2038. This widening is possible > +wand other timestamps after mid-January 2038. This widening is possible s/wand/and/ ? -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: new modules *printf-gnu

2023-03-24 Thread Eric Blake
On Fri, Mar 24, 2023 at 12:37:42PM +0100, Bruno Haible wrote: > Eric Blake wrote in > <https://lists.gnu.org/archive/html/bug-gnulib/2023-03/msg00060.html>: > > C23 admits that %#B is not available for > > portable use of outputting uppercase '0B...', you wou

Re: *printf-posix: ISO C 23: Add %b directive for binary output of integers

2023-03-18 Thread Eric Blake
Another consideration: C23 admits that %#B is not available for portable use of outputting uppercase '0B...', you would have to manually write 0B%b instead. However, since glibc DOES support %B as the uppercase counterpart to %b, should we add that in gnulib (but this time under the ausp

Re: strtol, strtoll, strtoul, strtoull: Make ISO C 23 compliant

2023-03-17 Thread Eric Blake
ot;It is not proposed for the strto* family of functions from the C Standard Library to support digit separators at this time" -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: execute tests: Avoid test failure on Android

2023-01-17 Thread Eric Blake
ugs/index.php?63307 and being fixed in 4.4.1, but it sounds like we'll have lots of systems in the wild with 4.4, and thus lots of these workarounds having to be applied elsewhere. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: Failing test: "test-posix_spawn-script". Race condition?

2022-12-21 Thread Eric Blake
the report; I'm looping in bug-gnulib as the owners of the test in question. It's the first time I've heard of this issue, but I also know that m4 needs a new release with a newer pull from gnulib, so the issue may have been addressed in the meantime in gnulib. -- Eric Blake, Principa

Re: Numbered signals for shell trap cause z/OS grief

2022-11-29 Thread Eric Blake
as a synonym for 'kill -s INT', but does not require it of non-XSI systems. Are there still systems in current use today where 'kill -s NAME' is not supported? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: removing permissions for long unused accounts, take 2

2022-07-13 Thread Eric Blake
a fairly short period of > time. The list would be shortened with the following names if we used > two years: > > Daiki Ueno > Dmitry V. Levin > Eric Blake > Siddhesh Poyarekar > > So not radically different actually. It would be bad if this excercise

Re: regex module has dropped support for syntax tables

2022-05-11 Thread Eric Blake
tation for the different regex flavors for switching flavors on the fly), but current m4 does not use it. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: m4 1.4.19 with musl libc 1.2.3 fails test-posix_spawn_file_actions_addclose

2022-04-11 Thread Eric Blake
assumes behavior that is not mandatory in POSIX, so > technically, the test is wrong. > > -nc > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: Make check - test-vasprintf-posix failure - darwin12 - macos

2022-03-28 Thread Eric Blake
o, but no chance > of making it working. > > The only solution I found is by commenting the three last tests > about Pseudo-Denormal directly in tests/test-vasprintf-posix.c > > Thanks a lot -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: [PATCH] sigsegv: Fix build on ppc/musl

2022-03-10 Thread Eric Blake
> ucp)->uc_mcontext.uc_regs->gregs[1] > +# define SIGSEGV_FAULT_STACKPOINTER ((ucontext_t *) > ucp)->uc_mcontext.uc_regs->gregs[1] > # endif > # endif > > -- > 2.35.1 > > > ___ > M4-patches mailing list > m4-patc...@gnu.org > https://lists.gnu.org/mailman/listinfo/m4-patches -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: Assertion error when building in Debug mode with MSVC

2022-01-25 Thread Eric Blake
to begin with. > > Could you help please? > > Thank you for your time and contributions! > Best, > Julien > -- > Julien Marrec, EBCP, BPI MFBA > Owner at EffiBEM <http://www.effibem.com> > T: +33 6 95 14 42 13 > > LinkedIn (en <https://www.linkedin.com/in

Re: close() behavior when there are multiple fds for a socket

2021-10-15 Thread Eric Blake
if > you belong to an organization that is a member, so I filled those in with "?" > and am hoping for the best. That's fine. Adding page numbers after the fact is something that happens rather frequently; and I've done in for your bug in particular just now. -- Eric Bla

Re: m4-1.4.19 not C99 clean ?

2021-09-13 Thread Eric Blake
cursive] Error 1 > gmake[1]: Leaving directory '/opt/bw/build/m4-1.4.19_sunos5.10_sparcv9.001' > gmake: *** [Makefile:1974: all] Error 2 > > Where we see the asm usage that sort of says "not C99 here". > > However std9899:2011 seems to be just fine. > >

Re: request for minor change to canonicalize-lgpl.c

2021-08-06 Thread Eric Blake
he identifier __stat for our own uses now that we know system headers are using it. Once it is fixed there, I need to do another m4 release anyways (1.4.19 has a bug with unintended locale sensitivity when it comes to parsing numbers), so eventually when I get the time, the 1.4.20 release wil

[PATCH] sigsegv, sigsegv-tests: Assign my contributions to the FSF.

2021-06-21 Thread Eric Blake
Following Bruno's lead, I'm also happy with this change. * m4/sigaltstack.m4: Change copyright notice: Write "Copyright (C) FSF" instead of "Copyright (C) Eric Blake". * tests/altstack-util.h: Likewise. * tests/test-sigsegv-catch-stackoverflow1.c: Likewi

Re: Seeking input from developers: glibc copyright assignment policy.

2021-06-15 Thread Eric Blake
yer, for work I was doing in my spare time, and being able to use the DCO instead would have made my efforts easier at that time. (My current employer already has a blanket copyright assignment on file for all employees, but not everyone has a company that willing to promote open source involveme

Re: warnings in unit tests

2021-06-11 Thread Eric Blake
; @echo '## > ##'" > + echo " @echo '## --- Gnulib tests --- > ##'" > + echo " @echo '## Please report test failures to . > ##'" Is it worth the longer line for "test failures in this directory"? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: gnulib-tool: Stop doing license notice replacements

2021-06-04 Thread Eric Blake
> +under other licenses, such as LGPLv2+, unlimited, or public domain. Would read better as "A few modules are..." -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: put appropriate license notices in source files

2021-06-04 Thread Eric Blake
tools? https://spdx.github.io/spdx-spec/appendix-V-using-SPDX-short-identifiers-in-source-files/ However, for clarity, I think it is wrong to rely on SPDX tag only in place of the full license text; adding the one-liner SPDX should be just that, an additional line. -- Eric Blake, Principal

Re: [sr #110502] 1.4.19: test suite is failing

2021-06-01 Thread Eric Blake
failed to tell us which operating system. The fix will need to be in gnulib's unit tests, so I'm adding bug-gnulib in the distribution. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: [m4-1.4.19] make error on Solaris 11.3 x86

2021-05-29 Thread Eric Blake
FYI: > /usr/include/sys/procfs.h: > 41  #if !defined(_LP64) && _FILE_OFFSET_BITS == 64 > 42  #error  "Cannot use procfs in the large file compilation environment" > 43  #endif > > > Regards, > > --- Kiyoshi > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: warnings from MacOS clang

2021-05-27 Thread Eric Blake
the variable. > This is ugly BSD style of the 1980ies, which we have abandoned > more than 10 years ago. Yet another portable solution is: static mbstate_t s1; mbstate_t s = s1; also with its own form of ugliness. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: test suite failure caused by check-copyright script

2021-05-26 Thread Eric Blake
lways say "GPL", but the real license > specification is in the module description file." ? Yes, that's fine with me. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org

Re: maint.mk suggestion for gnupload

2021-05-10 Thread Eric Blake
On 5/8/21 6:34 AM, Eric Blake wrote: > but it would be a lot nicer if I didn't have to remember to do that > after the fact. In fact, reading gnupload --help says it is as simple > as calling: > > $ gnupload --to ... --symlink-regex ... > > in the first place.

maint.mk suggestion for gnupload

2021-05-08 Thread Eric Blake
n the suggested gnupload instructions it generates? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: [PATCH 1/8] safe-alloc: improve doc

2021-04-22 Thread Eric Blake
On 4/22/21 1:20 PM, Eric Blake wrote: > On 4/18/21 11:01 PM, Paul Eggert wrote: >> * doc/safe-alloc.texi: Clarify that reallocating an array appends >> uninitialized storage. Say ‘sizeof *p’ rather than ‘sizeof(*p)’ >> which would need a space before the paren to follow GNU

Re: [PATCH 1/8] safe-alloc: improve doc

2021-04-22 Thread Eric Blake
On 4/22/21 2:32 PM, Paul Eggert wrote: > On 4/22/21 11:20 AM, Eric Blake wrote: > >> Looks like the definition of macro  __attribute_nonnull__ from cdefs.h >> is no longer implicitly picked up by the system headers used in that >> file. > > I installed the att

Re: [PATCH 1/8] safe-alloc: improve doc

2021-04-22 Thread Eric Blake
oken 195 | __attribute_nonnull__ ((1)) |^ Looks like the definition of macro __attribute_nonnull__ from cdefs.h is no longer implicitly picked up by the system headers used in that file. I'm still poking around to see if I can fix it, but you're welcome t

Re: fatal-signal: Relicense under LGPLv2+

2021-03-22 Thread Eric Blake
ide from my contributions and a few mechanical changes (not copyrightable), > there is this patch from Eric Blake: > https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4b2f21b36a615728ebf2a0e1bc2c8def175703a8 > > Eric, would you please give me the permission to use this cha

mingw strtol bug

2021-03-17 Thread Eric Blake
ally test on a Windows machine) fails to properly consume '0' when parsing in base 16 or 0 when there are no hex digits after a trailing garbage of 'x' or 'X'. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: SIGSTKSZ is now a run-time variable

2021-03-09 Thread Eric Blake
icitly_ asking for non-POSIX extensions by setting _GNU_SOURCE; but since most gnulib projects (including m4) indeed request _GNU_SOURCE, we can no longer rely on the POSIX definition. > >> Please advise how I can get past this. > > Fix your . We're going to need to fix gn

Re: [PATCH] config.sub: fix i*86-pc-os2-emx is not recognized as a valid OS

2020-10-09 Thread Eric Blake
You'll first want to get this upstream at config-patc...@gnu.org -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

Re: autoconf-2.69c released [beta]

2020-09-30 Thread Eric Blake
ear the same (both in generated comments and in what the second-built autoconf will produce). Ideas on streamlining that are welcome, but as we at least have a documented procedure (even if it is multi-step), it's not essential to fix before 2.70. -- Eric Blake, Principal Software Engineer

Re: Who's the upstream owner of GNUmakefile?

2020-08-04 Thread Eric Blake
On 8/4/20 10:07 AM, Eric Blake wrote: On 8/4/20 9:58 AM, Zack Weinberg wrote: I just pushed a commit that partially reverts a `make fetch'. Partially revert e54e3f90: restore use of $(MAKE) in error message. In commit 14d58bfd, the error message printed by the ‘abort-due-

Re: Who's the upstream owner of GNUmakefile?

2020-08-04 Thread Eric Blake
hat's what 'make fetch' is intended to do. So, if you want a change to stick in that file, update the gnulib version first, then update autoconf to the newer version of gnulib containing that fix. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226

Re: relicense module 'group-member'

2020-05-21 Thread Eric Blake
(for portability to many platforms). Yes, the looser license for my contributions makes sense. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: portability of fopen and 'e' (O_CLOEXEC) flag

2020-05-11 Thread Eric Blake
OEXEC, and then fdopen()? In the meantime, this is indeed more portable. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: restrict - summary

2020-02-24 Thread Eric Blake
//pubs.opengroup.org/onlinepubs/9699919799/functions/posix_spawn.html Bug reported to the POSIX folks: https://www.austingroupbugs.net/view.php?id=1328 -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

date -d '...' should support superset of POSIX 'at' dates

2020-01-20 Thread Eric Blake
grammar, so that we can parse everything 'at' is required to support, and in case POSIX does decide to standardize -d using the 'at' grammar as a starting point. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

Re: Test failure in GNU M4 1.4.18 with musl libc

2019-09-11 Thread Eric Blake
> > FAIL: test-mbrtowc5.sh > == > > test-mbrtowc.c:106: assertion 'wc == c' failed > ./test-mbrtowc5.sh: line 4: 789048 Aborted (core dumped) > LC_ALL=C ./test-mbrtowc${EXEEXT} 5 > FAIL test-mbrtowc5.sh (exit status: 134) &g

Re: [libvirt] Fwd: libvirtd failing on MacOS in setgroups

2019-08-30 Thread Eric Blake
> Related samba ticket (it also has references to the python and dovecot > issues): > https://bugzilla.samba.org/show_bug.cgi?id=8773 I wonder if gnulib could provide a workaround setgroups() that overcomes this issue (it's better to maintain such a patch there, where it benefits multiple programs, rather than just in libvirt). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] accept4: Support SOCK_NONBLOCK, if defined

2019-08-20 Thread Eric Blake
On 8/20/19 2:29 PM, Bruno Haible wrote: > Eric Blake wrote: >> +#if SOCK_CLOEXEC >> + if (flags & SOCK_NONBLOCK) > > Why '#if SOCK_CLOEXEC'? > Why not '#if SOCK_NONBLOCK'? Because I made a typo. Thanks for spotting it; will fix shortly. -- Eric

Re: [PATCH] accept4: Support SOCK_NONBLOCK, if defined

2019-08-20 Thread Eric Blake
On 8/20/19 11:37 AM, Eric Blake wrote: > Ideally, we would improve our replacement to define a > replacement SOCK_NONBLOCK on all platforms, and teach socket() to > honor it as well; but that's a bigger task. In the meantime, if the > platform already has SOCK_NONBLOCK, we sho

[PATCH] accept4: Support SOCK_NONBLOCK, if defined

2019-08-20 Thread Eric Blake
): If SOCK_NONBLOCK is defined, honor it. --- ChangeLog | 3 +++ lib/accept4.c | 21 - 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6253f9221..f5eda2fa3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2019-08-20 Eric

Re: accept4 and SOCK_NONBLOCK

2019-08-20 Thread Eric Blake
gt; configure:25630: checking whether accept4 is declared > configure:25630: gcc -c -O2 -g -pipe -Wall -Werror=format-security > -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions > -fstack-protector-strong -grecord-gcc-switches > -specs=/usr/lib/rpm/redhat/redhat-ha

Re: [PATCH] configmake: Avoid namespace pollution issue on mingw.

2019-08-10 Thread Eric Blake
. */ > can be removed from the module description. Will do. > > If no, we should add this instruction also to the documentation file > doc/configmake.texi, so that users don't miss it. If the problem recurs for some other combination of headers, we can address it at that time. -

Re: [PATCH] configmake: Avoid namespace pollution issue on mingw.

2019-08-08 Thread Eric Blake
On 8/8/19 7:30 AM, Eric Blake wrote: > Mingw includes a header that declares a struct typedef named DATADIR, > pulled in when including ; compilation fails if DATADIR > has already been defined as a macro expanding to a string prior to > that inclusion. Although the configmake modu

[PATCH] configmake: Avoid namespace pollution issue on mingw.

2019-08-08 Thread Eric Blake
sions. 29d802900 getpass: Fix include filename ChangeLog | 6 ++ modules/configmake | 3 +++ 2 files changed, 9 insertions(+) diff --git a/ChangeLog b/ChangeLog index 644330370..35f870abe 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2019-08-08 Eric Blake + + con

[PATCH] configmake: Avoid namespace pollution issue on mingw.

2019-08-08 Thread Eric Blake
+1,9 @@ +2019-08-08 Eric Blake + + configmake: Avoid namespace pollution issue on mingw. + * modules/configmake (Makefile.am): If the project uses + , include that header before defining DATADIR. + 2019-07-28 Bruno Haible mbrtowc tests: Fix regression on mingw (reg

Re: mingw pollution of DATADIR vs. configmake.h [was: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML]

2019-07-29 Thread Eric Blake
[dropping libvirt list for now...] On 7/29/19 11:25 AM, Eric Blake wrote: > [adding bug-gnulib] > > On 7/24/19 12:55 AM, Eric Blake wrote: >> Add a new file checkpoint_conf.c that performs the translation to and >> from new XML describing a checkpoint. The code shares a comm

mingw pollution of DATADIR vs. configmake.h [was: [libvirt] [PATCH v10 08/19] backup: Parse and output checkpoint XML]

2019-07-29 Thread Eric Blake
[adding bug-gnulib] On 7/24/19 12:55 AM, Eric Blake wrote: > Add a new file checkpoint_conf.c that performs the translation to and > from new XML describing a checkpoint. The code shares a common base > class with snapshots, since a checkpoint similarly represents the > domain state

Re: Alpine: useless-if-before-free: Exec format error

2019-06-14 Thread Eric Blake
://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_01 "The shell reads its input from a file (see sh), from the -c option or from the system() and popen() functions defined in the System Interfaces volume of POSIX.1-2017. If the first line of a file of shell comm

Re: Why does close_stdout close stdout and stderr?

2019-04-29 Thread Eric Blake
y through close(). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature

  1   2   3   4   5   6   7   8   9   10   >