Re: creates incorrect iconv() prototype

2013-03-10 Thread Andy Wingo
Hi Paul, Thanks for looking at this. On Sun 10 Mar 2013 07:42, Paul Eggert writes: > The iconv build procedure prefers to use 'char **', > but it uses 'const char **' if it detects that it's > on a platform where the 'const' is needed. Evidently > that part of the detection isn't working. Can

getlogin and mingw

2013-03-09 Thread Andy Wingo
Hi, I am using the getlogin module. My mingw cross-compile detects the presence of getlogin, but it seems that one has to actually define _POSIX to get the declaration. However if I define _POSIX before including anything else, I get this error: CC posix.lo In file included from

creates incorrect iconv() prototype

2013-03-09 Thread Andy Wingo
Hi, When cross-compiling Guile to mingw32, I get the following warning: ../../libguile/print.c: In function 'display_string_using_iconv': ../../libguile/print.c:914:7: warning: passing argument 2 of 'rpl_iconv' from incompatible pointer type [enabled by default] In file included from ../../libgu

Re: full_read depends on incoming errno

2013-02-21 Thread Andy Wingo
On Thu 21 Feb 2013 17:29, Paolo Bonzini writes: > Il 20/02/2013 20:58, Andy Wingo ha scritto: >> >> if (full_read (fd, cookie, sizeof cookie) != sizeof cookie >> || full_read (fd, SCM_BYTEVECTOR_CONTENTS (bv), >>

Re: full_read depends on incoming errno

2013-02-20 Thread Andy Wingo
On Wed 20 Feb 2013 20:02, Eli Zaretskii writes: > Btw, it might be a good idea to provide some application-level > diagnostics in this specific case, since "No error", which corresponds > to errno = 0, is not very useful. I pushed this: if (full_read (fd, cookie, sizeof cookie) != sizeof co

Re: full_read depends on incoming errno

2013-02-19 Thread Andy Wingo
Hi, On Tue 19 Feb 2013 22:25, Paul Eggert writes: > On 02/19/13 13:15, Eli Zaretskii wrote: >> if (full_read (fd, cookie, sizeof cookie) != sizeof cookie >> || full_read (fd, SCM_BYTEVECTOR_CONTENTS (bv), >>SCM_BYTEVECTOR_LENGTH (bv)) != SCM_BYTEVECTOR_LENGTH (bv)) >

full_read depends on incoming errno

2013-02-19 Thread Andy Wingo
Hi, We use full_read in Guile and just got a bug report that full_read was depending on the incoming errno. Eli Zaretskii proposed that the fix be like this: > +errno = 0; > if (full_read (fd, cookie, sizeof cookie) != sizeof cookie [...] To recall, safe_read (called by full_read) look

Re: add --match argument to git-version-gen

2012-07-10 Thread Andy Wingo
I'd like to remain portable to those. Bummer. OK, fixed. These functions no longer take or print values, they just set the $v variable. > Oh, and your patch added at least one trailing blank. Fixed. Thanks for the review, new patch attached. Andy >From f345ebb35f1510f61cc72f44fd674

compilation failure against installed libuninstring 0.9.1

2012-07-09 Thread Andy Wingo
Hi, Guile updated its Gnulib checkout to v0.0-7509-g98a2286 before releasing. We use the "libunistring" module to check for installed libunistring. However, this revision of Gnulib does not compile against installed libunistring 0.9.1. Users are reporting errors like: In file included from

Re: add --match argument to git-version-gen

2012-07-06 Thread Andy Wingo
... Good suggestion. Attached. >From f93e662664c1eac104e1144bea94d9386ffc8ab5 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Fri, 6 Jul 2012 17:27:37 +0200 Subject: [PATCH] git-version-gen: add --match argument. * build-aux/git-version-gen (Options): Add --match argument. (m

Re: add --match argument to git-version-gen

2012-07-06 Thread Andy Wingo
no --match option). > Do you really want to add the "feature" that git-version-gen now > fails when there is no "v*" tag, whereas before that worked fine? Fixed to only match strictly when --match is passed. I couldn't figure out a way to do it without the gym

Re: add --match argument to git-version-gen

2012-07-06 Thread Andy Wingo
On Fri 06 Jul 2012 15:56, Stefano Lattarini writes: > On 07/06/2012 03:53 PM, Andy Wingo wrote: >> >> @@ -121,6 +126,9 @@ if test -z "$tarball_version_file"; then >> exit 1 >> fi >> >> +echo $match >> > Huh? Forgotten debuggin

add --match argument to git-version-gen

2012-07-06 Thread Andy Wingo
/mailarchive/git/2010/9/21/40071/thread Regards, Andy >From fbe920ed5075c56750b07c87c707c0c8572c7176 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Fri, 6 Jul 2012 15:51:05 +0200 Subject: [PATCH] git-version-gen: add --match argument * build-aux/git-version-gen (Options): Add --match argum

Re: unistring bug

2012-04-01 Thread Andy Wingo
On Sun 01 Apr 2012 13:01, Bruno Haible writes: > This is normal documented behaviour. The function's description at [1] > >uint8_t * u32_to_u8 (const uint32_t *s, size_t n, uint8_t *resultbuf, > size_t *lengthp) > > is preceded by the general conventions explanation [2]: > >Functions ret

unistring bug

2012-04-01 Thread Andy Wingo
Hi, The following program causes a segfault in the unistring that is current in Debian sid: #include #include int main (int argc, char *argv[]) { int floral_leaf = 0x2767; printf ("floral leaf: %s\n", u32_to_u8 (&floral_leaf, 1, 0, 0)); return 0; }

clock_getcpuclockid versus clock-time

2011-06-17 Thread Andy Wingo
23ca314b7c33 Mon Sep 17 00:00:00 2001 From: Andy Wingo Date: Fri, 20 May 2011 18:48:33 +0200 Subject: [PATCH] check for clock_getcpuclockid in gl_CLOCK_TIME * acinclude.m4 (gl_CLOCK_TIME): It could be that clock_gettime is in libc but clock_getcpuclockid is not, so check for that explici

Re: lgpl clock-time module

2011-05-21 Thread Andy Wingo
On Wed 04 May 2011 18:36, Paul Eggert writes: > On 05/04/11 09:34, Andy Wingo wrote: >> Would you all be OK with making "clock-time" to be LGPL? > > Yes, that one's trivial: it actually contains only BSD-like license code > so it could be marked BSD-like if

Re: [PATCH 1/5] [mingw]: Add implementation of canonicalize_file_name.

2011-05-20 Thread Andy Wingo
Hello Jan, On Fri 20 May 2011 15:56, Jan Nieuwenhuizen writes: > Andy Wingo writes: > >> I read the thread and it looked like this patch was close to being >> accepted > > Yes, it looks like that. Heh ;) > My first simplistic patch to just make guile canonicaliz

lgpl clock-time module

2011-05-04 Thread Andy Wingo
Hello, Would you all be OK with making "clock-time" to be LGPL? It doesn't actually include any GPL code, and depends only on "extensions", which is LGPL. Thanks, Andy -- http://wingolog.org/

Re: -Wundef warning in striconveh.h

2011-03-17 Thread Andy Wingo
On Thu 17 Mar 2011 17:15, Paul Eggert writes: > On 03/17/2011 07:46 AM, Andy Wingo wrote: >> Can you consider changing this one header file? It does not sound like >> an issue on which it is fruitful to be stubborn. > > Well, there is a bit of stubbornness on both sides

Re: -Wundef warning in striconveh.h

2011-03-17 Thread Andy Wingo
Hi Eric, On Thu 17 Mar 2011 15:05, Eric Blake writes: > On 03/17/2011 04:20 AM, Andy Wingo wrote: >> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef, >> or something. > > Not a bug in gnulib, > >> >> Building Guile a contributo

-Wundef warning in striconveh.h

2011-03-17 Thread Andy Wingo
Hello, striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef, or something. Building Guile a contributor got this warning: CC libguile_2.0_la-bytevectors.lo In file included from bytevectors.c:41:0: ../lib/striconveh.h:22:5: warning: "HAVE_ICONV" is not defined [-Wundef]

Re: stat-times LGPL

2010-01-17 Thread Andy Wingo
Hi Paul, On Sun 17 Jan 2010 00:38, Paul Eggert writes: > Andy Wingo writes: > >> I'm writing again to ask that stat-times be relicensed as LGPL, so Guile >> can use it. > > Yes, that's fine. Sorry I didn't reply earlier. Thanks! Andy -- http://wingolog.org/

stat-times LGPL

2010-01-12 Thread Andy Wingo
Hello, (Apologies for not threading this right.) I'm writing again to ask that stat-times be relicensed as LGPL, so Guile can use it. stat-times is just a 200-line header relying on services of LGPL modules, and its copyright has been assigned to the FSF. It seems appropriate to me to assume that

stat-time LGPL

2010-01-08 Thread Andy Wingo
Hi, Guile needs some way of dealing with nanosecond timestamps in stat structures. stat-time looks like the right thing but it is GPL. It depends on time and extensions, which are both LGPLv2+. Can stat-time be made lgpl? Thanks, Andy

Re: version-etc not working with autoconf 2.61

2009-11-24 Thread Andy Wingo
On Sun 22 Nov 2009 09:57, Jim Meyering writes: > Thanks for the patch. > How about the following instead? > Then, if some package is defining PACKAGE specially > and expecting that value to be used here, it will still appear. Thanks for the fix. I knew that something wasn't right :) We'll test

version-etc not working with autoconf 2.61

2009-11-21 Thread Andy Wingo
Hello, I just applied this to Guile. Perhaps something like it should go into Gnulib? Cheers, Andy commit 624c5c7c8870baf610785a821e8bb40d41db2051 Author: Andy Wingo Date: Fri Nov 20 17:24:40 2009 +0100 fix version-etc for older autoconf * lib/version-etc.c: Don't refe