On Thu, 2011-01-27 at 11:00 -0700, Eric Blake wrote:
> On 01/27/2011 02:20 AM, Alan Hourihane wrote:
> > Hello,
> >
> > I'm wondering if gnulib is scheduled to provide sendfile compatibility
> > using lseek/read/write ?
>
> Interesting. The compile-time e
Hello,
I'm wondering if gnulib is scheduled to provide sendfile compatibility
using lseek/read/write ?
I know sendfile is a kernel routine, and I'm unsure of whether the file
pointer needs restoration after the operation or not in a user-space
replacement.
Thanks,
Alan.
On Wed, 2009-09-02 at 13:51 +0100, Alan Hourihane wrote:
> On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote:
> > Alan Hourihane ha escrit:
> >
> > > Yes, but I get this
> > >
> > > nm exclude.o | grep towlower
> > >
On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote:
> Alan Hourihane ha escrit:
>
> > Yes, but I get this
> >
> > nm exclude.o | grep towlower
> > U _towlower
> >
> > And my libc doesn't define towlower() either.
>
&
On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote:
> Alan Hourihane ha escrit:
>
> > Yes, but I get this
> >
> > nm exclude.o | grep towlower
> > U _towlower
> >
> > And my libc doesn't define towlower() either.
>
&
On Tue, 2009-09-01 at 13:24 +0300, Sergey Poznyakoff wrote:
> Alan Hourihane ha escrit:
>
> > Yes, but I get this
> >
> > nm exclude.o | grep towlower
> > U _towlower
> >
> > And my libc doesn't define towlower() either.
>
&
On Tue, 2009-09-01 at 13:10 +0300, Sergey Poznyakoff wrote:
> Alan Hourihane ha escrit:
>
> > exclude.c: In function 'string_hasher_ci':
> > exclude.c:167: warning: implicit declaration of function 'towlower'
> > exclude.c:167: warning: incompatible i
On Tue, 2009-09-01 at 12:30 +0300, Sergey Poznyakoff wrote:
> Alan Hourihane ha escrit:
>
> > Not sure this is right, but it works
>
> Surely it is not right. And it does not work, either: it does
> not correctly lower the case of the input string.
>
> Have
On Tue, 2009-09-01 at 12:30 +0300, Sergey Poznyakoff wrote:
> Alan Hourihane ha escrit:
>
> > Not sure this is right, but it works
>
> Surely it is not right. And it does not work, either: it does
> not correctly lower the case of the input string.
>
> Have
On Thu, 2009-08-27 at 15:24 +0100, Alan Hourihane wrote:
> As the subject line says, and I end up with an unresolved symbol.
>
> Not sure what the right definition check to wrap that up in though.
Not sure this is right, but it works
Alan.
diff --git a/lib/exclude.c b/lib/exclud
As the subject line says, and I end up with an unresolved symbol.
Not sure what the right definition check to wrap that up in though.
Thanks,
Alan.
On Sun, 2009-03-01 at 15:00 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > Yes. This does the trick.
>
> Committed.
One last one to the tests...
Alan.
diff --git a/tests/test-ftell.c b/tests/test-ftell.c
index 845d944..71f3ed2 100644
--- a/tests/test-ftell.c
+++ b/tes
On Sun, 2009-03-01 at 13:32 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > > Is anything else among the aforementioned unit tests still failing?
> >
> > Yes. The last problem is fseeko() as mentioned.
>
> The 'if (0)' is not right: it causes the l
On Sun, 2009-03-01 at 13:38 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > In netdb.in.h we have
> >
> > # ifndef EAI_INPROGRESS
> >
> > but in gai_strerror.c we have...
> >
> > #ifdef __USE_GNU
> >
> > Can we be c
On Sun, 2009-03-01 at 11:05 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > Yes. This works too.
>
> OK, I committed it.
>
> Is anything else among the aforementioned unit tests still failing?
Yes. The last problem is fseeko() as mentioned.
Alan.
Hi Bruno,
On another item (mentioned before)
In netdb.in.h we have
# ifndef EAI_INPROGRESS
but in gai_strerror.c we have...
#ifdef __USE_GNU
Can we be consistent here and use
#ifdef EAI_INPROGRESS in gai_strerror.c or modify netdb.h.in to use
__USE_GNU ??
Alan.
Hi Bruno,
So, we still fail the tests with the current git HEAD of today. As I
mentioned yesterday fseeko() still fails.
I have to revert to if (0) for FreeMiNT for this to pass the tests.
Comments ?
Alan.
On Sun, 2009-03-01 at 02:40 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > Attached are the freading.c and fwriting.c patches to make them pass.
>
> Thanks. I've committed it like this:
Thanks, but the #else section is still broken for older mintlibs, and
it's
On Sun, 2009-03-01 at 02:17 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> + fp->__pushback_bufp = 0;
> + if (fp->__mode.__write)
> +fp->__put_limit = fp->__buffer;
> + fp->__bufp = fp->__get_limit;
>
> I don't think the last statement
Hi Bruno,
So I can see the test patches applied in git HEAD.
If I take that code and apply the attached conglomeration patch, then
all the tests pass.
Alan.
diff --git a/lib/fflush.c b/lib/fflush.c
index 3b17655..9f75ccd 100644
--- a/lib/fflush.c
+++ b/lib/fflush.c
@@ -63,12 +63,6 @@ clear_unget
On Sun, 2009-03-01 at 01:34 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > I know. It's a kernel issue that needs dealing with
>
> OK, if you already know it's a kernel issue, it's certainly not a problem
> caused by your proposed ftello / fseek... pa
On Sat, 2009-02-28 at 16:40 -0700, Eric Blake wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> According to Alan Hourihane on 2/28/2009 4:31 PM:
> >> I'll change things around now.
> >
> > The above is a little unfair as FreeMiNT has problems see
On Sat, 2009-02-28 at 22:33 +, Alan Hourihane wrote:
> On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote:
> > Hi Alan,
> >
> > > I see this has already landed in git, so let me know how you want to
> > > handle any updates.
> >
> > Can
On Sun, 2009-03-01 at 00:17 +0100, Bruno Haible wrote:
> Alan,
>
> + fp->__pushback_bufp = 0;
> + if (fp->__mode.__write)
> +fp->__put_limit = fp->__buffer;
> + fp->__bufp = fp->__get_limit;
>
> Can you explain me something? I thought the following invariants should
> always hold:
> fp->
On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote:
> > > --- lib/fflush.c.orig 2009-02-28 21:09:16.0 +0100
> > > +++ lib/fflush.c 2009-02-28 21:01:40.0 +0100
> > > @@ -63,6 +63,12 @@
> > > }
> > > # elif defined _IOERR /* AIX, HP-UX, IRIX, OSF/1, Solaris
On Sat, 2009-02-28 at 22:51 +0100, Bruno Haible wrote:
> Alan,
>
> > Just getting back to the fseeko() test. What exactly is meant to be
> > tested here ?
>
> This conditional means to test whether the last call was an fflush(), i.e.
> whether no I/O was done on the stream since the last fflush()
Hi Bruno,
Attached are the freading.c and fwriting.c patches to make them pass.
Alan.
diff --git a/lib/fwriting.c b/lib/fwriting.c
index b7fa455..ba05e65 100644
--- a/lib/fwriting.c
+++ b/lib/fwriting.c
@@ -41,10 +41,9 @@ fwriting (FILE *fp)
return ((fp->_Mode & 0x1 /* _MOPENR */) == 0
||
Hi Bruno,
Patch to fix fpurge.c.
fpurge test now passes.
Alan.
diff --git a/lib/fpurge.c b/lib/fpurge.c
index 0e2931e..d54e80f 100644
--- a/lib/fpurge.c
+++ b/lib/fpurge.c
@@ -115,14 +115,10 @@ fpurge (FILE *fp)
fp->_Rend = fp->_Next;
return 0;
# elif defined __MINT__ /* Ata
On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote:
> Hi Alan,
>
> > I see this has already landed in git, so let me know how you want to
> > handle any updates.
>
> Can you please take the current gnulib (git HEAD), execute the tests in
> the way I mentioned, show us the test failures (with l
Hi Bruno,
Just getting back to the fseeko() test. What exactly is meant to be
tested here ?
Can you explain as I don't quite understand why this is needed.
> > --- lib/fseeko.c.orig 2009-02-28 21:09:16.0 +0100
> > +++ lib/fseeko.c2009-02-28 20:58:14.0 +0100
> > @@ -82,6
se.
> * lib/freadable.c (freadable): Likewise.
> * lib/freading.c (freading): Likewise.
> * lib/freadptr.c (freadptr): Likewise.
> * lib/freadseek.c (freadptrinc): Likewise.
> * lib/fseeko.c (rpl_fseeko): Likewise.
> * lib/fseterr.c (fse
On Sat, 2009-02-28 at 17:29 +0100, Jim Meyering wrote:
> Alan Hourihane wrote:
> > <http://savannah.gnu.org/patch/?6758>
> > Summary: Add support for Atari FreeMiNT OS
> > Project: GNU Core Utilities
>
> Thanks for the work. I
On Sat, 2009-01-17 at 13:55 +, Alan Hourihane wrote:
> On Sat, 2009-01-17 at 13:50 +0000, Alan Hourihane wrote:
> > On Thu, 2009-01-15 at 21:47 +0100, Bruno Haible wrote:
> > > Hello,
> > >
> > > Alan Hourihane wrote:
> > > > On platforms that
On Sat, 2009-01-17 at 13:50 +, Alan Hourihane wrote:
> On Thu, 2009-01-15 at 21:47 +0100, Bruno Haible wrote:
> > Hello,
> >
> > Alan Hourihane wrote:
> > > On platforms that don't have them yet, and because gnulib doesn't
> > > support them
On Thu, 2009-01-15 at 21:47 +0100, Bruno Haible wrote:
> Hello,
>
> Alan Hourihane wrote:
> > On platforms that don't have them yet, and because gnulib doesn't
> > support them (or use them currently) we need to change line 53 in
> > gai_strerror.c from
>
Bruno,
On platforms that don't have them yet, and because gnulib doesn't
support them (or use them currently) we need to change line 53 in
gai_strerror.c from
#ifdef __USE_GNU
to just...
#if 0
Which allows gllib to build on platforms that don't have the extra
definitions.
Alan.
On Mon, 2008-12-22 at 12:45 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > The only commitment I'm asking from gnulib is to apply patches that we
> > submit. They'll be #ifdef __MINT__ anyway, isn't that acceptable ??
>
> A patch with #ifdef __MINT
On Mon, 2008-12-22 at 12:41 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > > Did you try to run the complete gnulib unit tests?
> > > $ ./gnulib-tool --test --with-tests
> >
> > I have run individual tests, but I can run the whole suite.
>
> In
On Mon, 2008-12-22 at 11:48 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > > > I have more patches to gnulib for MINT. Shall I just file them as bugs ?
> > >
> > > It depends how serious MINT as a platform is. What is MINT at all? Why
> > > does
On Mon, 2008-12-22 at 10:49 +0100, Bruno Haible wrote:
> Alan Hourihane wrote:
> > I have more patches to gnulib for MINT. Shall I just file them as bugs ?
>
> It depends how serious MINT as a platform is. What is MINT at all? Why does
> it lack basic functions like mbrtowc, st
On Mon, 2008-12-22 at 03:55 +0100, Bruno Haible wrote:
> Hello Sergey, Alan,
>
> On 2008-10-30 I wrote:
> > I'll therefore extend the modules in a way that they work also on older
> > systems without HAVE_MBRTOWC.
>
> This is done. When you do a "gnulib-tool --update" from texinfo, you should
> g
Attached is an updated patch to gnulib because of a linking problem
related to mbrinit and mbrtowc that was exposed when building texinfo
4.13.
Alan.
diff -u gnulib/lib/mbiter.h gnulib/lib/mbiter.h
--- gnulib/lib/mbiter.h 2008-05-12 12:38:21.0 +
+++ gnulib/lib/mbiter.h 2008-11-19 21:13
On Thu, 2008-10-30 at 09:07 +, Alan Hourihane wrote:
> On Thu, 2008-10-30 at 10:12 +0200, Sergey Poznyakoff wrote:
> > Karl Berry <[EMAIL PROTECTED]> ha escrit:
> >
> > > Anyway, if Sergey doesn't have time to look at it, I will eventually.
> > &
On Thu, 2008-10-30 at 10:12 +0200, Sergey Poznyakoff wrote:
> Karl Berry <[EMAIL PROTECTED]> ha escrit:
>
> > Anyway, if Sergey doesn't have time to look at it, I will eventually.
> > Meanwhile, patches are welcome of course :).
>
> It is a bug in gnulib. I have forwarded it to .
Attached is a p
44 matches
Mail list logo
