Re: qcopy-acl: Fix copying of ACLs on CentOS 7

2025-05-12 Thread Pádraig Brady
On 12/05/2025 18:11, Paul Eggert wrote: On 2025-05-12 05:43, Ondrej Valousek wrote: I think they intentionally removed the system.nfs4* in Fedora-42 because commands like "cp -a" complained when copying files. Yes, the removal in 2019 was due to a suggestion[1] by Pádraig, which Kamil Dudka w

Re: qcopy-acl: Fix copying of ACLs on CentOS 7

2025-05-12 Thread Paul Eggert
On 2025-05-12 05:24, Bruno Haible wrote: Hi Pádraig, I checked one centos 7 system, and it didn't have a /etc/xattr.conf file which might explain the behavior noticed above. Then on centos 8 we have: system.nfs4_acl permissions system.nfs4acl permissions system.

Re: qcopy-acl: Fix copying of ACLs on CentOS 7

2025-05-12 Thread Paul Eggert
On 2025-05-12 05:43, Ondrej Valousek wrote: I think they intentionally removed the system.nfs4* in Fedora-42 because commands like "cp -a" complained when copying files. Yes, the removal in 2019 was due to a suggestion[1] by Pádraig, which Kamil Dudka was a bit dubious about[2] but went ahead

RE: qcopy-acl: Fix copying of ACLs on CentOS 7

2025-05-12 Thread Ondrej Valousek
Hello, I think they intentionally removed the system.nfs4* in Fedora-42 because commands like "cp -a" complained when copying files. It complained because usually people copy from NFSv4 volume to a non-NFSv4 volume which is normal (expected) behaviour as we can't copy nfsv4 acls to non nfsv4 vo

Re: qcopy-acl: Fix copying of ACLs on CentOS 7

2025-05-12 Thread Bruno Haible via Gnulib discussion list
Hi Pádraig, > > 2024-07-15 Bruno Haible > > > > qcopy-acl: Fix copying of ACLs on CentOS 7 (regression 2023-01-12). > > * lib/qcopy-acl.c: Include , . > > (XATTR_NAME_NFSV4_ACL, XATTR_NAME_POSIX_ACL_ACCESS, > > XATTR_NAME_POSIX_ACL_DEFAULT): New macros, from file-has-acl.c. > >

doc: Update doc about ACLs on Cygwin.

2025-05-12 Thread Bruno Haible via Gnulib discussion list
2025-05-12 Bruno Haible doc: Update doc about ACLs on Cygwin. * doc/acl-resources.txt: Update function list for Cygwin >= 2.5. diff --git a/doc/acl-resources.txt b/doc/acl-resources.txt index da66e69b60..7b3ae5078e 100644 --- a/doc/acl-resources.txt +++ b/doc/acl-resources.txt

Re: [PATCH] qcopy-acl: port better to NFSv4 on GNU/Linux

2025-05-12 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > (acl_get_fdfile): New function, if needed. This patch leads to a compilation error on Solaris. Found by the CI on Solaris 11.4: ../../gllib/file-has-acl.c: In function ‘acl_get_fdfile’: ../../gllib/file-has-acl.c:413:45: error: ‘acl_get_file’ undeclared (first use in this fu

Re: [PATCH 2/2] obstack: avoid undefined pointer comparison

2025-05-12 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote on 2025-05-07: > * lib/obstack.in.h (_OBSTACK_CPTR): New macro. > (obstack_free): Use it instead of comparing pointers directly, > when the pointers might not point into the same object. Thanks. That is an important fix, now that compilers start to turn invalid pointer arithmetic

doc: Update for a few recently fixed Hurd bugs

2025-05-12 Thread Bruno Haible via Gnulib discussion list
A few Hurd bugs were fixed recently. (Thanks Collin for having reported them!) We can update the doc accordingly. 2025-05-12 Bruno Haible doc: Update for a few recently fixed Hurd bugs. * doc/posix-functions/utimensat.texi: List the affected glibc versions. * doc/posix

Re: qcopy-acl: Fix copying of ACLs on CentOS 7

2025-05-12 Thread Pádraig Brady
On 15/07/2024 13:59, Bruno Haible wrote: The CI of GNU sed shows a test failure of the Gnulib 'acl' tests on CentOS 7 [1]. Namely: FAIL: test-copy-acl.sh FAIL: test-copy-acl-1.sh FAIL: test-copy-acl-2.sh It can be reproduced like this: $ echo 'Simple contents' > tmpfile0 $ echo

Re: fts: Fix redefinition of __THROW.

2025-05-12 Thread Bruno Haible via Gnulib discussion list
Collin Funk wrote: > > What I propose is to have fts.in.h being preprocessed into fts_.h. > > So that > > - we follow the naming scheme *.in.h of other header files in gnulib, > > - packages like coreutils and findutils are not broken. > > Sure. I pushed the attached patch to do that. Thanks!