Re: z/OS access

2025-05-07 Thread Bruno Haible via Gnulib discussion list
Hi Collin, > This reminds me. I recently found out IBM allows you to request access > to z/OS to "Develop and test open source on z/OS" or "Set up an open > source CI/CD pipeline on z/OS" [1]. There's also a similar option to request access to Linux/s390x hardware [4]. > I have no clue who uses

Re: [PATCH 1/2] obstack: check def before use in macros

2025-05-07 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > > Does Solaris cc of > > version 0x5150 or newer really support statement-expressions? > > Yes it does[1]. Thanks for reporting the ChangeLog mistake; I installed > the attached. > > [1]: https://docs.oracle.com/cd/E77782_01/html/E77792/gqexw.html#OSGCCgqexp Thanks!

Re: [PATCH 1/2] obstack: check def before use in macros

2025-05-07 Thread Paul Eggert
On 2025-05-07 14:31, Bruno Haible wrote: -#if defined __GNUC__ || defined __clang__ -# if ! (2 < __GNUC__ + (8 <= __GNUC_MINOR__) || defined __clang__ \ -|| 0x5150 <= __SUNPRO_C) +#if (defined __GNUC__ || defined __clang__ \ + || (defined __SUNPRO_C && 0x5150 <= __SUNPRO_C)) +# if def

z/OS access

2025-05-07 Thread Collin Funk
Hi Bruno, Bruno Haible via Gnulib discussion list writes: > + __ZOS__\ > + __zOS__\ This reminds me. I recently found out IBM allows you to request access to z/OS to "Develop and test open source on z/OS" or "Set up an open source CI/CD pipeline on z/OS" [1]. I would n

Re: code formatting

2025-05-07 Thread Bruno Haible via Gnulib discussion list
Collin Funk wrote: > If we were to force code formatting conventions I would rather use > something comprehensive like clang-format. But I dislike that idea > anyways because unless every contributor uses the same version (very > unlikely), it leads to useless diff chunks due to formatter > disagre

Re: Remove obsolete syntax-check rules

2025-05-07 Thread Collin Funk
Hi Bruno, Bruno Haible via Gnulib discussion list writes: > Apparently the gnulib indentation conventions, even of the modules owned > by Jim and Eric, have deviated from the cppi conventions. You and Paul agreed to remove the .cppi-disable file last year [1] [2]. Since no one else objected the

Re: stddef-h: Fix __GNUC_MINOR__ typo.

2025-05-07 Thread Collin Funk
Bruno Haible writes: > We had similar mistakes with __clang_major__ already. Sounds like > a general syntax-check rule would help. Thanks! Your commits proved this syntax-check was a good idea. Collin

Re: [PATCH 1/2] obstack: check def before use in macros

2025-05-07 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > Simplify the logic for __extension__. > ... > @@ -329,9 +331,9 @@ extern int obstack_exit_failure; > > #define obstack_memory_used(h) _obstack_memory_used (h) > > -#if defined __GNUC__ || defined __clang__ > -# if ! (2 < __GNUC__ + (8 <= __GNUC_MINOR__) || defined __clang_

[PATCH] Omit a parenthesis pair again (fixing inadvertent revert)

2025-05-07 Thread Paul Eggert
--- lib/obstack.in.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/obstack.in.h b/lib/obstack.in.h index 4b133c32cc..698b6b37a7 100644 --- a/lib/obstack.in.h +++ b/lib/obstack.in.h @@ -593,7 +593,7 @@ extern int obstack_exit_failure; (((_OBSTACK_CPTR) (h)->chunk < (OB

[PATCH 1/2] obstack: check def before use in macros

2025-05-07 Thread Paul Eggert
* lib/obstack.in.h (__attribute_noreturn__, __extension__): Be more careful about checking whether a macro is defined before using it, as some compilers complain otherwise. Simplify the logic for __extension__. --- ChangeLog| 8 lib/obstack.in.h | 16 +--- 2 files cha

[PATCH 2/2] obstack: avoid undefined pointer comparison

2025-05-07 Thread Paul Eggert
* lib/obstack.in.h (_OBSTACK_CPTR): New macro. (obstack_free): Use it instead of comparing pointers directly, when the pointers might not point into the same object. --- ChangeLog| 5 + lib/obstack.in.h | 17 ++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --

Add/fix some license notices

2025-05-07 Thread Bruno Haible via Gnulib discussion list
Running "make sc_check_copyright" produces this table: Module LicenseFile License File name = = = GPL LGPLv2+ lib/hash-triple.h LGPL LGPLv3+ or GPLv2+ lib/str-kmp.h LGPLv2+ ?

Add syntax-check rule against misspelled predefs

2025-05-07 Thread Bruno Haible via Gnulib discussion list
To catch typos in predefined C macros, here are three patches. 2025-05-07 Bruno Haible Add syntax-check rule against CPU predef misspellings. * lib/getloadavg.c: Test __alpha, not __alpha__. * tests/test-snan-2.c: Likewise. * m4/exponentd.m4: Test __arm__, not

Remove obsolete syntax-check rules

2025-05-07 Thread Bruno Haible via Gnulib discussion list
These three syntax-check rules fail: $ make sc_maint make -s srcdir=. gnulib_dir=. _build-aux=build-aux \ -f cfg.mk -f maint.mk syntax-check make[1]: *** No rule to make target 'syntax-check'. Stop. make: *** [Makefile:79: sc_maint] Error 2 Seeing that cfg.mk has not been changed in 9 y

Fix "make sc_check_config_h_reminder" failure

2025-05-07 Thread Bruno Haible via Gnulib discussion list
After updating the list of _GL_ATTRIBUTE* macros in the Makefile, these failures are seen: File lib/areadlink.h lacks a config.h reminder. Needed for: _GL_ATTRIBUTE_DEALLOC_FREE File lib/crc.h lacks a config.h reminder. Needed for: _GL_ATTRIBUTE_PURE File lib/crc-x86_64.h lacks a config.h reminde

Fix "make sc_prohibit_leading_TABs" failures

2025-05-07 Thread Bruno Haible via Gnulib discussion list
Some of the existing syntax-check rules have apparently not been exercised in a long time. This patch fixes one of them. 2025-05-07 Bruno Haible Fix "make sc_prohibit_leading_TABs" failures. * Makefile (exclude_file_name_regexp--sc_prohibit_leading_TABs): New variable.

Tidy "make sc_prohibit_AC_LIBOBJ_in_m4" check

2025-05-07 Thread Bruno Haible via Gnulib discussion list
This patch refactors one of the syntax-check rules. 2025-05-07 Bruno Haible Tidy "make sc_prohibit_AC_LIBOBJ_in_m4" check. * Makefile (sc_prohibit_AC_LIBOBJ_in_m4): Don't hide the rule commands. (allow_AC_LIBOBJ): Remove exceptions that are no longer needed. diff --gi

[PATCH] obstack: omit a parenthesis pair

2025-05-07 Thread Paul Eggert
* lib/obstack.in.h (obstack_free) [!__GNUC__]: Omit an unnecessary pair of parentheses that are also omitted in glibc. --- lib/obstack.in.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/obstack.in.h b/lib/obstack.in.h index 174cab9d0a..e361dc67ac 100644 --- a/lib/obstack.

Fix "make sc_prohibit_sc_omitted_at" failure

2025-05-07 Thread Bruno Haible via Gnulib discussion list
It's better to show the Makefile commands being executed, than to hide them. Transparency rules. 2025-05-07 Bruno Haible Fix "make sc_prohibit_sc_omitted_at" failure. * Makefile (sc_prohibit_sc_omitted_at): Don't apply to this Makefile. (sc_*): Don't hide the rule comm

Fix "make sc_prefer_ac_check_funcs_once" failure

2025-05-07 Thread Bruno Haible via Gnulib discussion list
2025-05-07 Bruno Haible Fix "make sc_prefer_ac_check_funcs_once" failure. * Makefile (exclude_file_name_regexp--sc_prefer_ac_check_funcs_once): New variable. (sc_prefer_ac_check_funcs_once): Use it. diff --git a/Makefile b/Makefile index 5fcc02510a..06ecc5d7c1 1