Hi Collin,
> I would like to sync glibc's obstack.h with Gnulib's obstack.in.h in
> order to fix the undefined behavior sanitizer
> nullptr-with-nonzero-offset errors that were fixed in Gnulib, but not in
> glibc [1].
When doing such syncs back to glibc, please sync selected patches. Don't
just c
Hi Bruno,
I would like to sync glibc's obstack.h with Gnulib's obstack.in.h in
order to fix the undefined behavior sanitizer
nullptr-with-nonzero-offset errors that were fixed in Gnulib, but not in
glibc [1].
Upon copying the file to make necessary manual changes, I noticed that
the glibc's file
On 2025-04-28 02:53, Bruno Haible wrote:
This change was not needed, because the use of AS_CASE or AS_IF w.r.t.
AC_REQUIRE is not needed inside AC_DEFUNs [1].
Ah, I didn't know that. Thanks for letting me know. No harm done by the
patch, I hope.
On 2025-04-28 03:46, Bruno Haible wrote:
But the indentation in your patch is terrible:
I did that to minimize the size of the diff output for that patch. It's
of course fine to fix the indentation, as you did later.
On 28/04/2025 18:13, Bruno Haible wrote:
Sevan Janiyan wrote:
Just as a heads up, the issue is not exclusive to 10.4 on PowerPC. The
issue is that on 10.4, period. I hit the same issue on 10.4 on Intel.
Then we might need a similar patch for lib/sigsegv.c lines 663 and 671 ?
I'll take a look
Sevan Janiyan wrote:
> Just as a heads up, the issue is not exclusive to 10.4 on PowerPC. The
> issue is that on 10.4, period. I hit the same issue on 10.4 on Intel.
Then we might need a similar patch for lib/sigsegv.c lines 663 and 671 ?
> It seems that the kernel just lacks the functionality.
Hi Bruno,
On 28/04/2025 17:07, Bruno Haible wrote:
Thanks for the effort. Actually, I committed a patch from Evan Miller
that should fix the issue, without complicated MacOS X version deliberations:
https://gitweb.git.savannah.gnu.org/gitweb/?
p=gnulib.git;a=commitdiff;h=cdddbed4e8745a1130cd395
Hi.
Sevan Janiyan wrote on 2023-11-14:
> > If so, can you change your patch so that
> >1) it is symmetric w.r.t. to MIN and MAX,
> > and/or
> >2) it at least compiles for a range that includes both 10.4 and 10.5,
> > and ideally works on 10.5? I think that would be the best behaviour
Hi Evan,
Sorry for the long delay.
> Attached is a proposed patch to fix the compilation issue, designed by
> comparing the 10.4 and 10.5 SDKs. It relies on an implementation detail, but
> I think it's safe to say that the PowerPC headers are frozen at this point.
Looks good. I've verified that
Paul Eggert wrote:
> +AS_CASE([$gl_threads_api@$gl_use_threads@$gl_have_isoc_threads],
Three-dimensional pattern matching is more powerful than a sequence
of one-dimensional 'test' statements. But it's harder to understand.
Therefore, if we don't need it, I prefer the logically simpler one-
di
Paul Eggert wrote:
> * m4/threadlib.m4: Refactor by prefering AS_CASE to case
I've nothing against the use of AS_CASE. In the editor that I use,
I also like to have parentheses matching up properly :)
But the indentation in your patch is terrible:
1) In some cases, the cases don't appear on a
Paul Eggert wrote:
> * m4/threadlib.m4: When conditionally invoking a macro that uses
> or might use AC_REQUIRE, put it inside AS_CASE or AS_IF instead
> of using shell constructs directly.
This change was not needed, because the use of AS_CASE or AS_IF w.r.t.
AC_REQUIRE is not needed inside AC_DE
Hi Paul,
Paul Eggert wrote:
> Remove -Wdisabled-optimization, as this is a warning about the
> compiler not the program.
Does gcc's warning message give a hint how the compiler options could
be adjusted, so as to enable the optimization?
I'm asking because sometimes (e.g. in the Emacs display en
Collin Funk wrote:
> only one failure for test-nonblocking-socket.sh. But I assume that this
> is not an actual bug since we intentionally disable this test in CI. Is
> it just the guess for SOCKET_DATA_BLOCK_SIZE's definition doesn't match
> the real kernel buffer size?
It depends on the messages
14 matches
Mail list logo
