Re: localeconv tests: Add multithread-safety test

2025-04-12 Thread Paul Eggert
On 2025-04-12 14:01, Bruno Haible wrote: Paul Eggert wrote: To me it means that if two threads simultanously call localeconv and any other function (including setlocale and uselocale!), localeconv might have a data race. You mean, "localeconv will *not* have a data race" ? Yes, sorry; that's

Re: vasnprintf tests: Add a test case that showcases a Solaris bug

2025-04-12 Thread Collin Funk
Bruno Haible via Gnulib discussion list writes: > In printf implementations, it is easy to miss the fact that for %.50g > the implementation needs to allocate room for the thousands-separators. > I checked various systems, and Solaris printf() was found to crash in > such circumstances. Good cat

Re: immutable: Avoid redefining macros on AIX.

2025-04-12 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > Yes, since we don't have a CI build for AIX, we need to occasionally check > it manually. Yep, that is what I was doing. All the tests that I have run so far seem to pass fine, excluding year-2038 since the cfarm machine is 32-bits and many skipped locale tests.

vasnprintf tests: Add a test case that showcases a Solaris bug

2025-04-12 Thread Bruno Haible via Gnulib discussion list
In printf implementations, it is easy to miss the fact that for %.50g the implementation needs to allocate room for the thousands-separators. I checked various systems, and Solaris printf() was found to crash in such circumstances. Anyone with a support contract for Solaris 11.4 - feel free to cre

Re: localeconv tests: Add multithread-safety test

2025-04-12 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > > POSIX [1] says about localeconv(): > >"The localeconv() function need not be thread-safe; however, localeconv() > > shall avoid data races with all other functions." > > > > [1]https://pubs.opengroup.org/onlinepubs/9799919799/functions/localeconv.html > > > > It's n

Re: localeconv tests: Add multithread-safety test

2025-04-12 Thread Paul Eggert
On 4/12/25 00:39, Bruno Haible via Gnulib discussion list wrote: POSIX [1] says about localeconv(): "The localeconv() function need not be thread-safe; however, localeconv() shall avoid data races with all other functions." [1]https://pubs.opengroup.org/onlinepubs/9799919799/functions/loc

Re: immutable: Avoid redefining macros on AIX.

2025-04-12 Thread Bruno Haible via Gnulib discussion list
Hi Collin, > On AIX in a testdir of all modules Yes, since we don't have a CI build for AIX, we need to occasionally check it manually. > I have pushed the attach two patches fixing this, and a similar one in > the aligned-malloc tests. Thanks. Just for nitpicking: > +# ifdef ALIGNMENT > +# u

stdlib: Avoid syntax errors in libstdc++ header files on AIX.

2025-04-12 Thread Collin Funk
On AIX in a testdir of all modules, using './configure --disable-year2038 && make' I see the following failure: depbase=`echo test-nullptr-c++.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ g++ -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -I. -I.. -DGNULIB_STRICT_CHECKING=1 -DIN_GNULIB_TESTS=1 -

immutable: Avoid redefining macros on AIX.

2025-04-12 Thread Collin Funk
On AIX in a testdir of all modules, using './configure --disable-year2038 && make' with GCC 10.3 I see the following warning: immutable.c:278: warning: "ALIGNMENT" redefined 278 | # define ALIGNMENT sizeof (void *) | In file included from ./sys/socket.h:58,

is*_l, fnmatch tests: Avoid test failures on macOS 15.4

2025-04-12 Thread Bruno Haible via Gnulib discussion list
On GitHub, they upgraded the macOS machines from macOS 15.3 Darwin Mac-1744297320864.local 24.3.0 Darwin Kernel Version 24.3.0: Thu Jan 2 20:16:37 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_VMAPPLE arm64 to Darwin Mac-1744360147416.local 24.4.0 Darwin Kernel Version 24.4.0: Wed Mar 19

Re: vasnprintf: Work around two grouping bugs on many platforms

2025-04-12 Thread Bruno Haible via Gnulib discussion list
> vasnprintf: Work around two grouping bugs on many platforms. The tests fail on native Windows, because MSVC does not support the grouping flag at all, and because mingw uses the decimal point instead of the thousands separator, for integers. See: ===

localeconv tests: Add multithread-safety test

2025-04-12 Thread Bruno Haible via Gnulib discussion list
POSIX [1] says about localeconv(): "The localeconv() function need not be thread-safe; however, localeconv() shall avoid data races with all other functions." [1] https://pubs.opengroup.org/onlinepubs/9799919799/functions/localeconv.html It's not exactly clear to me what this means. What is