Re: [PATCH] nproc, openmp-init: omit unnecessary strtol code

2025-03-19 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > + Remove unnecessary initialization and unnecessary check > + whether endptr == NULL. Thanks. When I added this code on 2009-11-04, I was apparently unsure whether endptr would be set also in the error case, and played it safe. Bruno

Re: bug#76876: logname output is often wrong when linked with glibc

2025-03-19 Thread Eric Blake
On Mon, Mar 10, 2025 at 06:24:45AM +0100, Bruno Haible via GNU coreutils Bug Reports wrote: > I wrote: > > Thus, on Linux systems, a correct implementation of getlogin() can not > > distinguish different users with the same uid (with reasonable effort). > > This applies to both glibc and the new c

Re: mountlist for native Windows

2025-03-19 Thread Collin Funk
Bruno Haible writes: > And with this patch, mount points other than the 26 drives are listed. > For example, I created a separate disk, formatted it as NTFS, mounted > it at S:\, added some files, unmounted it from S:\, and finally > mounted it at C:\Users\bruno\mt_scratch. > > The test program n

Re: bug#76876: logname output is often wrong when linked with glibc

2025-03-19 Thread Bruno Haible via Gnulib discussion list
Eric Blake wrote: > > Let me document this limitation. > > > > > -This function returns the value of the @env{LOGNAME} environment variable: > > +This function returns the value of the @env{LOGNAME} environment variable > > +and this therefore arbitrarily fakeable: > > s/this/thus/ ? Oops, than

Re: mountlist for native Windows

2025-03-19 Thread Bruno Haible via Gnulib discussion list
And with this patch, mount points other than the 26 drives are listed. For example, I created a separate disk, formatted it as NTFS, mounted it at S:\, added some files, unmounted it from S:\, and finally mounted it at C:\Users\bruno\mt_scratch. The test program now reports: ??? C:\ ??? NFTS loca

Re: mountlist for native Windows

2025-03-19 Thread Bruno Haible via Gnulib discussion list
This patch adds support for drive mappings added with SUBST and NET USE. Example: After subst p: C:\Users\Public net use t: \\larid\tmp the test program now prints: ??? C:\ ??? NFTS local ??? P:\ C:\Users\Public NFTS local ??? T:\ \\larid\tmp NTFS remote 2025-03-19 Bruno Haible

Re: mountlist for native Windows

2025-03-19 Thread Bruno Haible via Gnulib discussion list
Collin Funk wrote: > I pushed both attached patches. Thanks! The unit test is perfect. On my Windows VM with just 1 drive, the test produces this output: ??? C:\ ??? NTFS local ??? D:\ ??? ??? local The D:\ line needs to be filtered out. Done through the patch below. 2025-03-19 Bruno Hai

Re: futimens: Work around a GNU/Hurd bug.

2025-03-19 Thread Bruno Haible via Gnulib discussion list
Collin Funk wrote: > Also reported the bug and mentioned it in the docs [2]. Thanks! > Looking at the > code, NetBSD has a similar situation so I documented that too [3]. Indeed, I had apparently forgotten to document this one. Thanks. Bruno

Re: Prefer the __gnu_hurd__ macro over __GNU__.

2025-03-19 Thread Bruno Haible via Gnulib discussion list
Collin Funk wrote: > I have pushed the attached patch to use __gnu_hurd__ everywhere instead. Thanks a lot! Bruno