Re: gnulib --remove-import removes every module except the one to remove

2024-11-12 Thread Bruno Haible via Gnulib discussion list
Hi Gavin, > I wanted to remove "copy-file", but it actually removed every other module. Thanks for the report. I am committing this probable fix (untested). Can you please give it a try? 2024-11-12 Bruno Haible gnulib-tool.py: Fix logic of --remove-import option. Reported by

Re: [PATCH] bootstrap: tune Octave bootstrap --gnulib-refdir

2024-11-12 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > I installed the attach patches, which use "git remote set-url"; good enough? Thanks. Yes, this performs nicely. The 'git remote set-url origin' command "unties" the clone from the specified refdir. But in the case that GNULIB_REVISION is not set, there is still a difference i

Re: fseek and ftell with large files on Windows

2024-11-12 Thread Bruno Haible via Gnulib discussion list
Markus Mützel wrote: > The Octave functions that are being called in the reproducer are named > "fseek" and "ftell". But the gnulib functions that are called internally are > "fseeko" and "ftello". If I understood Paul Eggert in that bug report > correctly, he found at least one place where Octa

Re: [PATCH] bootstrap: tune Octave bootstrap --gnulib-refdir

2024-11-12 Thread Paul Eggert
On 2024-11-12 11:09, Bruno Haible wrote: in order to get the latest 'master', the user would have to first do a 'git pull' in the refdir, and then do a 'git pull' in the subdirectory gnulib/. This is problematic because - This is almost certainly not the intended behaviour.

gnulib --remove-import removes every module except the one to remove

2024-11-12 Thread Gavin Smith
In the Texinfo project, I wanted to try to remove a gnulib module. The command I ran was: ../../../../gnulib/gnulib-tool --remove-import copy-file This is inside a deeply nested directory in the project source code. However, this has the opposite effect to that intended: diff --git a/tp/Texinf

Re: gnulib --remove-import removes every module except the one to remove

2024-11-12 Thread Bruno Haible via Gnulib discussion list
Gavin Smith wrote: > According to the comment in gnulib-tool, sh is supposed to be the > default, but it is actually Python: > ... > # The environment variable GNULIB_TOOL_IMPL can have four possible values: > # - GNULIB_TOOL_IMPL=sh chooses the shell implementation. > # - GNULIB_TOOL_IMPL

Re: [PATCH] bootstrap: tune Octave bootstrap --gnulib-refdir

2024-11-12 Thread Bruno Haible via Gnulib discussion list
Hi Paul, Paul Eggert wrote: > + * top/bootstrap-funclib.sh (prepare_GNULIB_SRCDIR): > + Use GNULIB_REFDIR also when a submodule 'gnulib' is not configured. > + This greatly speeds up bootstrapping Octave when using > + ‘./bootstrap --gnulib-refdir=...’. I see two problems with thi

[PATCH] bootstrap: tune Octave bootstrap --gnulib-refdir

2024-11-12 Thread Paul Eggert
* top/bootstrap-funclib.sh (prepare_GNULIB_SRCDIR): Use GNULIB_REFDIR also when a submodule 'gnulib' is not configured. This greatly speeds up bootstrapping Octave when using ‘./bootstrap --gnulib-refdir=...’. * build-aux/bootstrap: Regenerate. --- ChangeLog| 9 ++ build-aux/b

Re: fseek and ftell with large files on Windows

2024-11-12 Thread Markus Mützel
Am Montag, 11. November 2024 um 19:50 schrieb "Bruno Haible": > Hi, > > Markus Mützel wrote: > > Octave is using gnulib's "fseek" and "ftell" functions. A user reported that they have issues when using these functions with large files on Windows: > > https://savannah.gnu.org/bugs/index.php?66399