Re: savewd: please port to native Windows

2024-08-28 Thread Jeffrey Walton
On Tue, Aug 27, 2024 at 5:25 PM Paul Eggert wrote: > > On 2024-08-27 13:34, Bruno Haible wrote: > > > gllib\savewd.c(73,27): warning: implicit declaration of function 'fork' is > > invalid in C99 [-Wimplicit-function-declaration] > > Perhaps the attached patch? Re: +# if O_SEARCH != O_RDONLY ||

Re: savewd: please port to native Windows

2024-08-28 Thread Bruno Haible
Collin Funk wrote: > Not sure if you are aware but that module is documented as not being > supported on Windows. In gnulib-intro.texi line 164 - 169: > > Note that some modules are currently unsupported on native Windows: > @code{mgetgroups}, @code{getugroups}, @code{idcache}, > @code

Re: savewd: please port to native Windows

2024-08-28 Thread Bruno Haible
Paul Eggert wrote: > > Maybe instead define it as a macro? > > > >#define fork() (assure (false), -1) > > Sure, I installed it that way. Thanks. I confirm that the problem with the reference to fork() is gone. Whether the module actually works on native Windows, I can't tell: There are no un

threads-h: Don't override the C++ keyword 'thread_local'

2024-08-28 Thread Bruno Haible
clang on native Windows produces the warning: In file included from C:\cygwin64\home\bruno\testdir-all-for-msvc\gltests\test-threads-c++.cc:22: ../gllib\threads.h(685,10): warning: keyword is hidden by macro definition [-Wkeyword-macro] The cause is that in C++ 11 or newer, 'thread_local' is a

Re: Include mini-mpq

2024-08-28 Thread Bruno Haible
Hi Marc, Please keep the mailing list in CC. > But I don't agree with the naming of the modules. Since GMP includes > > all three (mpn, mpz, mpq) in one library, the Gnulib module 'libgmp' > > should do the same. This means, the existing libgmp module should be > > renamed to 'libgmp-mpz', and th

Re: Include mini-mpq

2024-08-28 Thread Bruno Haible
Marc Nieper-Wißkirchen wrote: > PS Here is a suggestion for a new `mpq' module. What do you think? Thanks for the suggestion. I agree that it would be useful to import mini-mpq.[hc] into gnulib, from the location that you mentioned. To do that, please augment the file config/srclist.txt, so that

Re: bug#72842: Compile error due to lto warning on Arch Linux -Werror=maybe-uninitialized

2024-08-28 Thread Pádraig Brady
On 27/08/2024 22:34, Paul Eggert wrote: I'm not seeing that false alarm when building coreutils v9.5 on Ubuntu 24.04 LTS with "./configure --enable-gcc-warnings CC=gcc-14". What GCC version are you using? If it's not GCC 14, try upgrading. I'm using gcc-14 (Ubuntu 14-20240412-0ubuntu1) 14.0.1 20

Re: Include mini-mpq

2024-08-28 Thread Marc Nieper-Wißkirchen
PS Here is a suggestion for a new `mpq' module. What do you think? Am Mi., 28. Aug. 2024 um 08:41 Uhr schrieb Marc Nieper-Wißkirchen < marc.nieper+...@gmail.com>: > Hi, > > This is a request to integrate the missing parts of the mini-gmp library > into Gnulib. To be more specific, mini-mpq is c

doc: Add more details about O_EXEC and O_SEARCH

2024-08-28 Thread Bruno Haible
The documentation we have about O_EXEC and O_SEARCH is confusing: "Gnulib defines these macros to @samp{O_RDONLY}, which is typically 0. The @samp{O_PATH} macro of GNU/Linux is not a suitable substitute, as fchmod fails ..." The second sentence is an explanation of an implementation ch