Hi,
This is a request to integrate the missing parts of the mini-gmp library
into Gnulib. To be more specific, mini-mpq is currently missing in Gnulib;
see [1].
Thanks,
Marc
--
[1] https://gmplib.org/repo/gmp/file/tip/mini-gmp
A testdir of
mbscasestr mcel-prefer
when build with MSVC, produces link errors:
libgnu.a(mbscasestr.obj) : error LNK2019: unresolved external symbol
__builtin_expect referenced in function mcel_tocmp
libgnu.a(mbslen.obj) : error LNK2001: unresolved external symbol
__builtin_expect
test-mbscase
Hi Bruno,
Bruno Haible writes:
> It's not clear to me whether this module can still partially work on native
> Windows, with some #if. Or if it is better disabled entirely, by putting
> all the code under
> #if !(defined _WIN32 && !defined __CYGWIN__)
>
> Can someone please take a look?
Not s
Bruno Haible writes:
> I bet that most implementations read this file via open() or fopen(), right?
>
> Then how about adding to the test an open() and an fopen() function that,
> instead of opening /etc/shells, opens a data file in gnulib's tests/
> (or gltests/) directory?
>
> You know that a f
On 2024-08-27 14:31, Bruno Haible wrote:
Maybe instead define it as a macro?
#define fork() (assure (false), -1)
Sure, I installed it that way.
Collin Funk wrote:
> But it is hard to improve the test because it reads /etc/shell.
>
> I can't modify that to check for unexpected/edge cases. :(
I bet that most implementations read this file via open() or fopen(), right?
Then how about adding to the test an open() and an fopen() function tha
Paul Eggert wrote:
> > gllib\savewd.c(73,27): warning: implicit declaration of function 'fork' is
> > invalid in C99 [-Wimplicit-function-declaration]
>
> Perhaps the attached patch?
Thanks, that might well fix it.
Just a worry that a compiler could complain about a missing 'return' statement
i
On 2024-08-27 13:34, Bruno Haible wrote:
gllib\savewd.c(73,27): warning: implicit declaration of function 'fork' is
invalid in C99 [-Wimplicit-function-declaration]
Perhaps the attached patch?From 4e624ff79120231a78b85a2302d037e205c69dd3 Mon Sep 17 00:00:00 2001
From: Paul Eggert
Date: Tue,
Hi Bruno,
Bruno Haible writes:
> clang on native Windows gives me this warning:
>
> gllib\getusershell.c(115,25): warning: expression which evaluates to zero
> treated as a null pointer constant of type 'char *'
> [-Wnon-literal-null-conversion]
>
> This patch fixes it. Collin, please consider
clang on native Windows gives me this warning:
gllib\bcopy.c(27,1): warning: no previous prototype for function 'bcopy'
[-Wmissing-prototypes]
The normal way to fix this would be to add a '#include ' in
lib/bcopy.c. But our does not even provide a declaration of
this function! It relies on AC_R
clang on native Windows produces a warning:
gllib\simple-atomic.c(59,10): warning: incompatible pointer to integer
conversion returning 'void *' from a function with result type 'uintptr_t' (aka
'unsigned long long') [-Wint-conversion]
This patch purports to fix it.
2024-08-27 Bruno Haible
clang on native Windows shows a warning:
gllib\write-any-file.c(44,14): warning: implicit declaration of function
'geteuid' is invalid in C99 [-Wimplicit-function-declaration]
geteuid does not exist on native Windows. Let's do like in tests/test-access.h.
This patch should fix the issue.
2024-
clang on native Windows warns about an undefined function:
gllib\savewd.c(73,27): warning: implicit declaration of function 'fork' is
invalid in C99 [-Wimplicit-function-declaration]
There is no 'fork' function on native Windows.
It's not clear to me whether this module can still partially work
clang on native Windows gives me this warning:
gllib\dirchownmod.c(98,27): warning: implicit declaration of function 'fchown'
is invalid in C99 [-Wimplicit-function-declaration]
This patch should fix it.
2024-08-27 Bruno Haible
mkdir-p: Don't reference an undefined function on nati
On 2024-08-27 04:15, Marc Nieper-Wißkirchen wrote:
However, see the second code block in Example 4 of section 6.7.3.1 (in the
latest draft of C23). This may, of course, be itself an error as the
example is about restrict and not about uninitialized structs.
Yes, that example sheds no light on
clang on native Windows gives me this warning:
gllib\getusershell.c(115,25): warning: expression which evaluates to zero
treated as a null pointer constant of type 'char *'
[-Wnon-literal-null-conversion]
This patch fixes it. Collin, please consider strengthening the unit test.
2024-08-27 Br
clang on native Windows gives me these warnings:
gllib\fts.c(1867,16): warning: cast to smaller integer type 'long' from 'FTSENT
**' (aka 'struct _ftsent **') [-Wpointer-to-int-cast]
gllib\fts.c(1867,37): warning: cast to smaller integer type 'long' from 'void
*' [-Wvoid-pointer-to-int-cast]
Ob
In a testdir of modules
time-h time-h-tests time-h-c++-tests posixcheck
on native Windows, with clang, I see these compilation errors:
C:\cygwin64\home\bruno\testdir3\gltests\test-getcwd.c(77,32): error: too many
arguments to function call, expected single argument '_Path', have 2 arguments
Bruno Haible writes:
> I did:
>> Fix compilation errors with clang that masquerades as gcc 13.
>
> And here is a patch that fixes the clang warnings that appear to be caused
> by this version of __GNUC__.
>
> Previously I did not like the __GNUC_PREREQ (glibc) or _GL_GNUC_PREREQ
> (gnulib)
This patch fixes a clang warning about unreachable code.
2024-08-27 Bruno Haible
windows-spawn: Fix clang warning.
* lib/windows-spawn.c (convert_CreateProcess_error): Remove unreachable
'break;' statements.
diff --git a/lib/windows-spawn.c b/lib/windows-spawn.c
index
> > > Fix compilation errors with clang that masquerades as gcc 13.
> >
> > And here is a patch that fixes the clang warnings that appear to be caused
> > by this version of __GNUC__.
>
> And here is a patch that avoids a test failure.
Other than that, I'm reviewing the other remaining occurre
Eric Gallager wrote:
> Hi, I'm writing about gnulib's documentation for psignal:
> https://www.gnu.org/software/gnulib//manual/html_node/psignal.html
> One thing I'm not seeing mentioned in it is how the first argument can
> sometimes have different types. While POSIX says the first type should
> b
Hi, I'm writing about gnulib's documentation for psignal:
https://www.gnu.org/software/gnulib//manual/html_node/psignal.html
One thing I'm not seeing mentioned in it is how the first argument can
sometimes have different types. While POSIX says the first type should
be int, on my macOS system, it's
Great! Thanks so much for dealing with this so rapidly!
Allison
On Tue, 27 Aug 2024 at 11:49, Bruno Haible wrote:
> Allison Karlitskaya wrote:
> > I can confirm that with this patch, the output of `who` shows Cockpit
> > again. Specifically:
> >
> > admincockpit 2024-08-27 08:21
Am Do., 22. Aug. 2024 um 07:27 Uhr schrieb Paul Eggert :
> On 2024-08-21 06:36, Bruno Haible wrote:
> > In summary, this paragraph makes no sense for structs.
>
> Hmm, well, the paragraph makes sense to me. I suppose somebody could
> fire off a question to the C committee about the intent of the p
Allison Karlitskaya wrote:
> I can confirm that with this patch, the output of `who` shows Cockpit
> again. Specifically:
>
> admincockpit 2024-08-27 08:21 (:::172.27.0.2)
Thanks, that's perfect. I'm committing the patch:
2024-08-27 Bruno Haible
readutmp: In system
hi Bruno,
Thanks for the quick turnaround!
I can confirm that with this patch, the output of `who` shows Cockpit
again. Specifically:
admincockpit 2024-08-27 08:21 (:::172.27.0.2)
Thanks!
Allison
On Mon, 26 Aug 2024 at 23:58, Bruno Haible wrote:
> Hi Allison,
>
> Based on
27 matches
Mail list logo
