sys_un: New module.

Here is the sys_un module as promised + typical C/C++ header checks. I've decided to make only generate if using a Windows version with . Therefore it cannot be included unless HAVE_UNIXSOCKET is set to 1. Feel free to change it if you think another way would work better. Collin >From 861f4cee

Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

On 2024-07-24 14:07, Alejandro Colomar wrote: I forgot to reply to the last part: "Why isn't that [current gnulib] good enough? With an implementation of strtol(3) that does what I wrote above, the test `if (!t_ptr)` isn't true, so we go to `if (*p == nptr && (errno == 0 || errno == EINVAL))`,

Re: Detect UNIX domain sockets supported by recent Windows versions.

Hi Collin, > Perhaps test-sys_un{.c,cc} like usual > and another test program for UNIX socket functionality if or > is found. Yes. > I'm thinking that for older versions of Windows and systems without UNIX > sockets they should all be skipped. > > I don't think there is much point in defining

Re: Detect UNIX domain sockets supported by recent Windows versions.

Hi Bruno, Bruno Haible writes: > And a unit test would be nice as well. You know, it's only through the > unit tests that we discover the portability problems. > > I think such a unit test shouldn't use fork(), like tests/test-passfd.c > does, since fork() doesn't exist on native Windows. But >

Re: Avoid false error close_used_without_requesting_gnulib_module_close

And the same thing for all other *_used_without_requesting_gnulib_module_* symbols. 2024-07-24 Bruno Haible Avoid false select_used_without_requesting_gnulib_module_select. * modules/select (configure.ac): Invoke gl_MODULE_INDICATOR. * lib/sys_select.in.h (select): Don

Avoid false error close_used_without_requesting_gnulib_module_close

A gettext bug report found that GNU gettext, when compiled on mingw with builddir = srcdir, produces a compilation error due to the symbol 'close_used_without_requesting_gnulib_module_close'. What happens, is that: * Under the scope of the same configure.a

Re: continuous integrations pipeline frameworks

Hi Eric, > Have you looked at libvirt-ci[1]? Several projects (among others: > libvirt, qemu, libnbd) use this for templating CI that works across > both gitlab and github (preferring to run CI under gitlab as it is > less invasive of freedoms, but taking advantage of github's access to > MacOS t

Re: continuous integrations pipeline frameworks

On Wed, Jul 24, 2024 at 06:23:06PM GMT, Bruno Haible wrote: > Hi Simon, > > In > you wrote: > > > And while so far I've been satisfied with writing these .yml files manually, > it would be better if they all were generated by

Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

On Wed, Jul 24, 2024 at 10:54:52PM GMT, Alejandro Colomar wrote: > Hi Paul, > > On Wed, Jul 24, 2024 at 01:11:33PM GMT, Paul Eggert wrote: > > On 2024-07-24 12:27, Alejandro Colomar wrote: > > > POSIX leaves the value of *endptr unspecified if the base is invalid; > > > it is not unmodified. > >

Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

Hi Paul, On Wed, Jul 24, 2024 at 01:11:33PM GMT, Paul Eggert wrote: > On 2024-07-24 12:27, Alejandro Colomar wrote: > > POSIX leaves the value of *endptr unspecified if the base is invalid; > > it is not unmodified. > > Fine, we can let xstrtol do the same. > > > That, combined with the fact tha

Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

On 2024-07-24 12:27, Alejandro Colomar wrote: POSIX leaves the value of *endptr unspecified if the base is invalid; it is not unmodified. Fine, we can let xstrtol do the same. That, combined with the fact that POSIX allows implementations of strtol(3) to set EINVAL when no digits are found,

Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

On Wed, Jul 24, 2024 at 09:27:14PM GMT, Alejandro Colomar wrote: > POSIX leaves the value of *endptr unspecified if the base is invalid; > it is not unmodified. > > glibc and musl libc leave the object unmodified. However, the BSDs and > Bionic libc modify it to be nptr. > > That, combined with

[PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

POSIX leaves the value of *endptr unspecified if the base is invalid; it is not unmodified. glibc and musl libc leave the object unmodified. However, the BSDs and Bionic libc modify it to be nptr. That, combined with the fact that POSIX allows implementations of strtol(3) to set EINVAL when no d

Re: xstrtod, xstrtold: proposed change

Paul Eggert wrote: > > I propose to change the gradual underflow behaviour of xstrtod > > Sounds good. The current behavior with MSVC does make more sense. Done: 2024-07-24 Bruno Haible xstrtod, xstrtold: Don't treat gradual underflow as an error. * lib/xstrtod.c (XSTRTOD):

Re: continuous integrations pipeline frameworks

Hi Simon, In you wrote: > >> I forgot to mention: the pattern to provide re-usable GitLab CI/CD > >> definitions that I'm inspired by is Debian's pipeline project: > >> > >> https://salsa.debian.org/salsa-ci-team/pipeline/ > >

Re: Detect UNIX domain sockets supported by recent Windows versions.

Hi Collin, > I'll write a sys_un module to deal with including afunix.h tomorrow. Nice! And a unit test would be nice as well. You know, it's only through the unit tests that we discover the portability problems. I think such a unit test shouldn't use fork(), like tests/test-passfd.c does, sinc