Re: Indentation mistake

2024-05-02 Thread Simon Josefsson via Gnulib discussion list
Collin Funk writes: > Hi Simon, > > On 5/2/24 11:25 AM, Simon Josefsson via Bug reports for the GNU Internet > utilities wrote: >>> Sadly, I cannot do this, at least not easily. After installing GNU >>> indent, "make syntax-check" complains about many files: >>> >>> $ indent --version >>>

gnulib-tool.sh: Fix program name in error message.

2024-05-02 Thread Collin Funk
When running 'gnulib-tool' with the mode --update and extra arguments: $ env GNULIB_TOOL_IMPL=sh gnulib-tool --update --vc-files gnulib-tool: invalid options for 'update' mode Try 'gnulib-tool --help' for more information. If you really want to modify the gnulib configuration of yo

Re: Problem with boot-time on Cygwin

2024-05-02 Thread Bruno Haible
Hi Ken, > $ ls -l /proc/cygdrive/c/pagefile.sys/ > ls: cannot open directory '/proc/cygdrive/c/pagefile.sys/': Not a directory > > $ ls -ld /proc/cygdrive/c/pagefile.sys/ > drwxr-x--- 17664 Unknown+User Unknown+Group 0 1600-12-31 19:11 > /proc/cygdrive/c/pagefile.sys// > > Notice that the file

Re: Problem with boot-time on Cygwin

2024-05-02 Thread Ken Brown
Hi Bruno, Unfortunately, fixing the cygdrive bug has made things worse from the point of view of emacs, at least on my system. Namely, I can't even build emacs. The build produces warnings like the following and ultimately fails: Warning (unlock-file): Unlocking file: Invalid argument, /h

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Collin Funk
On 5/2/24 3:50 PM, Bruno Haible wrote: >> Would the following be correct? >> >> command = ['sh', '-c', f'patch {shlex.quote(test_driver)} < >> {shlex.quote(diff)}'] >> try: >> result = sp.call(command, stdout=sp.DEVNULL, stderr=sp.DEVNULL) >> except OSError as exc: >>

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Bruno Haible
Collin Funk wrote: > Ah, good point. I didn't realize it was possible to use a native > Windows Python3 (os.name == 'nt') with Cygwin tools. It appears that's what the original reporter is doing [1]: you see file names with backslashes and you see Windows error codes being reported, rather than PO

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Collin Funk
On 5/2/24 3:28 PM, Bruno Haible wrote: >> Can I apply the attached patched? > > Yes, now it is OK to push. Done. >> Also, last night when fixing the quoting issue I was thinking if >> gnulib-tool.py should quit on unsupported platforms (native Windows). > > Yes, this is reasonable, since we alr

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Bruno Haible
Hi Collin, > Can I apply the attached patched? Yes, now it is OK to push. > Also, last night when fixing the quoting issue I was thinking if > gnulib-tool.py should quit on unsupported platforms (native Windows). Yes, this is reasonable, since we already determined that our unsupported platform

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Collin Funk
Hi Bruno, On 5/2/24 2:29 AM, Bruno Haible wrote: > I would additionally format it as a subsection, so that it clearly stands > out from the rest: Can I apply the attached patched? Also, last night when fixing the quoting issue I was thinking if gnulib-tool.py should quit on unsupported platforms

Re: Problem with boot-time on Cygwin

2024-05-02 Thread Bruno Haible
Ken Brown wrote: > I don't know anything about Docker containers or jails, but it's my > understanding that /proc/cygdrive always exists. Thanks for the confirmation. Bruno

Re: Problem with boot-time on Cygwin

2024-05-02 Thread Ken Brown
Hi Bruno, On 5/1/2024 6:52 PM, Bruno Haible wrote: I did not know about /proc/cygdrive; thanks for teaching us. I guess it can be assumed that /proc/cygdrive exists, because unlike in Linux, there are no Docker containers and unlike in FreeBSD, there are no jails? I don't know anything about D

doc: Add appendix about Gnulib history

2024-05-02 Thread Bruno Haible
Paul and Jim, feel free to correct this where I'm wrong... 2024-05-02 Bruno Haible doc: Add appendix about Gnulib history. * doc/gnulib-history.texi: New file. * doc/gnulib.texi: Include it. diff --git a/doc/gnulib.texi b/doc/gnulib.texi index aa0eb57f62..55cf6ebcc9 1

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Bruno Haible
Hi Collin, > I read the emails you sent and INSTALL.windows in gettext. How about > this revised version based on that information? > > Since Cygwin is preferred we can just have a single section for that. > Mention explicitly that it is preferred over MSYS2. Pretty good already. > diff --git a

Re: gnulib-tool.py: Don't leave temporary directories on exit.

2024-05-02 Thread Bruno Haible
Hi Collin, > ... It seems like a pain to track > down every code path that can lead to 'sys.exit()' or 'exit()' with a > temporary directory still existing. > ... > Therefore, we can use tempfile.TemporaryDirectory as a context manager > and let Python cleanup for us [1]: > > def main_with_excep

Re: gnulib-tool.py: Quote file names passed to 'patch'.

2024-05-02 Thread Bruno Haible
Collin Funk wrote: > I noticed that the file names when running 'patch' on test-driver > weren't quoted. I guess that would cause problems in practice if you > used spaces in directories Indeed. Thanks for fixing that! > Since we assume POSIX shells we can just use shlex.quote() to deal > with an

gnulib-tool.py: Don't leave temporary directories on exit.

2024-05-02 Thread Collin Funk
It looks like gnulib-tool.py never cleaned up temporary directories for modes other than the --import, --create-testdir, and related. Since the --extract-* functions seem less used, hopefully this hasn't caused too much spam yet. In gnulib-tool-tests: $ rm -rf /tmp/glpy* $ ./test-all.sh