[PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 49.

2024-03-08 Thread Collin Funk
On 3/8/24 9:47 PM, Collin Funk wrote: > These lines are fixed by this patch on my updated GNU/Linux machine. I > saw another TODO item referencing a separate patch needed for > test-driver distributed with a specific version of Automake. I'll get > around that one in a bit, but I figured I'd mentio

[PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 48.

2024-03-08 Thread Collin Funk
Here is a patch removing one more item from gnulib-tool.py.TODO. Here is a test and diff before applying this patch: gnulib-tool.py --create-testdir --dir test-python dummy gnulib-tool --create-testdir --dir test-shell dummy git diff --no-index test-python test-shell diff --git a/test-python/buil

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 47.

2024-03-08 Thread Collin Funk
On 3/8/24 4:02 AM, Bruno Haible wrote: > Thanks for mentioning this; I did not know about this property of 'import *' > statements. I didn't know about the import property until recently either. I always knew of the naming convention though. I don't think we use 'import *' anywhere and I tend to a

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 47.

2024-03-08 Thread Bruno Haible
Hi Collin, > Here is a patch that implements the '%reldir%' replacements when > generating GNU Make output instead of Automake. It seems fairly > straightforward unless I missed something. Thanks. I applied both patches. > Side note, I would like to start making the code _slightly_ more > readab

[PATCH] gnulib-tool: Don't remove comments referencing @NMD@.

2024-03-08 Thread Collin Funk
Hi Bruno, Thanks for double checking the @NMD@ thing for me. Here it is with a ChangeLog entry. CollinFrom ace1c35cc1aa535396e606499e44c0bc1847b340 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Fri, 8 Mar 2024 02:28:11 -0800 Subject: [PATCH 2/2] gnulib-tool: Don't remove comments referencing

[PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 47.

2024-03-08 Thread Collin Funk
Here is a patch that implements the '%reldir%' replacements when generating GNU Make output instead of Automake. It seems fairly straightforward unless I missed something. Side note, I would like to start making the code _slightly_ more readable as more features get implemented. Reducing code dupl

Re: Question about 'gen-header' module and friends.

2024-03-08 Thread Bruno Haible
Hi Collin, > > Should > > the sed invocations [1] be changed to only replace lines if they start > > with @NMD@ instead of all lines that contain @NMD@? Let's see where this occurs: $ grep -r NMD@ modules | grep -v :@ modules/posix-shell:#@NMD@ $(AM_V_GEN)$(MKDIR_P) '%reldir%' modules/gen-h