[PATCH] gnulib-tool.py: Adjust construction of configure.ac path.

2024-03-03 Thread Collin Funk
When using gnulib-tool.py this comment in gnulib-comp.m4 is different (using Emacs merge-gnulib): -# This macro should be invoked from ./configure.ac, in the section +# This macro should be invoked from configure.ac, in the section In gnulib-tool the $configure_ac is set to [1]: configure_ac=

Re: --create-testdir speed

2024-03-03 Thread Tim Rice
On Sun, 3 Mar 2024, Bruno Haible wrote: > +@example > +gnulib-tool --create-megatestdir --with-tests --dir=... autobuild MODULES > +@end example > + > +@noindent > +(You can't do this will all of Gnulib at once: @code{gnulib-tool} would run I assume the brain wanted to t

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Collin Funk
On 3/3/24 4:30 AM, Pádraig Brady wrote: > Right, join without options is essentially set intersection. > See https://www.pixelbeat.org/cmdline.html#sets Thanks for the examples. Bookmarked it since it will probably come handy as I work on gnulib-tool. :) Collin

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Collin Funk
On 3/3/24 4:30 AM, Bruno Haible wrote: > In the original commit, I removed the error message > "option --conditional-dependencies is not supported with --with-tests" > only at one place (the command-line option checks), but left it in > func_import. > You are removing it in both places (mode == 'i

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Bruno Haible
Hello Collin, > -for m in $modules; do echo $m; done | LC_ALL=C sort -u > "$tmp"/modules > +for m in $referenceable_modules; do echo $m; done | LC_ALL=C sort -u > > "$tmp"/modules > > Which I didn't understand until seeing this line [1]: > > deps=`for m in $deps; do echo $m; done | LC_A

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Pádraig Brady
On 03/03/2024 05:33, Collin Funk wrote: On 3/2/24 7:02 PM, Collin Funk wrote: When working on the one of the TODO entries I noticed that the gnulib-comp.m4 output was incorrect. Here is the item I was working on. I _think_ I understood it correctly but you guys are much more talented at shell

Re: [PATCH] gnulib-tool.py: Fix output of gnulib-comp.m4.

2024-03-03 Thread Collin Funk
Hi Bruno, On 3/3/24 2:34 AM, Bruno Haible wrote: > There are no problems with writing "condition != True". Remember the rule? > 'condition' as a variable can hold the values None, True, or a string. > Thus it has to be compared with == or !=. Yes, I was overthinking it. :) > "condition != True"

Re: [PATCH] gnulib-tool.py: Fix output of gnulib-comp.m4.

2024-03-03 Thread Bruno Haible
Hi Collin, > When working on the one of the TODO entries I noticed that > the gnulib-comp.m4 output was incorrect. The indentation was slightly > off and the output also had "if True;" conditionals. Here is a diff > from Emacs merge-gnulib to show the difference: > > @@ -784,8 +785,12 @@ AC_DEFUN

Re: Python list remove-duplicates

2024-03-03 Thread Bruno Haible
Collin Funk wrote: > > The output needs to be deterministic; the natural order from the module > > description is perfectly fine. Therefore the sorting in the Python code > > should > > go away. > > I've attached a patch Thanks; applied! > Since sets are unordered, before I found out duplicates

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 38.

2024-03-03 Thread Bruno Haible
Hi Collin, > This patch pretty much copy and pastes a lot of code used from > GLEmiter.lib_Makefile_am into GLEmiter.tests_Makefile_am. Thanks, I am applying it, together with a fix: When doing copy&paste, one needs to do it _mutatis mutandis_. 2024-03-03 Bruno Haible gnulib-tool.py

Re: --create-testdir speed

2024-03-03 Thread Bruno Haible
Collin Funk wrote: > > --create-megatestdir with all modules is not realistic: it would consume > > hundreds of GB of disk space and maybe a week of run time. > > > > --create-megatestdir is useful for a small set of modules, in particular > > for 2 modules, e.g. fnmatch-posix and fnmatch-gnu. >