Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

On 2024-02-18 04:19, Bruno Haible wrote: +When including including specific header files, you need to use the +@samp{#include <...>} syntax, not the @samp{#include "..."} syntax. Why does Gnulib source code ever use the #include "..." syntax? I don't see why it's helpful, given that one must a

Re: syntax-check rule to silence -Winclude-next-absolute-path warning

On Sun, Feb 18, 2024 at 12:33 PM Bruno Haible wrote: > Collin Funk wrote: > > I attached a patch that seems to work alright. I'm not the greatest with > > GNU Make so it isn't very pretty. Feel free to modify it as much as you > > would like. > > > > Here is some sample output from Coreutils. On

Re: [PATCH] gnulib-tool.py: Fix function call on incorrect object.

Hi Collin, > GNU m4 gave the following error: > > bootstrap: running: gnulib/gnulib-tool.py --no-changelog --no-libtool > --symlink --update > Traceback (most recent call last): > File "/home/collin/.local/src/m4/gnulib/gnulib-tool.py", line 1171, in > > main() > File "/home/collin/.lo

[PATCH] gnulib-tool.py: Fix function call on incorrect object.

I was looking around the gnulib code and decided to try out the Python gnulib-tool. It looks like it hasn't been touched in a while so I wanted to see what state it was in. Coreutils fails because --automake-subdir is not supported (already documented in gnulib-tool.py.TODO). GNU m4 gave the follow

Re: syntax-check rule to silence -Winclude-next-absolute-path warning

Collin Funk wrote: > I attached a patch that seems to work alright. I'm not the greatest with GNU > Make so it isn't very pretty. Feel free to modify it as much as you would > like. > > Here is some sample output from Coreutils. One or two are real so I'll submit > a patch there. > > [collin@d

Re: syntax-check rule to silence -Winclude-next-absolute-path warning

On 2/18/24 4:44 AM, Bruno Haible wrote: > Does anyone want to contribute a syntax-check rule (in maint.mk) for this? I attached a patch that seems to work alright. I'm not the greatest with GNU Make so it isn't very pretty. Feel free to modify it as much as you would like. Here is some sample ou

Re: localtime on native Windows

On 2024-02-18 06:38, Bruno Haible wrote: - How can the caller do the caching for something internal to the callee? The caller calls tzalloc, gets a timezone object, and calls tzfree when it no longer needs that timezone object. - The NetBSD code [1][2] does locking in the top-level fun

Re: localtime on native Windows

Paul Eggert wrote: > > Note also: The above approach will need locking, in order to protect caches > > (in 1) the data for a single time zone, in 3) the contents of tzdata.zi). > > The idea I had was to go more in the NetBSD / TZDB direction. These > implementations don't need either locks or loc

syntax-check rule to silence -Winclude-next-absolute-path warning

Does anyone want to contribute a syntax-check rule (in maint.mk) for this? The full list of header files for which #include "..." is to be avoided is: alloca.h arpa_inet.h assert.h ctype.h dirent.h errno.h error.h fcntl.h fenv.h float.h fnmatch.h getopt.h glob.h iconv.h inttypes.h langinfo.h limi

Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.

Collin Funk wrote: > > I also applied this patch, to complete > > : > > Thanks, gettext warns a lot about that header. I'll submit a patch over there > later today. Oh, I now see what you mean. Thanks for the patch. Before appl