Re: [PATCH 2/4] manywarnings: bring doc up to date

2023-04-23 Thread Bruno Haible
Paul Eggert wrote: > > May I make this doc change, or are the quadrigraphs still important > > for some reason? > > Sure, please go ahead; I did it that way only because I was copying the > example from coreutils configure.ac. OK. Done as follows. A long time ago, people used AC_HELP_STRING, an

Re: [PATCH 2/4] manywarnings: bring doc up to date

2023-04-23 Thread Paul Eggert
On 2023-04-23 09:50, Bruno Haible wrote: May I make this doc change, or are the quadrigraphs still important for some reason? Sure, please go ahead; I did it that way only because I was copying the example from coreutils configure.ac.

category-none: Fix link errors on MSVC, when libunistring is installed

2023-04-23 Thread Bruno Haible
On a MSVC system, with libunistring 1.0 installed, a Gnulib testdir has link errors: libgnu.a(categ_and_not.obj) : error LNK2019: unresolved external symbol __UC_CATEGORY_NONE referenced in function _uc_general_category_and_not libgnu.a(categ_and.obj) : error LNK2019: unresolved external symbol

Re: checking whether a double is in the range of long

2023-04-23 Thread Ben Pfaff
On Sat, Apr 22, 2023 at 10:40 PM Paul Eggert wrote: > On 2023-04-22 16:34, Ben Pfaff wrote: > > determine whether converting 'd' to 'long' would > > yield a 'long' with the same value as 'd' > > LONG_MIN - 1.0 < d && d < LONG_MAX + 1.0 && d == (long) d > > On all practical platforms this should av

Re: [PATCH 2/4] manywarnings: bring doc up to date

2023-04-23 Thread Bruno Haible
Paul Eggert wrote: > +AC_ARG_ENABLE([gcc-warnings], > + [AS_HELP_STRING([--enable-gcc-warnings@@<:@@=TYPE@@:>@@], Quadrigraphs are not needed here, when this syntax is used: [AS_HELP_STRING([[--enable-gcc-warnings[=TYPE]]], This syntax is supported since Autoconf 2.62, and Gnulib requires

Re: [PATCH 1/4] manywarnings: omit -fno-common in GCC 10+

2023-04-23 Thread Sam James
Paul Eggert writes: > * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Omit -fno-common > in GCC 10 and later, as it is the default there. I think this is fine, but I'd note that (to my surprise), nixpkgs inverted this default for a while. But I don't think that changes what you should do here. s

Re: [PATCH] Slightly nicer largefile, year2038 tests

2023-04-23 Thread Paul Eggert
Sorry, I sent that old patch to the mailing list by mistake.

[PATCH 4/4] manywarnings: use AS_IF

2023-04-23 Thread Paul Eggert
* m4/manywarnings.m4 (gl_MANYWARN_COMPLEMENT): Use AS_IF when the body contains Autoconf macros that could conceivably require something. --- ChangeLog | 5 + m4/manywarnings.m4 | 10 -- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog inde

[PATCH] Slightly nicer largefile, year2038 tests

2023-04-23 Thread Paul Eggert
* modules/largefile-tests, modules/year2038-tests (Depends-on): Add assert-h, intprops. * tests/test-largefile.c, tests/test-year2038.c: Prefer compile-time to run-time tests. Don’t assume CHAR_BIT == 8. --- ChangeLog | 9 + modules/largefile-tests | 2 ++ modules/year2038-

[PATCH 2/4] manywarnings: bring doc up to date

2023-04-23 Thread Paul Eggert
* doc/manywarnings.texi: Bring doc up to date for GCC 12. --- ChangeLog | 3 ++ doc/manywarnings.texi | 87 +-- 2 files changed, 63 insertions(+), 27 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9ae7506f45..5246e88037 100644 --- a/Chan

[PATCH 3/4] manywarnings: update C warnings for GCC 13

2023-04-23 Thread Paul Eggert
Adjust for C programs compiled by GCC 13. (A C++ expert still needs to look at manywarnings-c++.m4.) * build-aux/gcc-warning.spec: Add warnings introduced in GCC 13. * doc/manywarnings.texi (manywarnings): Document flex arrays. * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -fstrict-flex-arrays an

[PATCH 1/4] manywarnings: omit -fno-common in GCC 10+

2023-04-23 Thread Paul Eggert
* m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Omit -fno-common in GCC 10 and later, as it is the default there. Check exit status of ‘gcc --version’. --- ChangeLog | 7 +++ m4/manywarnings.m4 | 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/