Re: [PATCH] Use xattr (Linux) in qcopy-acl.c

2023-01-12 Thread Bruno Haible
Hi Ondrej, How did you test your patch? When I run $ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure \ acl-permissions copy-file qcopy-acl qset-acl supersede acl (with autoconf 2.71), I get two warnings: autoheader: warning: missing template: USE_XATTR

Re: Clang-built Gawk 5.2.1 regex oddity

2023-01-12 Thread Sam James
> On 5 Jan 2023, at 23:06, Arsen Arsenović wrote: > > Hi, > > Paul Eggert writes: > >> This is a serious bug in Clang: it generates incorrect machine code. >> >> The code that Clang generates for the following (gawk/support/dfa.c lines >> 1141-1143): >> >>((dfa->syntax.dfaopts & DFA_CO

Re: groff: error after update of gnulib, 13th January 2023

2023-01-12 Thread Bruno Haible
Bjarni Ingi Gislason wrote: > ../lib/openat-die.c:37:3: warning: implicit declaration of function 'error'; > did you mean 'strerror'? [-Wimplicit-function-declaration] >37 | error (exit_failure, errnum, > ... > "error.h" is a local file with: > > // -*- C++ -*- > /* Copyright (C) 1989-202

groff: error after update of gnulib, 13th January 2023

2023-01-12 Thread Bjarni Ingi Gislason
Software: groff I got these warnings in directory "groff/build" after an update of gnulib (13th January), commit 2886cca8398f4c5a4d68368a19c0e6d0ff97c739 CC lib/libgnu_a-openat-die.o In file included from ../lib/openat-die.c:25: ../src/include/error.h:22:44: warning: type defaults to '

Re: [PATCH] Use xattr (Linux) in qcopy-acl.c

2023-01-12 Thread Paul Eggert
On 1/12/23 12:58, Bruno Haible wrote: 1. remove the ALLOWing part of the old ACL, 2. add the DENYing part of the new ACL, 3. copy the data, 4. remove the DENYing part of the old ACL (as far as not also contained in the new ACL), 5. add the ALLOWing part of the new ACL. Somet

Re: [PATCH] Use xattr (Linux) in qcopy-acl.c

2023-01-12 Thread Bruno Haible
[Re-adding bug-gnulib in CC] Paul Eggert wrote: > > - similar vulnerability does exist in the old code, too > ... > But really, isn't it *odd* that there's no way to copy a file securely > with ACLs (either with xattr or without)? What's up with that? Didn't > ACL/xattr designers think about cop

Re: [PATCH] Use xattr (Linux) in qcopy-acl.c

2023-01-12 Thread Bruno Haible
Ondrej Valousek wrote: > Hi Bruno/Paul, > > Are we going to commit the proposed changes there or is there still anything > missing? > I am asking because I'd like to file a RFE for redhat coreutils improvement > and this change depends on it. Paul gave his OK in off-list email. So I pushed your

error: Work around an Android problem

2023-01-12 Thread Bruno Haible
On Android 11, the new test of the 'error' module fails: $ cat test-error.sh.log --- - 2023-01-12 11:30:19.594054663 +0100 +++ err22023-01-12 11:30:19.567829045 +0100 @@ -6,8 +6,8 @@ test-error:d1/foo.c:10: unsupported glink test-error:d1/foo.c:13: invalid brump test-error:d2/foo.c:1

Re: error, verror: Add tests

2023-01-12 Thread Bruno Haible
> 2023-01-12 Bruno Haible > > verror: Add tests. > * tests/test-verror.sh: New file, based on tests/test-error.sh. > * tests/test-verror.c: New file, based on tests/test-error.c. > * modules/verror-tests: New file. > > 2023-01-12 Bruno Haible > > error: Add te

error, verror: Add tests

2023-01-12 Thread Bruno Haible
In a testdir on Android 11, I am seeing these test failures: FAIL: test-xstrtoimax.sh --- exp 2023-01-10 14:13:27.438800298 +0100 +++ out 2023-01-10 14:13:27.388800678 +0100 @@ -1,9 +1,9 @@ 1->1 () -1->-1 () 1k->1024 () -invalid suffix in X argument '9