Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux

2022-12-01 Thread Bruno Haible
Hi Ondrej, Still some formatting issues. But now, with formatting nearly right, I'm able to spot other things too. > +# define ACE4_WHO_OWNER"OWNER@" > +# define ACE4_WHO_GROUP"GROUP@" > +# define ACE4_WHO_EVERYONE "EVERYONE@" > + > +# define ACE4_ACCESS_ALLOWED_ACE_TYPE 0 > +# define A

[PATCH] Basic support for checking NFSv4 ACLs in Linux

2022-12-01 Thread Ondrej Valousek
Hi Bruno, Could you review one more time? Thanks, Ondrej --- doc/acl-nfsv4.txt | 17 + lib/acl-internal.c | 95 ++ lib/acl-internal.h | 3 ++ lib/file-has-acl.c | 24 4 files changed, 135 insertions(+), 9 deletions(-) create mode

Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux

2022-12-01 Thread Bruno Haible
Hi Ondrej, Ondrej Valousek wrote: > Just sending the modified patch (fixed formatting + few suggestions from > Andreas included) > Does it look OK now? Some formatting issues, still. Details below. > diff --git a/doc/acl-nfsv4.txt b/doc/acl-nfsv4.txt > new file mode 100644 > index 0..55

[PATCH] Basic support for checking NFSv4 ACLs in Linux

2022-12-01 Thread Ondrej Valousek
Hi Bruno, Just sending the modified patch (fixed formatting + few suggestions from Andreas included) Does it look OK now? Thanks, Ondrej --- doc/acl-nfsv4.txt | 17 + lib/acl-internal.c | 95 ++ lib/acl-internal.h | 3 ++ lib/file-has-acl.c |