Re: Fix a couple of ShellCheck warnings

2022-07-23 Thread Jim Meyering
On Sat, Jul 23, 2022 at 1:57 PM Bruno Haible wrote: > The other issues reported by ShellCheck are pretty harmless. Still, fixing > some of them can improve security or code clarity. > > 2022-07-23 Bruno Haible > > Fix a couple of ShellCheck warnings. > * MODULES.html.sh (sed_esc

Fix a couple of ShellCheck warnings

2022-07-23 Thread Bruno Haible
The other issues reported by ShellCheck are pretty harmless. Still, fixing some of them can improve security or code clarity. 2022-07-23 Bruno Haible Fix a couple of ShellCheck warnings. * MODULES.html.sh (sed_escape_slash): Remove unused variable. * build-aux/bootstra

Avoid DoS vulnerability through unsafe default assignment

2022-07-23 Thread Bruno Haible
I started to run shellcheck on the shell scripts in gnulib. This patch fixes occurrences of https://www.shellcheck.net/wiki/SC2223 . The command to perform the substitution on a file f is sed -i -e 's/: [$][{]\([^{}=]*=[^{}=]*\)[}]$/: "\${\1}"/' "$f" 2022-07-23 Bruno Haible Avoid