Re: [PATCH 1/1] regex: fix broken clang build

2022-06-14 Thread Jeffrey Walton
On Tue, Jun 14, 2022 at 9:25 AM Darren Kenny wrote: > > The use of variable-length arrays (VLAs) is disabled by default in > clang 9 and above. > > The same pragma that works for GCC also works for clang, so check for > clang 9+ too. > > Signed-off-by: Darren Kenny > --- > lib/regex.h | 6 --

Re: [PATCH 1/1] regex: fix broken clang build

2022-06-14 Thread Paul Eggert
Why isn't a similar patch needed for lib/regex.c? Can you determine the earliest version of Clang that supports both "# pragma GCC diagnostic push" and "# pragma GCC diagnostic ignored "-Wvla""? A quick glance at the archived manuals suggests it goes back to at least Clang 4 but I suspect it's

Re: Parallelization of shell scripts for 'configure' etc.

2022-06-14 Thread Jeffrey Walton
On Tue, Jun 14, 2022 at 11:15 PM Ángel wrote: > > On 2022-06-13 at 18:32 -0700, Paul Eggert wrote: > > Yes, all that could be done in theory, but it'd take a lot of > > hacking and it's been decades and it hasn't happened. > > > > I'd rather have shell scripts "just work" in parallel with a minimu

Re: Parallelization of shell scripts for 'configure' etc.

2022-06-14 Thread Paul Eggert
On 6/14/22 18:55, Ángel wrote: Do you have any handy example of configure that takes too long to run? Sure. Coreutils, emacs. Pretty much any nontrivial configure script takes longer than it should. I understand that parallelization of shell scripts is nontrivial.

Re: Parallelization of shell scripts for 'configure' etc.

2022-06-14 Thread Ángel
On 2022-06-13 at 18:32 -0700, Paul Eggert wrote: > Yes, all that could be done in theory, but it'd take a lot of > hacking and it's been decades and it hasn't happened. > > I'd rather have shell scripts "just work" in parallel with a minimum > of fuss. If this hasn't happened, that might be becau

Re: Parallelization of shell scripts for 'configure' etc.

2022-06-14 Thread Paul Eggert
On 6/14/22 10:11, Nick Bowler wrote: The resulting config.h is correct but pa.sh took almost 1 minute to run the configure script, about ten times longer than dash takes to run the same script. More than half of that time appears to be spent just loading the program into pa.sh, before a single

Re: Parallelization of shell scripts for 'configure' etc.

2022-06-14 Thread Chet Ramey
On 6/13/22 6:39 PM, Paul Eggert wrote: > In many Gnu projects, the 'configure' script is the biggest barrier to > building because it takes s long to run. Is there some way that we > could improve its performance without completely reengineering it, by > improving Bash so that it can paralleliz

Re: Parallelization of shell scripts for 'configure' etc.

2022-06-14 Thread Steffen Nurpmeso
Chet Ramey wrote in <211b74c0-caed-227f-ffae-b85868ef7...@case.edu>: |On 6/13/22 6:39 PM, Paul Eggert wrote: |> In many Gnu projects, the 'configure' script is the biggest barrier to |> building because it takes s long to run. Is there some way that we |> could improve its performance with

[PATCH 0/1] Fix issue building regex with clang

2022-06-14 Thread Darren Kenny
GRUB makes use of a built-in version of gnulib, but when attempting to build it with clang, it is failing when building regex due to the use of variable-length arrays. There is a pragma that disables this when using GCC, but that is not enabled when building with clang. On the otherhand, clang a

[PATCH 1/1] regex: fix broken clang build

2022-06-14 Thread Darren Kenny
The use of variable-length arrays (VLAs) is disabled by default in clang 9 and above. The same pragma that works for GCC also works for clang, so check for clang 9+ too. Signed-off-by: Darren Kenny --- lib/regex.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/reg

Re: Test suite failure in clean chroot of ArchLinux

2022-06-14 Thread Letu Ren
Thanks for the investigation. I cannot reproduce the issue, because I don't know how you build your chroot environment. But anyway, with the details you gave, I believe the following patch should fix the failure. 2022-06-06 Bruno Haible getlogin, getlogin_r tests: Avoid test failure