Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Ryan Schmidt
On Jan 17, 2022, at 16:14, Paul Eggert wrote: > That part of Gnulib was introduced in 2013: > > https://lists.gnu.org/r/bug-gnulib/2013-11/msg00045.html > > and as I vaguely recall was in response to this macports ticket: > > https://trac.macports.org/ticket/41033 > I don't know whether th

Re: undefined references to "rpl_fclose" and "rpl_fflush"

2022-01-17 Thread Bruno Haible
Bjarni Ingi Gislason wrote: > Software: groff > > Adding some gnulib modules to "bootstrap.conf" after checking with > module "posixcheck": Glad to hear that the module 'posixcheck' still works fine! (I haven't actually used it for more than 10 years.) > results in linker errors: > > make[1]:

Re: license: comma or semicolon?

2022-01-17 Thread Dmitry V. Levin
On Tue, Jan 04, 2022 at 12:28:34AM +0100, Bernhard Voelker wrote: > On 1/3/22 01:17, Mike Frysinger wrote: > > according to gnu.org, it should be a comma. > > https://www.gnu.org/licenses/gpl-3.0.html#howto > > The attached would change it, and shows how the change was done: > > Subject: [PATCH

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Jeffrey Walton
On Mon, Jan 17, 2022 at 5:14 PM Paul Eggert wrote: > > On 1/17/22 10:37, Reuben Thomas wrote: > > > "extern-inline" copies a stanza of code into > > config.h. That code includes a test of the preprocessor macro > > "__header_inline". That macro is defined in a system header on macOS. > > When conf

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Reuben Thomas
On Mon, 17 Jan 2022 at 22:14, Paul Eggert wrote: > > Although the workaround still functions on current macOS, it's better to > use proper inline functions when available so I installed the attached > patch into Gnulib. Please give it a try. Thanks, I will. > I don't know whether the macOS world

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Paul Eggert
On 1/17/22 10:37, Reuben Thomas wrote: "extern-inline" copies a stanza of code into config.h. That code includes a test of the preprocessor macro "__header_inline". That macro is defined in a system header on macOS. When config.h is #included, no other header has been included. Therefore, the sy

undefined references to "rpl_fclose" and "rpl_fflush"

2022-01-17 Thread Bjarni Ingi Gislason
Software: groff Adding some gnulib modules to "bootstrap.conf" after checking with module "posixcheck": close dup execvp fclose fdopen fflush fopen freopen malloc-posix nl_langinfo pclose perror pipe-posix popen realloc-posix strer

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Reuben Thomas
On Mon, 17 Jan 2022 at 17:41, Paul Eggert wrote: > > Could you give complete instructions from scratch, to reproduce the > config.h that has this problem? Without that, it'll be hard for us to > understand or fix the problem. Sorry, I've failed to explain the problem clearly (or maybe there's a m

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Paul Eggert
On 1/17/22 04:50, Reuben Thomas wrote: Please, to help us reproduce the issue and verify a potential fix: How to reproduce the issue? I.e. What did you try to do, and what were the resulting diagnostics? $ gcc -dM -E config.h | grep GL_EXTERN #define _GL_EXTERN_INLINE static _GL_UNUSED #define _

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Reuben Thomas
On Mon, 17 Jan 2022 at 12:37, Bruno Haible wrote: > > Please, to help us reproduce the issue and verify a potential fix: > How to reproduce the issue? I.e. What did you try to do, and what were > the resulting diagnostics? $ gcc -dM -E config.h | grep GL_EXTERN #define _GL_EXTERN_INLINE static _G

Re: _GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Bruno Haible
Hi Reuben, > The definition of _GL_EXTERN_INLINE relies, on macOS, on > __header_inline, which is not a compiler built-in, but is defined in > sys/cdefs.h. Therefore, __header_inline is not defined when config.h > is included, and the tests always assume, on macOS, that the compiler > is buggy and

_GL_EXTERN_INLINE not defined correctly in config.h for macOS

2022-01-17 Thread Reuben Thomas
The definition of _GL_EXTERN_INLINE relies, on macOS, on __header_inline, which is not a compiler built-in, but is defined in sys/cdefs.h. Therefore, __header_inline is not defined when config.h is included, and the tests always assume, on macOS, that the compiler is buggy and does not support "ext

xstrtol: Trim dependencies

2022-01-17 Thread Bruno Haible
The module 'xstrtol' does not use any PRI*, SCN* constants. 2022-01-17 Bruno Haible xstrtol: Trim dependencies. * lib/xstrtol.h: Include , not . * modules/xstrtol (Depends-on): Add stdint. Remove inttypes-incomplete. diff --git a/lib/xstrtol.h b/lib/xstrtol.h index e3

Re: [PATCH 2/2] xstrtol: simplify integer overflow checking

2022-01-17 Thread Bruno Haible
Paul Eggert did: > * lib/xstrtol.c: Include intprops.h. > (TYPE_SIGNED): Remove, as intprops.h defines that for us now. > (bkm_scale): Use INT_MULTIPLY_WRAPV instead of checking for > overflow by hand. $ ./gnulib-tool --test --single-configure xstrtol fails: gcc -DHAVE_CONFIG_H -I. -I../../gllib

Re: [PATCH 2/2] xstrtol: simplify integer overflow checking

2022-01-17 Thread Jim Meyering
On Mon, Jan 17, 2022 at 7:53 AM Paul Eggert wrote: > * lib/xstrtol.c: Include intprops.h. > (TYPE_SIGNED): Remove, as intprops.h defines that for us now. > (bkm_scale): Use INT_MULTIPLY_WRAPV instead of checking for > overflow by hand. Thanks. I've just pushed this, too. xstrtol: remove unne