Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints

2021-12-08 Thread Paul Eggert
On 12/8/21 07:48, Bruno Haible wrote: 2) When I collect all warnings in the gllib/ directory of a full testdir, I get (with gcc-9.3): Typically, I don't worry much about warnings by older GCCs, as it's enough of a pain to worry about the latest version. Like Jim I don't have strong feelings

Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints

2021-12-08 Thread Jim Meyering
On Wed, Dec 8, 2021 at 7:48 AM Bruno Haible wrote: > > > especially given it's in the gcc -Wextra set, not some random flag > > Warnings in the '-Wall' category are typically worth eliminating: they > regularly point to real bugs. > > Eliminating '-Wsign-compare' warnings, OTOH, is usually a waste

Re: [PATCH v2 08/10] Fix up a bunch of "gcc -Werror=sign-compare" complaints

2021-12-08 Thread Bruno Haible
> especially given it's in the gcc -Wextra set, not some random flag Warnings in the '-Wall' category are typically worth eliminating: they regularly point to real bugs. Eliminating '-Wsign-compare' warnings, OTOH, is usually a waste of time, in my experience: I have hardly ever found a bug while