On 12/7/21 11:44, Robbie Harwood wrote:
it's odd to me to hear disabling it being the suggested course
of action (especially given it's in the gcc -Wextra set, not some random
flag).
Not odd at all. High-quality static-checking tools have tons of options
for a reason, and one shouldn't assume
On 12/7/21 10:51, Robbie Harwood wrote:
I don't believe we have an implementation of abort() that can
be called. (We have grub_abort() instead.) If that's the correct
reason, then DEBUG_ASSERT would work and I can make that change.
Looking into the code a bit more, it looks like a DEBUG_ASSER
On 12/7/21 09:38, Robbie Harwood wrote:
My*guess* is that Coverity has noticed that `mctx->state_log` is
checked against NULL in many other places in that file, and was unable
to prove to itself that it couldn't be NULL there too. If that's the
case, a DEBUG_ASSERT would presumably do the tric
Colin Watson writes:
> On Tue, Dec 07, 2021 at 11:59:01AM -0500, Robbie Harwood wrote:
>> Bruno Haible writes:
>> > I don't think this patch is needed, because:
>> >
>> > 1) The application cannot construct a 'struct argp_state' by itself, since
>> > [1]
>> >says that the 'struct argp_state
Paul Eggert writes:
> On 12/1/21 13:02, Robbie Harwood wrote:
>
>> diff --git a/lib/argp-fmtstream.c b/lib/argp-fmtstream.c
>> index f679751b9..4aa401e2d 100644
>> --- a/lib/argp-fmtstream.c
>> +++ b/lib/argp-fmtstream.c
>> @@ -234,7 +234,7 @@ __argp_fmtstream_update (argp_fmtstream_t fs)
>>
Paul Eggert writes:
> On 12/1/21 19:20, Paul Eggert wrote:
>> On 12/1/21 13:02, Robbie Harwood wrote:
>>> @@ -1099,7 +1099,7 @@ optimize_utf8 (re_dfa_t *dfa)
>>> }
>>> break;
>>> default:
>>> - abort ();
>>> + break;
>>> }
>>
>> Likewise, it's not clear why this
Paul Eggert writes:
> On 12/1/21 13:01, Robbie Harwood wrote:
>> The reason for this issue is that we are not building with DEBUG set and
>> this in turn means that the assert() that reads the value of the
>> variable match_last is being processed out.
>
> Could you explain what goes wrong? regex
Paul Eggert writes:
> On 12/1/21 13:01, Robbie Harwood wrote:
>> It appears to be possible that the mctx->state_log field may be NULL,
>
> I don't see how. re_search_internal sets mctx.state_log to a non-null
> value if dfa->has_mb_node, and clean_state_log_if_needed should be
> called only if
On Tue, Dec 07, 2021 at 11:59:01AM -0500, Robbie Harwood wrote:
> Bruno Haible writes:
> > I don't think this patch is needed, because:
> >
> > 1) The application cannot construct a 'struct argp_state' by itself, since
> > [1]
> >says that the 'struct argp_state' contains a member 'pstate' th
Bruno Haible writes:
> Robbie Harwood wrote:
>> From: Colin Watson
>>
>> [rharw...@redhat.com: tweaked commit message]
>> Signed-off-by: Robbie Harwood
>> ---
>> lib/argp-parse.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/argp-parse.c b/lib/argp-parse.c
>
Robbie Harwood wrote:
> From: Colin Watson
>
> [rharw...@redhat.com: tweaked commit message]
> Signed-off-by: Robbie Harwood
> ---
> lib/argp-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/argp-parse.c b/lib/argp-parse.c
> index 053495ec0..4f1c65d73 100644
11 matches
Mail list logo
