Re: [PATCH 01/11] Fix base64 module to work with grub codebase

Paul Eggert writes: > On 10/28/21 12:32, Robbie Harwood wrote: > >> I don't know why Patrick chose to >> not use that instead, but a local test seems to work. > > Is grub2 intended to be portable to compilers that don't support > ? If that's the issue, I suggest that grub2 stop worrying > that.

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

On 10/28/21 12:32, Robbie Harwood wrote: I don't know why Patrick chose to not use that instead, but a local test seems to work. Is grub2 intended to be portable to compilers that don't support ? If that's the issue, I suggest that grub2 stop worrying that. Surely every compiler of interest

Re: [PATCH 01/11] Fix base64 module to work with grub codebase

Robbie Harwood writes: > So I think our way forward is to move where we nerf _GL_ATTRIBUTE_CONST > in grub2. I've tested that this works and will submit to grub2. > > Longer-term, this problem could be avoided by dropping the const > attribute from isbase64(). Since uchar_in_range is a macro, b

[PATCH] exclude: yield proper errno on failure

* lib/exclude.c (add_exclude_file): Do not assume that fclose preserves errno on success. --- ChangeLog | 6 ++ lib/exclude.c | 23 ++- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index bde24b951..cdfd2ddf3 100644 --- a/Change