[PATCH 04/11] gnulib/regexec: Resolve unused variable

From: Darren Kenny This is a really minor issue where a variable is being assigned to but not checked before it is overwritten again. The reason for this issue is that we are not building with DEBUG set and this in turn means that the assert() that reads the value of the variable match_last is b

[PATCH 11/11] Fixup for -Werror=ignored-qualifiers issues

From: Peter Jones Signed-off-by: Peter Jones Signed-off-by: Robbie Harwood --- lib/argp-fmtstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/argp-fmtstream.c b/lib/argp-fmtstream.c index 4aa401e2d..d870716da 100644 --- a/lib/argp-fmtstream.c +++ b/lib/argp-fmtstr

[PATCH 03/11] gnulib/regexec: Fix possible null-dereference

From: Darren Kenny It appears to be possible that the mctx->state_log field may be NULL, and the name of this function, clean_state_log_if_needed(), suggests that it should be checking that it is valid to be cleaned before assuming that it does. Fixes: CID 86720 Signed-off-by: Darren Kenny Rev

[PATCH 06/11] Make gnulib's regcomp not abort()

From: Vladimir 'phcoder' Serbinenko [rharw...@redhat.com: we wrote a commit message] Signed-off-by: Robbie Harwood --- lib/regcomp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/regcomp.c b/lib/regcomp.c index 887e5b506..4a106ff59 100644 --- a/lib/regcomp.c ++

[PATCH 01/11] Fix base64 module to work with grub codebase

From: Patrick Steinhardt The gnulib module makes use of booleans via the header. As GRUB does not provide any POSIX wrapper header for this, but instead implements support for bool in , we need to patch base64.h to not use anymore. We unfortunately cannot include instead, as it would then use

[PATCH 02/11] argp-parse.c (__argp_input): Don't crash if pstate is NULL

From: Colin Watson [rharw...@redhat.com: tweaked commit message] Signed-off-by: Robbie Harwood --- lib/argp-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/argp-parse.c b/lib/argp-parse.c index 053495ec0..4f1c65d73 100644 --- a/lib/argp-parse.c +++ b/lib/argp-par

[PATCH 10/11] Paper over a stringop-overflow warning about wide char handling

From: Peter Jones [rharw...@redhat.com: rewrote commit message] Signed-off-by: Robbie Harwood --- lib/vasnprintf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/vasnprintf.c b/lib/vasnprintf.c index 360ca6948..7faa11753 100644 --- a/lib/vasnprintf.c +++ b/lib/vasnprintf.c @@ -234,8

[PATCH 05/11] Fix width computation

From: Vladimir 'phcoder' Serbinenko Signed-off-by: Robbie Harwood --- lib/argp-fmtstream.c | 80 +--- lib/argp-help.c | 3 +- lib/mbswidth.c | 15 + lib/mbswidth.h | 4 +++ 4 files changed, 88 insertions(+), 14 deletions(-) dif

[PATCH 08/11] Fix __argp_fmtstream_point()'s return type and comparisons with it

From: Peter Jones gcc -Werror=sign-compare produces: argp-help.c:1545:15: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 1545 | > __argp_fmtstream_lmargin (stream)) | ^ Som

[PATCH 09/11] Fix up a bunch of "gcc -Werror=sign-compare" complaints

From: Peter Jones [rharw...@redhat.com: rebase conflicts in regexec] Signed-off-by: Robbie Harwood --- lib/argp-fmtstream.c | 2 +- lib/regcomp.c| 28 +++- lib/regex_internal.c | 6 +++--- lib/regexec.c| 36 lib/vasn

[PATCH 00/11] Code hygiene fixes from grub

Hello gnulib, grub2 uses a patched gnulib, on top of d271f868a8df9bbec29049d01e056481b7a1a263 (from 2019-01-05). There are nine patches carried in the grub2 source tree. Three have been resolved upstream since divergence; the reamining six are the first in this series. Downstream in Fedora, we

[PATCH 07/11] Make CFLAGS less painful

From: Peter Jones Signed-off-by: Peter Jones [rharw...@redhat.com: make rpm gunk conditional] Signed-off-by: Robbie Harwood --- gnulib-tool | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/gnulib-tool b/gnulib-tool index 9c4a6c17e..24cdbe2da 100755 --- a/gnulib-t

Re: Emacs build fails on Windows mingw64

On Mon 25 Oct 2021, Bruno Haible wrote: > Andy Moreton wrote: >> > Andy suggested a simple fix that I quoted here: >> > >> > https://lists.gnu.org/r/emacs-devel/2021-10/msg01698.html >> > >> > We could apply that patch just to ntlib.c and just in emacs-28 (do not >> > merge >> > to master) as And

[PATCH v2] bootstrap: When a commit hash is specified, do a shallow fetch if possible

The gnulib sources are large but more importantly have lots of changes. So initial checkout of the repository can take a long time when network or cpu resources are limited. The later is especially acute in a non-KVM QEMU virtual machine (which can take 40+ minutes compared to <30 seconds with this

Re: Emacs build fails on Windows mingw64

> From: Bruno Haible > Date: Mon, 25 Oct 2021 00:52:45 +0200 > Cc: Andy Moreton , emacs-de...@gnu.org > > This patch should fix it. > > > 2021-10-24 Bruno Haible > > string: Avoid syntax error re strdup in string.in.h (regr. 2021-09-07). > Reported by Jan Engelhardt > and