Re: [PATCH 3/3] lib/regexec: Resolve unused variable

On 8/23/21 3:38 AM, Darren Kenny wrote: What I did here was to not overwrite the value if DEBUG is set, since it appeared to never be checked anyway within the for-loop. Yes, but although your patch pacified Coverity I still don't understand exactly why. I'd like to get to the bottom of it be

Re: [PATCH 1/3] lib/regexec: Fix possible null-dereference

On 8/23/21 3:05 AM, Darren Kenny wrote: The explanation given by Coverity boils down to: - In check_matching(), line 1069, there is a test if mctx->state_log != NULL This line number doesn't match either the current Gnulib version (commit d3837928885e91c9ddd465240b90a97aa342fda6) nor the

Re: [PATCH 3/3] lib/regexec: Resolve unused variable

Darren Kenny wrote: > I can see that LLVM has a __builtin_assume() though, but that's about > the closest I could find. We avoid clang's __builtin_assume, because it triggers the generation of wrong code. See . Bruno

Re: bug#50098: Configuring --with-libsigsegv results in link error

> On Aug 17, 2021, at 22:04, Evan Miller wrote: > > >> On Aug 17, 2021, at 18:53, Paul Eggert wrote: >> >> On 8/17/21 1:02 PM, Evan Miller wrote: >> >>> Thanks for the patch. At present, the non-libsigsegv implementation does >>> not compile on this machine for reasons described in >>> http

Re: bug#50098: Configuring --with-libsigsegv results in link error

> On Aug 23, 2021, at 05:49, Bruno Haible wrote: > > That's what I suspected, for the reasons mentioned in [1]. > > Now, to check that with libsigsegv it works fine: > > make distclean > > ./configure CPPFLAGS=-Wall --with-libsigsegv > --with-libsigsegv-prefix=/opt/local > (use the prefi

Re: [PATCH 3/3] lib/regexec: Resolve unused variable

Hi Paul, On Wednesday, 2021-08-11 at 00:24:25 -07, Paul Eggert wrote: > On 6/18/21 8:44 AM, Darren Kenny wrote: >> The reason for this issue is that we are not building with DEBUG set and >> this in turn means that the assert() that reads the value of the >> variable match_last is being processed

Re: [PATCH 1/3] lib/regexec: Fix possible null-dereference

Hi Paul, Sorry, somehow I missed your responses. On Wednesday, 2021-08-11 at 00:28:26 -07, Paul Eggert wrote: > On 6/18/21 8:44 AM, Darren Kenny wrote: >> It appears to be possible that the mctx->state_log field may be NULL > > How so? I don't see the execution path that would do that. > The exp

Re: bug#50098: Configuring --with-libsigsegv results in link error

Evan Miller wrote: > At last, the "sigsegv" stackoverflow tests fail: > > ../build-aux/test-driver: line 112: 12956 Illegal instruction "$@" > >$log_file 2>&1 > FAIL: test-sigsegv-catch-stackoverflow1 > ../build-aux/test-driver: line 112: 12963 Illegal instruction "$@" > >$log_file 2>&1