Re: tar + cpio - covscan issues

2021-04-11 Thread Ondrej Dubaj
Thanks for the explanation, which of the reports do you consider as false positives and which as real issues ? If there are some real issues, are you willing to fix them ? Thank you. Ondrej On Sat, Apr 10, 2021 at 12:32 PM Bruno Haible wrote: > Hi Ondrej, > > > proposing patch for some of the

Re: [PATCH] realloc: fix undef typo

2021-04-11 Thread Bruno Haible
Hi Paul, > > The patch above has the effect that libunistring.so will now export > > 'realloc'. Which is not right. > > OK, but why doesn't a similar problem happen with malloc and calloc? > lib/malloc.c has "#undef malloc", and similarly for lib/calloc.c. It surely happens for 'malloc' and 'ca

Re: tar + cpio - covscan issues

2021-04-11 Thread Paul Eggert
On 4/10/21 11:40 AM, Bruno Haible wrote: True. But it clutters up the source code. For tools that produce 5-10 times more false reports than good reports, I wouldn't do this. Likewise. Static analysis tools come and go, but source code is forever. I like Bruno's suggestion of suppressing analy

Re: [PATCH] realloc: fix undef typo

2021-04-11 Thread Paul Eggert
On 4/10/21 3:22 PM, Bruno Haible wrote: The patch above has the effect that libunistring.so will now export 'realloc'. Which is not right. OK, but why doesn't a similar problem happen with malloc and calloc? lib/malloc.c has "#undef malloc", and similarly for lib/calloc.c. I doubt there are

Re: Interference between two installations of gnulib

2021-04-11 Thread Bruno Haible
Hi Reuben, > I have made two installations of gnulib in a project, because I am using > both relocatable-prog and relocatable-lib-lgpl. > > I have different modules installed for each, of course. > > I just had a problem where my library would not compile, because it was > missing setlocale_null

Re: Portability issues with scractch_buffer

2021-04-11 Thread Akim Demaille
Hi Paul, > Le 20 janv. 2021 à 21:14, Akim Demaille a écrit : > > Hi Paul, > >> Le 20 janv. 2021 à 02:50, Paul Eggert a écrit : >> >> On 1/19/21 10:22 AM, Akim Demaille wrote: >> >>> Clang 3.3 and 3.4 cannot compile the new scratch-buffer module. On Bison's >>> CI (Clang 3.4: https://api.tr

implement --version option according to GCS

2021-04-11 Thread Bruno Haible
These patches implement a --version option for some of the build-aux/* programs according to the GNU Coding Standards I concentrated on the programs that are likely invoked interactively. Adding --help and --version to helper

increment-serial: New program

2021-04-11 Thread Bruno Haible
This patch adds a program to increment the serial number of *.m4 files. I got tired of doing it by hand. 2021-04-11 Bruno Haible increment-serial: New program. * build-aux/increment-serial: New file. == build-aux/increment-serial ==