simplify GNULIB_* variable initializations

2021-04-10 Thread Bruno Haible
This patch prepares further changes regarding GNULIB_* variables. 2021-04-10 Bruno Haible Simplify GNULIB_* variable initializations. * modules/gnulib-common.m4 (gl_MODULE_INDICATOR_INIT_VARIABLE): New macro. * m4/arpa_inet_h.m4 (gl_ARPA_INET_H_DEFAULTS): Use i

Re: [PATCH] realloc: fix undef typo

2021-04-10 Thread Bruno Haible
Hi Paul, > diff --git a/lib/realloc.c b/lib/realloc.c > index 51d8d2108..ab027d7f7 100644 > --- a/lib/realloc.c > +++ b/lib/realloc.c > @@ -24,6 +24,7 @@ > /* Only the AC_FUNC_REALLOC macro defines 'realloc' already in config.h. */ > #ifdef realloc > # define NEED_REALLOC_GNU 1 > +# undef real

Re: [PATCH] utimens: fix confusing arg type in internal func

2021-04-10 Thread Paul Eggert
On 4/10/21 6:16 AM, Kamil Dudka wrote: This happens with a pre-release of gcc-11. Thanks for clarifying; I installed the attached ChangeLog fix. >From b967bf4908694ebc4190c9675496121002240ff1 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 10 Apr 2021 13:39:33 -0700 Subject: [PATCH] Blam

[PATCH] realloc: fix undef typo

2021-04-10 Thread Paul Eggert
* lib/realloc.c: #undef realloc if config.h defines it. This fixes a typo that I introduced in 2011-04-08T18:39:01Z!egg...@cs.ucla.edu. Apparently nobody uses Gnulib realloc in that way? --- ChangeLog | 8 lib/realloc.c | 1 + 2 files changed, 9 insertions(+) diff --git a/ChangeLog b

Re: tar + cpio - covscan issues

2021-04-10 Thread Bruno Haible
Hi Kamil, > I meant the public reports on this mailing-list like the one that Ondrej > sent. > As gnulib is embedded in multiple RPM packages of Fedora/RHEL, such reports > are going to come periodically until you change your attitude to handling > false positives upstream. > ... > The problem

Re: tar + cpio - covscan issues

2021-04-10 Thread Kamil Dudka
On Saturday, April 10, 2021 3:58:57 PM CEST Bruno Haible wrote: > Kamil Dudka wrote: > Paul and I receive a mail with the *new* issues once a week. We never review > the same issue more than once. I was not talking about the private notifications you get from Coverity Scan. I meant the public re

Re: tar + cpio - covscan issues

2021-04-10 Thread Bruno Haible
Kamil Dudka wrote: > > When we get Coverity reports, we fix the things that are valid complaints > > about the code, but we do NOT change the code to reduce the number of > > reported issues. That is because > > If you have enough time to manually review the same false positives over and > over,

Re: tar + cpio - covscan issues

2021-04-10 Thread Kamil Dudka
On Saturday, April 10, 2021 12:26:37 PM CEST Bruno Haible wrote: > Hi Ondrej, > > > proposing patch for some of the issues found by coverity scan in tar-1.34 > > Thanks for these reports. > > When we get Coverity reports, we fix the things that are valid complaints > about the code, but we do NO

Re: [PATCH] utimens: fix confusing arg type in internal func

2021-04-10 Thread Kamil Dudka
On Saturday, April 10, 2021 3:19:08 AM CEST Paul Eggert wrote: > On 4/9/21 12:50 AM, Kamil Dudka wrote: > > The warning[-Wstringop-overflow=] reports you refer to come from GCC > > actually. > Weird. The code being warned about has nothing to do with strings, and > the only string operation in the

Re: tar + cpio - covscan issues

2021-04-10 Thread Bruno Haible
Hi Ondrej, > proposing patch for some of the issues found by coverity scan in tar-1.34 Thanks for these reports. When we get Coverity reports, we fix the things that are valid complaints about the code, but we do NOT change the code to reduce the number of reported issues. That is because 1) C

Interference between two installations of gnulib

2021-04-10 Thread Reuben Thomas
I have made two installations of gnulib in a project, because I am using both relocatable-prog and relocatable-lib-lgpl. I have different modules installed for each, of course. I just had a problem where my library would not compile, because it was missing setlocale_null.h. GNULIB_SETLOCALE_NULL