Re: [PATCH] utimens: fix confusing arg type in internal func

2021-04-09 Thread Paul Eggert
On 4/9/21 12:50 AM, Kamil Dudka wrote: The warning[-Wstringop-overflow=] reports you refer to come from GCC actually. Weird. The code being warned about has nothing to do with strings, and the only string operation in the entire module is strlen and it is compiled only on macOS. And I don't g

Typo in relocatable-maint.texi?

2021-04-09 Thread Reuben Thomas
In the following text, describing how to use multiple gnulib installations: Correspondingly for the programs you will have to add something like this: ... AM_CPPFLAGS = -I$(top_srcdir)/src/gnulib -I$(top_builddir)/src/gnulib ... LIBADD = $(top_builddir)/src/gnulib/libgnutoo

Re: Using relocatable-prog with relocatable libraries

2021-04-09 Thread Reuben Thomas
On Fri, 9 Apr 2021 at 11:18, Reuben Thomas wrote: > On Fri, 9 Apr 2021 at 02:41, Ben Pfaff wrote: > >> Do you think it should be better documented, or documented somewhere >> else? (I'm only getting to my email now.) >> > One practical reminder that would be useful: that you need to add a -I fla

Re: Autogenerated header files not included in .gitignore

2021-04-09 Thread Marc Nieper-Wißkirchen
I have been experimenting a bit with building in a dedicated build directory. Nevertheless, I still end up with artefacts in the source directory, which are not covered by Gnulib's .gitignore files, for example with: lib/iconv_open-aix.h lib/iconv_open-hpux.h lib/iconv_open-irix.h lib/iconv_open-o

Re: Using relocatable-prog with relocatable libraries

2021-04-09 Thread Reuben Thomas
On Fri, 9 Apr 2021 at 02:41, Ben Pfaff wrote: > On Mon, Apr 5, 2021 at 3:43 PM Reuben Thomas wrote: > > > > On Mon, 5 Apr 2021 at 23:36, Reuben Thomas wrote: > >> > >> > >> The comment about "all the copies of relocatable.c" in progreloc.c is > surely is clue, but I cannot see how more than one

Re: [PATCH] utimens: fix confusing arg type in internal func

2021-04-09 Thread Kamil Dudka
On Thursday, April 8, 2021 2:30:42 AM CEST Paul Eggert wrote: > Although the old code was technically correct, this was accidental > and it understandably confused Coverity. Reported by Ondrej Dubaj in: > https://lists.gnu.org/r/bug-tar/2021-04/msg0.html The warning[-Wstringop-overflow=] repo