Re: different CFLAGS for gnulib code?

2021-01-15 Thread Darshit Shah
On 15.01.21 12:11, Paul Eggert wrote: > On 1/15/21 12:55 AM, Bruno Haible wrote: >> Would compiling the gnulib >> part with options for fewer warnings be OK with you? > > Not only is it OK, it's routine. Coreutils, Emacs, etc. do it. > Wget does the same thing as well. I treat gnulib as anoth

Re: different CFLAGS for gnulib code?

2021-01-15 Thread Jim Meyering
On Fri, Jan 15, 2021 at 12:55 AM Bruno Haible wrote: > Jeffrey Walton wrote: > > Perhaps it would be a good idea to filter-out the options that you > > don't want present for Gnulib. ... > It is an interesting idea. Leaving the question aside how it is implemented > (through an AC_SUBSTed variable

Re: clang++ hard failure with GNULIB_NAMESPACE

2021-01-15 Thread Alexandre Duret-Lutz
Hi Bruno Bruno Haible writes: >> Using clang++ 11, compilation fails because of the overloads of memchr >> and friends. >> >> In file included from bitvect.cc:28: >> In file included from >> /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/cstring:42: >> ../../lib/string.h:69

Re: different CFLAGS for gnulib code?

2021-01-15 Thread Simon Josefsson via Gnulib discussion list
fre 2021-01-15 klockan 09:55 +0100 skrev Bruno Haible: > It is an interesting idea. Leaving the question aside how it is > implemented > (through an AC_SUBSTed variable or what else), the main question is: > Would > some GNU package maintainers want this? > > I always thought that GNU package main

Re: different CFLAGS for gnulib code?

2021-01-15 Thread Paul Eggert
On 1/15/21 12:55 AM, Bruno Haible wrote: Would compiling the gnulib part with options for fewer warnings be OK with you? Not only is it OK, it's routine. Coreutils, Emacs, etc. do it.

Re: clang++ hard failure with GNULIB_NAMESPACE

2021-01-15 Thread Bruno Haible
Hi Alexandre, > Using clang++ 11, compilation fails because of the overloads of memchr > and friends. Note that clang++11 defines __GNUC__ and __GNU_MINOR__ as > 4 and 2 (Yuck!) so the two _GL_CXXALIASWARN1 calls dealing with the two > overloads in lib/string.h are not performed. > > In file inc

Re: different CFLAGS for gnulib code?

2021-01-15 Thread Alexandre Duret-Lutz
Bruno Haible writes: > I always thought that GNU package maintainers want their entire package to > be compiled with the same CFLAGS and CPPFLAGS. Would compiling the gnulib > part with options for fewer warnings be OK with you? Just note that none of the warnings and errors I complained about r

different CFLAGS for gnulib code?

2021-01-15 Thread Bruno Haible
Hi, Jeffrey Walton wrote: > Perhaps it would be a good idea to filter-out the options that you > don't want present for Gnulib. > > If you are doing it during configure, then take the user's CFLAGS (or > CXXFLAGS) and then: > >TCFLAGS=`echo $CFLAGS | sed -e 's/-Wall//g' -e 's/-Wextra//g'