asyncsafe-spin.c fails to compile on Solaris 10 sparc

2020-11-15 Thread Paul Eggert
I attempted to reproduce Tom Christensen's first problem listed here: https://lists.gnu.org/r/bug-gnulib/2020-11/msg00062.html on Solaris 10 sparc, by running this: ./gnulib-tool --create-testdir --dir foo getumask and then on Solaris: ./configure make make check This failed as follows: dep

Re: Build errors on Solaris

2020-11-15 Thread Paul Eggert
On 11/15/20 10:01 AM, Tom G. Christensen wrote: Undefined   first referenced  symbol in file clock_gettime   ../gllib/libgnu.a(tempname.o) ld: fatal: symbol referencing errors. No output written to test-getumask collect2: error:

Re: [PATCH 5/5] bitset: use ffsl to accelerate iterations over set bits

2020-11-15 Thread Akim Demaille
> Le 15 nov. 2020 à 19:07, Bruno Haible a écrit : > > Hi Akim, > >> Thanks for catching these errors. I have fixed them. >> Good to install? > > Yes, assuming you did a quick check with the unit tests: > ./gnulib-tool --test --single-configure bitset Yes, I did run the test suite :) Inst

Re: [PATCH 5/5] bitset: use ffsl to accelerate iterations over set bits

2020-11-15 Thread Bruno Haible
Hi Akim, > Thanks for catching these errors. I have fixed them. > Good to install? Yes, assuming you did a quick check with the unit tests: ./gnulib-tool --test --single-configure bitset Bruno

Build errors on Solaris

2020-11-15 Thread Tom G. Christensen
Hi, I tried to build a gnulib snapshot on Solaris 10 and older but there are currently several issues preventing the build from completing on those platforms. The full buildlogs can be found here: https://jupiterrise.com/autobuild/gnulib/ Below is an excerpt of the errors seen. Starting wit

Re: [PATCH 5/5] bitset: use ffsl to accelerate iterations over set bits

2020-11-15 Thread Akim Demaille
Hi Bruno, > Le 15 nov. 2020 à 17:42, Bruno Haible a écrit : > > Akim Demaille wrote: >> @@ -20,6 +20,7 @@ Depends-on: >> attribute >> c99 >> fopen-gnu >> +fssl > > Typo: We don't have a module named 'fssl'. Thanks for catching these errors. I have fixed them. Good to install?

Re: [PATCH 5/5] bitset: use ffsl to accelerate iterations over set bits

2020-11-15 Thread Bruno Haible
Akim Demaille wrote: > @@ -20,6 +20,7 @@ Depends-on: > attribute > c99 > fopen-gnu > +fssl Typo: We don't have a module named 'fssl'. Bruno

Re: [PATCH 4/5] bitset: more tests

2020-11-15 Thread Bruno Haible
Akim Demaille wrote: > + { > + bitset_bindex first = bitset_first (adst); > + ASSERT (first == bitset_first (bdst)); > What's up with the indentation, here (lines 169..191)? Bruno

Re: [PATCH 2/5] bitset: making debug traces more useful

2020-11-15 Thread Bruno Haible
Akim Demaille wrote: > * lib/bitset.c (bitset_print): Print the bitset type in verbose node. Is this a typo? s/node/mode/ ? Bruno

[PATCH 3/5] bitset: fix the copy from lbitset to other types

2020-11-15 Thread Akim Demaille
bitset_copy from an lbitset did not check whether the destination has the same type. Apply the same strategy as elsewhere. Without this commit, the following one fails. * lib/bitset/list.c (lbitset_copy): Rename as... (lbitset_copy_): this. (lbitset_copy): New. Dispatch to heterogeneous/homogene

[PATCH 2/5] bitset: making debug traces more useful

2020-11-15 Thread Akim Demaille
* lib/bitset.c (bitset_print): Print the bitset type in verbose node. --- ChangeLog| 3 +++ lib/bitset.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index f25a948eb..3e3e78ed3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2020-11-15

[PATCH 1/5] bitset: comment changes

2020-11-15 Thread Akim Demaille
* lib/bitset.c: Move some documenting comments to... * lib/bitset.h: here. * lib/bitset/array.c: Fix some comments. --- ChangeLog | 7 +++ lib/bitset.c | 4 lib/bitset.h | 20 lib/bitset/array.c | 6 +++--- 4 files changed, 22 insertions(+), 15

[PATCH 4/5] bitset: more tests

2020-11-15 Thread Akim Demaille
These new tests managed to uncover shortcomings in previous versions of the following commit. * tests/test-bitset.c (compare): Make it clear that the random values should not be modified. Check bitset_first, bitset_last and BITSET_FOR_EACH. --- ChangeLog | 5 +++ tests/test-bitset.c |

[PATCH 5/5] bitset: use ffsl to accelerate iterations over set bits

2020-11-15 Thread Akim Demaille
Currently we iterate over words bit by bit. Instead, we should jump from set bit to set bit. Suggested by Bruno Haible. * modules/bitset: Depend upon ffsl. * lib/bitset/base.h (bitset_ffs, BITSET_FOR_EACH_BIT): New. * lib/bitset/array.c (abitset_list): Use BITSET_FOR_EACH_BIT. --- ChangeLog

[PATCH 0/5] bitset: use ffs

2020-11-15 Thread Akim Demaille
Some time ago, Bruno reported that it was surprising that there are no occurrences of ffs in the bitset module. This series introduces the use of ffs in array-based bitsets. There are more places where ffs could be used, but before installing it everywhere, I want to first make sure that the appr