Re: AS_IF

2020-10-04 Thread Paul Eggert
On 10/4/20 4:40 PM, Bruno Haible wrote: AFAICS, this is relevant for code written directly into configure.ac. But inside an AC_DEFUN it is irrelevant, because required macros are hoisted before the body of the AC_DEFUN anyway. I was playing it safe based on this NEWS item from Autoconf 2.69c:

Re: AS_IF

2020-10-04 Thread Bruno Haible
Hi Paul, > The third patch merely streamlines 'configure' when running on platforms like > Solaris that need not use libsigsegv. > > - if test "$gl_cv_lib_sigsegv" = yes \ > - && test "$gl_cv_sys_xsi_stack_overflow_heuristic" != yes; then > - AC_SUBST([LIBCSTACK], [$LIBSIGSEGV]) > -

Re: grep-3.5 fails to build on Solaris when libsigsegv is installed

2020-10-04 Thread Paul Eggert
On 9/28/20 7:02 PM, Bruno Haible wrote: #define USE_LIBSIGSEGV (HAVE_XSI_STACK_OVERFLOW_HEURISTIC && HAVE_LIBSIGSEGV) There seems to be a logic mistake, here. You're right, it's a typo: there should be a "!" before the HAVE_XSI_STACK_OVERFLOW_HEURISTIC. As a result of this mistake, libsigsegv

Re: Unused parameter warnings

2020-10-04 Thread Bruno Haible
Hi Marc, Marc Nieper-Wißkirchen wrote: > When compiling Gnulib with -Wunused-parameter, I get the following > report from GCC: > > lib/localename.c: In function 'gl_locale_name_thread_unsafe': > lib/localename.c:3117:57: error: unused parameter 'categoryname' > [-Werror=unused-parameter] > 3117

Re: vasnprintf: avoid using %n in the general case

2020-10-04 Thread Jeremie Courreges-Anglas
On Sun, Oct 04 2020, Bruno Haible wrote: > Hi Jeremie, > >> The attached patch changes vasnprintf.c to avoid using %n in the general >> case, ie when the return value of snprintf is usable. This should help >> if more systems decide to make tighten %n usage. There are plans for >> that in OpenBS

Unused parameter warnings

2020-10-04 Thread Marc Nieper-Wißkirchen
When compiling Gnulib with -Wunused-parameter, I get the following report from GCC: lib/localename.c: In function 'gl_locale_name_thread_unsafe': lib/localename.c:3117:57: error: unused parameter 'categoryname' [-Werror=unused-parameter] 3117 | gl_locale_name_thread_unsafe (int category, const ch

Re: vasnprintf: avoid using %n in the general case

2020-10-04 Thread Bruno Haible
Hi Jeremie, > The attached patch changes vasnprintf.c to avoid using %n in the general > case, ie when the return value of snprintf is usable. This should help > if more systems decide to make tighten %n usage. There are plans for > that in OpenBSD land. Thanks for the suggestion. Yes, this is