On 9/11/20 11:41 PM, Jim Meyering wrote:
https://bugs.gnu.org/40634#32
I'll try to take a look at the later patch.
Oh! Glad you spotted that.
I took a look and the basic idea sounds good though I admit I did not check
every detail. While looking into it I found some opportunities for impro
* lib/dfa.c (merge_nfa_state): Do not initialize the constraint
to zero here.
(dfaoptimize): Do it here instead, via xcalloc. This prevents the
use of an uninitialized constraint by later code when ! (flags[i]
& OPT_QUEUED) means merge_nfa_state was not called to initialize
the constraint. Proble
* lib/dfa.c (reorder_tokens): Assume C99 and simplify.
---
ChangeLog | 3 +++
lib/dfa.c | 32 ++--
2 files changed, 13 insertions(+), 22 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 1b5720761..5f7a148e3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
* lib/dfa.c (reorder_tokens): When setting
map[d->follows[i].elems[j].index], instead of incorrectly assuming
that (i < d->follows[i].elems[j].index), use two loops, one to set
the map array and the other to use it. The incorrect assumption
caused some elements to be missed, and this in turn cause
Each one needs its own -Wl,-rpath,$dir option, instead of being attached
to a single one in some way. Otherwise, the build fails at link time.
---
2020-09-13 Ben Pfaff
* build-aux/reloc-ldflags: Fix handling of multiple relocatable
library directories. Each one needs its own -
thank you.
On Sun, Sep 13, 2020 at 11:11 PM Bruno Haible wrote:
>
> Hi Joël,
>
> > Because recent gnulib has problems with read, write and close as
> > struct fields. I am still using:
> >
> > gnulib$ git log
> > commit 2d431ac35c4943a3655c07ba91870d2323321b43 (HEAD -> master,
> > origin/master,
Hi Joël,
> Because recent gnulib has problems with read, write and close as
> struct fields. I am still using:
>
> gnulib$ git log
> commit 2d431ac35c4943a3655c07ba91870d2323321b43 (HEAD -> master,
> origin/master, origin/HEAD)
>
> Here is my code:
>
> https://git.savannah.nongnu.org/cgit/gsequ
Hi Daiki,
> One thing I noticed though is that
> parse-datetime-gen.h has no dependency declaration and fails to build
> with parallel make:
>
> make[2]: *** No rule to make target 'parse-datetime-gen.h', needed by
> 'all'. Stop.
> make[2]: *** Waiting for unfinished jobs
> YACC
On Sun, Sep 13, 2020 at 09:05:32PM +0200, Bruno Haible wrote:
> > 2020-09-12 Ben Pfaff
> >
> > Check for nonnull prompt argument while avoiding warnings.
> > * lib/getpass.c (_GL_ARG_NONNULL): Define to empty.
> > (getpass) [!_WIN32]: Print prompt only if nonnull.
>
> Looks good. A
Hi Ben,
> * The POSIX implementation in gnulib passes the prompt to fputs()
> without checking for null. I guess we should fix it.
Yes. This bit of added robustness doesn't cost much (neither in terms
of source code and maintenance, nor in terms of generated code).
> From: Ben Pfaff
> Da
On Sun, Sep 13, 2020 at 10:32:27AM +0200, Bruno Haible wrote:
> > The prompt parameter to getpass() is declared as nonnull (using a GCC
> > nonnull attribute), but the implementation checks whether it is null in
> > two places. GCC warns about this. This commit removes the checks
>
> GCC warning
Hi John,
> > +/* Like path_search, except that TMPL is allocated automatically.
> > + TMPL may not be null. *TMPL must be freed by the caller, when no
> longer needed.
> > + After calling this function *TMPL_LEN will be set to the lenght of
> *TMPL. */
> > +extern int p
Hi,
Because recent gnulib has problems with read, write and close as
struct fields. I am still using:
gnulib$ git log
commit 2d431ac35c4943a3655c07ba91870d2323321b43 (HEAD -> master,
origin/master, origin/HEAD)
Here is my code:
https://git.savannah.nongnu.org/cgit/gsequencer.git/tree/ags/object
On Sun, Sep 13, 2020 at 01:12:28PM +0200, Bruno Haible wrote:
Hi John,
As this is your first major contribution to Gnulib, can you please make
sure
you have signed a copyright assignment with the FSF regarding 'GNULIB'?
Yes, I have.
> * lib/tmpdir.c (path_search_a
Hi John,
As this is your first major contribution to Gnulib, can you please make sure
you have signed a copyright assignment with the FSF regarding 'GNULIB'?
> * lib/tmpdir.c (path_search_alloc): Define new function similar to
> path_search, but which allocates the buffer for the result instead
* lib/tmpdir.c (path_search_alloc): Define new function similar to
path_search, but which allocates the buffer for the result instead
of relying on the caller to preallocate it.
*lib/tmpdir.h (path_search_alloc): Declare it.
---
lib/tmpdir.c | 127 +++--
Hi Ben,
> The prompt parameter to getpass() is declared as nonnull (using a GCC
> nonnull attribute), but the implementation checks whether it is null in
> two places. GCC warns about this. This commit removes the checks
GCC warnings ought to help us make the code more robust. Removing the
NULL
17 matches
Mail list logo
