[PATCH] gettimeofday: do not use LoadLibrary when built for Windows Store apps

2020-05-18 Thread Steve Lhomme
LoadLibrary is forbidden in such apps (can only load DLLs from within the app package). The API entries are available to all apps linking with the Windows API as found here: https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis windowsapp.lib (and mincore.lib for Windows 8) are both availa

[PATCH 2/2] stat: do not use LoadLibrary when built for Windows Store apps

2020-05-18 Thread Steve Lhomme
LoadLibrary is forbidden in such apps (can only load DLLs from within the app package). The API entries are available to all apps linking with the Windows API as found here: https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis windowsapp.lib (and mincore.lib for Windows 8) are both availa

[PATCH 1/2] stat: use a CHAR instead of TCHAR with GetFinalPathNameByHandleA

2020-05-18 Thread Steve Lhomme
The GetProcAddress uses the ANSI version of the API so the proper type for the string is LPSTR, as found here: https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfinalpathnamebyhandlea --- lib/stat-w32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

Re: Fix memleak in getdelim.m4

2020-05-18 Thread Bruno Haible
Hi Tim, > > The way to determine the answer is: > > 1. Create a test dir of all gnulib modules. > > 2. Configure it with --config-cache. > > 3. Configure it with --config-cache and your sanitizer options. > > 4. Compare the generated config.cache and config.status files. > > I am short on time an

Re: Fix memleak in getdelim.m4

2020-05-18 Thread Tim Rühsen
Hi Bruno, On 18.05.20 13:50, Bruno Haible wrote: > Hi Tim, > >> With leak sanitizer on, the test for getdelim fails due to a memory leak. > > Is this the only configure test that fails this way? The only one that fails when running GNU Poke ./configure. > I mean, it's 3 years since we last loo

Re: [PATCH v2] Rename vcs_to_changelog.py to use hyphens

2020-05-18 Thread Bruno Haible
Thanks. I'm pushing it as soon as savannah becomes responsive again. Bruno

[PATCH v2] Rename vcs_to_changelog.py to use hyphens

2020-05-18 Thread Siddhesh Poyarekar
This was needed earlier because modules had to import the main script, but that is no longer true. Rename the script so that it is consistent with all other scripts in gnulib and uses hyphens. * build-aux/vcs_to_changelog.py: Rename to... * build-aux/vcs-to-changelog.py: ... this.

Re: Fix memleak in getdelim.m4

2020-05-18 Thread Bruno Haible
Hi Tim, > With leak sanitizer on, the test for getdelim fails due to a memory leak. Is this the only configure test that fails this way? I mean, it's 3 years since we last looked for such configure test failures. [1] The way to determine the answer is: 1. Create a test dir of all gnulib modules

Fix memleak in getdelim.m4

2020-05-18 Thread Tim Rühsen
With leak sanitizer on, the test for getdelim fails due to a memory leak. The attached patch fixes it. (Please feel free to amend.) Regards, Tim Output from config.log: configure:26259: checking for working getdelim function configure:26325: gcc-10 -o conftest -O1 -g -fno-omit-frame-pointer -DF