nap() name space clash

2020-02-03 Thread Tim Rice
While attempting to test my UnixWare port of sed-4.8 I discoverd a name space clash with nap() in some gnulib files tests/test-lutimens.h tests/test-utime.c tests/test-chown.h tests/nap.h tests/test-utimens.h tests/test-stat-time.c tests/test-futimens.h tests/test-lchown.h http://uw714doc.xinuos

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Jeffrey Walton
On Mon, Feb 3, 2020 at 9:32 PM Paul Eggert wrote: > ... > How about the attached (untested) patch instead? It looks at > __apple_build_version__. Ack, tested OK on OS X 10.9 and a Linux smoke test. I was able to test _Noreturn.h through GnuTLS. I was not able to test gnulib-common.m4. (I'm still

Re: list, set, oset, map, omap: avoid imperative voice in documentation

2020-02-03 Thread Paul Eggert
I'm with Jim. The imperative style is shorter, matches the style of the imperative programming language we're using, and is more grammatical in the sense that "Free an iterator." is an English sentence whereas "Frees an iterator." is not. Plus, it's odd to use one style before a "{" and a diff

[PATCH] libc-config: port to Apple’s Clang variant

2020-02-03 Thread Paul Eggert
* lib/libc-config.h (__glibc_clang_prereq): Port to Apple’s Clang variant, which uses a different numbering scheme for __clang_major__. --- ChangeLog | 7 +++ lib/libc-config.h | 13 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog in

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Paul Eggert
On 2/3/20 3:00 PM, Jeffrey Walton wrote: Or, you can use __has_attribute(_Noreturn). __has_attribute(_Noreturn) behaves as expected. It isn't documented to work, and it doesn't work for me with clang version 9.0.0 (Fedora 9.0.0-1.fc31). I would not worry about other software using __has_at

Re: [PATCH] test-canonicalize: avoid a build failure

2020-02-03 Thread Bruno Haible
> + * tests/test-canonicalize.c: Protect the inclusion of null-ptr.h > + with the same guard as that used to protect usage of the null_ptr > + function The patch is OK. However, I would appreciate if you don't call a warning a "build failure" or an "error". Reasons: 1. Adding -Wer

[PATCH] test-canonicalize: avoid a build failure

2020-02-03 Thread Pádraig Brady
* tests/test-canonicalize.c: Protect the inclusion of null-ptr.h with the same guard as that used to protect usage of the null_ptr function, so that one doesn't get a -Werror=unused build failure, warning about the function being defined but unused. * tests/test-canonicalize-lgpl.c: Likewise. ---

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Jeffrey Walton
On Mon, Feb 3, 2020 at 4:28 PM Paul Eggert wrote: > > Looking at the online Clang manuals, it appears that Clang started > supporting _Noreturn starting with 3.5.0. So does the attached > (untested) patch work for you? If not, please advise. If interested, I can provide SSH access to a PowerMac r

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Jeffrey Walton
On Mon, Feb 3, 2020 at 4:28 PM Paul Eggert wrote: > > Looking at the online Clang manuals, it appears that Clang started > supporting _Noreturn starting with 3.5.0. So does the attached > (untested) patch work for you? If not, please advise. Thanks Paul. I think there is a small issue. There are

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Paul Eggert
Looking at the online Clang manuals, it appears that Clang started supporting _Noreturn starting with 3.5.0. So does the attached (untested) patch work for you? If not, please advise. >From 14f1146b2261ffeaacd5bc74cf034db52232bc52 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 3 Feb 2020

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Paul Eggert
On 2/3/20 9:24 AM, Paul Eggert wrote: Re the message forwarded below. First I don't see a copy of this message at so I'm taking the liberty of copying the entire thing to gnutls-de...@gnu.org. Oops, that bounced, and now I see that the

Re: Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Paul Eggert
Re the message forwarded below. First I don't see a copy of this message at so I'm taking the liberty of copying the entire thing to gnutls-de...@gnu.org. Second, your patch (attached) doesn't look right. config.h should not #define __h

Fwd: GnuTLS 3.6.12 patch for OS X 10.9

2020-02-03 Thread Jeffrey Walton
FYI... -- Forwarded message - From: Jeffrey Walton Date: Mon, Feb 3, 2020 at 3:12 AM Subject: GnuTLS 3.6.12 patch for OS X 10.9 To: Hi Everyone, I'm working from the GnuTLS 3.6.12 release tarball on OS X 10.9. The build is failing due to the handling of _Noreturn in config.h a