Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Bruno Haible
Giulio Benetti wrote: > In my specific case I'm adding package libbytesize > [1], where they add src/gettext.h But libbytesize uses gettext.h as they should: They use the file internally, without installing it in public locations upon "make install". Since you reported a redefinition warning reg

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Giulio Benetti
On 1/26/20 11:47 PM, Giulio Benetti wrote: Hi Bruno, On 1/26/20 11:12 PM, Bruno Haible wrote: Hi Giulio, Building on an environment where gettext is already present leads to emitting a warning about gettext_noop() alread defined. Where is the first definition of gettext_noop located? In ano

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Giulio Benetti
Hi Bruno, On 1/26/20 11:12 PM, Bruno Haible wrote: Hi Giulio, Building on an environment where gettext is already present leads to emitting a warning about gettext_noop() alread defined. Where is the first definition of gettext_noop located? In another copy of gettext.h? In a third-party .h

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Bruno Haible
Hi Giulio, > Building on an environment where gettext is already present leads to > emitting a warning about gettext_noop() alread defined. Where is the first definition of gettext_noop located? In another copy of gettext.h? In a third-party .h file? Or in the .c file that is being compiled? Bru

[PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-26 Thread Giulio Benetti
Building on an environment where gettext is already present leads to emitting a warning about gettext_noop() alread defined. And if -Werror is passed this warning will be treated like an error, so let's #undef gettext_noop() before #define it. Signed-off-by: Giulio Benetti --- lib/gettext.h | 1

Re: fseeko issues in mys2/mingw64

2020-01-26 Thread John Donoghue
On 1/25/20 6:11 PM, Bruno Haible wrote: - the patch was fine. Thanks for the feedback. Bruno Thanks for the quick response times and help in resolving the bug!

Re: [PATCH] regex: port to Gawk on nonstandard platforms

2020-01-26 Thread arnold
Hi. Paul. > diff --git a/lib/regex_internal.h b/lib/regex_internal.h > index 13e15e21e..6d436fde1 100644 > --- a/lib/regex_internal.h > +++ b/lib/regex_internal.h > @@ -141,6 +141,9 @@ > #ifndef SSIZE_MAX > # define SSIZE_MAX ((ssize_t) (SIZE_MAX / 2)) > #endif > +#ifndef ULONG_WIDTH > +# defin