Compile warning with mingw ("__stat64" redefined)

2019-12-16 Thread Christian Biesinger
Hello, this is pretty minor, but I did notice this warning during the compile of gnulib: ../../../gnulib/import/glob.c:75: warning: "__stat64" redefined # define __stat64(fname, buf) stat (fname, buf) In file included from /usr/share/mingw-w64/include/sys/stat.h:58, from ./sys

Re: dfa MT-safe?

2019-12-16 Thread arnold
Paul Eggert wrote: > On 12/15/19 4:43 AM, arn...@skeeve.com wrote: > > On the assumption that setlocale is the only blocker, I would rather > > see an additional `char *locale_name' parameter added to dfa_syntax. > > Thanks, this is a good suggestion. Running with it, we can improve it further >

Re: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher

2019-12-16 Thread arnold
Paul Eggert wrote: > On 12/15/19 12:14 AM, arn...@skeeve.com wrote: > > > int64_t is just as standard as ptrdiff_t and just as clear. > > Actually, int64_t is optional (as even C18 and POSIX-2018 do not require it), > whereas ptrdiff_t has been required since C89. More importantly, int64_t would

Re: intptr_t vs. uintptr_t

2019-12-16 Thread Paul Eggert
On 12/14/19 4:35 PM, Bruno Haible wrote: > the advice can be simplified: If pointer arithmetic > is involved, uintptr_t is better suited than intptr_t. And if pointer > arithmetic > is not involved, uintptr_t and intptr_t are equivalent and equally good. It's more complicated in Emacs, because Em

Re: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher

2019-12-16 Thread Paul Eggert
On 12/15/19 12:14 AM, arn...@skeeve.com wrote: > int64_t is just as standard as ptrdiff_t and just as clear. Actually, int64_t is optional (as even C18 and POSIX-2018 do not require it), whereas ptrdiff_t has been required since C89. More importantly, int64_t would be overkill on 32-bit GNU/Linux

setlocale-null: remove need for -lpthread on musl libc, *BSD, Haiku

2019-12-16 Thread Bruno Haible
This patch removes the need to link with -lpthread on several platforms, by using the "weak symbols" trick from lock.h. With this, the only platform on which setlocale-null requires -lpthread is AIX. 2019-12-16 Bruno Haible setlocale-null: Remove need for -lpthread on musl libc, *BSD,

Re: dfa MT-safe?

2019-12-16 Thread Paul Eggert
On 12/15/19 4:43 AM, arn...@skeeve.com wrote: > On the assumption that setlocale is the only blocker, I would rather > see an additional `char *locale_name' parameter added to dfa_syntax. Thanks, this is a good suggestion. Running with it, we can improve it further by putting this new flag into st