Re: time_r module does not work on MingW

2019-11-11 Thread Bruno Haible
> Here is the testcase: > #include "build-gnulib-gdbserver/config.h" > #include "pathmax.h" > #include "time.h" > > x86_64-w64-mingw32-g++ test.cc -I build-gnulib-gdbserver/import/ -I > ~/binutils-gdb/gnulib/import/ > > It turns out that the pathmax.h include is required for this to fail. > Alter

Re: Adapting changes for MSYS2?

2019-11-11 Thread Bruno Haible
I wrote: > MSYS, last released in 2016 [0], was a project with big hacks. For example, > in the 'exec' system call, it replaces an argv[i] = "/dev/null" with "nul" - MSYS2 does similar things, albeit in a more user-controllable way [1]. Bruno [1] https://github.com/msys2/msys2/wiki/Porting#user

Re: Adapting changes for MSYS2?

2019-11-11 Thread Bruno Haible
Hi Paul, > > * The patch to 'ar-lib' and 'compile' are NOT needed for supporting msys2 > >with the GCC compiler. Their ONLY effect is to support compiling with the > >MSVC compiler in an msys2 development environment. > > They're still a win for that environment though, no? So I suppose w

Re: Adapting changes for MSYS2?

2019-11-11 Thread Paul Eggert
On 11/11/19 12:51 PM, Bruno Haible wrote: But 'ar-lib' and 'compile' originate in the Automake repository and are only mirrored in Gnulib. (See config/srclist.txt.) Yes, I noticed that after patching those two. I propagated the patch into Automake to fix that. 'config.rpath' is derived fro

Re: Adapting changes for MSYS2?

2019-11-11 Thread Bruno Haible
Hi Paul, > I installed most of those changes to Gnulib. But 'ar-lib' and 'compile' originate in the Automake repository and are only mirrored in Gnulib. (See config/srclist.txt.) Similarly, 'config.rpath' is derived from libtool.m4. It does not make sense to add stuff to config.rpath before addi

Re: time_r module does not work on MingW

2019-11-11 Thread Christian Biesinger
(I accidentally sent this from the wrong email address. Please respond to my google.com address, not gmail.com) Thanks for your responses! The patch above does not fix the issue because apparently REPLACE_LOCALTIME_R is defined as GNULIB_PORTCHECK which is not defined. Replacing that with #if 1 d

Re: time_r module does not work on MingW

2019-11-11 Thread Bruno Haible
Hi, Christian Biesinger wrote: > I tried to use the time_r module with GDB (using Gnulib > revision 38237baf99386101934cd93278023aa4ae523ec0) > > However, I found that it does not compile, see logs at: > https://gdb-buildbot.osci.io/#/builders/23/builds/934 It is hard for me to do guesswork, bas

Re: time_r module does not work on MingW

2019-11-11 Thread Paul Eggert
On 11/11/19 10:56 AM, Christian Biesinger wrote: I'm not sure what the best fix is but this seems unfortunate? I don't use C++ so you'll have to help me out on this one. Would the followiung patch work, and if not why not? diff --git a/lib/time.in.h b/lib/time.in.h index 94e1da3a8..cb5fe3d8

time_r module does not work on MingW

2019-11-11 Thread Christian Biesinger
Hello! I tried to use the time_r module with GDB (using Gnulib revision 38237baf99386101934cd93278023aa4ae523ec0) However, I found that it does not compile, see logs at: https://gdb-buildbot.osci.io/#/builders/23/builds/934 Apparently, the MingW time.h has localtime_r and gmtime_r defined as __f