Hi Paul,
> feel free to further improve the citations, wording, quoting, etc.
OK...
> > There are a few nits, though:
> >* http://www.w3.org/TR/html401/loose.dtd is not a URL; it's a
> > declaration.
>
> Thanks, that should be fixed in the attached patch.
Thanks.
> >* I don't find it
> From: Bruno Haible
> Cc: bug-gnulib@gnu.org, psm...@gnu.org
> Date: Sat, 28 Sep 2019 15:29:42 +0200
>
> > > The module does not attempt to handle all of these, just the first one,
> > > because
> > > - the function access() is located at the C library level,
> > > - it is compatible with wh
Eli Zaretskii wrote:
> > There are different ways to test for "executable" on Windows:
> > - execlp/execvp,
> > - CreateProcess,
> > - system / popen, like you say,
> > - cmd.exe,
> > - surely more (PowerShell...)
> >
> > Let's assume that they work differently (cmd.exe definitely works
> From: Bruno Haible
> Cc: bug-gnulib@gnu.org, psm...@gnu.org
> Date: Sat, 28 Sep 2019 14:06:00 +0200
>
> There are different ways to test for "executable" on Windows:
> - execlp/execvp,
> - CreateProcess,
> - system / popen, like you say,
> - cmd.exe,
> - surely more (PowerShell...)
>
Eli Zaretskii wrote:
> > > > +@item
> > > > +This function does not support the @code{X_OK} mode on some platforms:
> > > > +MSVC 14.
> > >
> > > This says MSVC, but the code will do the same on MinGW, right?
> >
> > Yes, I enabled this code also on mingw. With the mingw version I tested,
> > it
Eli Zaretskii wrote:
> The value of EACCES (not EACCESS!) on MS-Windows frequently means the
> file cannot be accessed for a reason that has nothing to do with
> execute permissions. It could be, for example, that some intermediate
> directory in the full file name doesn't exist or is otherwise
>
Marcus Furlong wrote:
> FWIW I compiled libvirt without the setgroups code on Mac and it
> worked as expected. Not sure what the implications of that are though?
OK, then the fix would be to not use setgroups on Mac, and nothing to do
in gnulib. Right?
Bruno
